From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E465C4BA18 for ; Wed, 26 Feb 2020 18:13:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB0BA24650 for ; Wed, 26 Feb 2020 18:13:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB0BA24650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8154E6B000C; Wed, 26 Feb 2020 13:13:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79EBF6B0075; Wed, 26 Feb 2020 13:13:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68D616B0080; Wed, 26 Feb 2020 13:13:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 4C0026B000C for ; Wed, 26 Feb 2020 13:13:35 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 291DB824805A for ; Wed, 26 Feb 2020 18:13:35 +0000 (UTC) X-FDA: 76533075990.04.legs89_769182134c916 X-HE-Tag: legs89_769182134c916 X-Filterd-Recvd-Size: 2217 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 18:13:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E13D4AD3C; Wed, 26 Feb 2020 18:13:32 +0000 (UTC) Subject: Re: [PATCH v2] mm/slub.c: replace kmem_cache->cpu_partial with wrapped APIs To: Christopher Lameter , qiwuchen55@gmail.com Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, chenqiwu References: <1582079562-17980-1-git-send-email-qiwuchen55@gmail.com> From: Vlastimil Babka Message-ID: <182f5569-cda6-80b2-45fe-dd1f4ae66956@suse.cz> Date: Wed, 26 Feb 2020 19:13:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/22/20 4:40 AM, Christopher Lameter wrote: > On Wed, 19 Feb 2020, qiwuchen55@gmail.com wrote: > >> diff --git a/mm/slub.c b/mm/slub.c >> index 17dc00e..1eb888c 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -2284,7 +2284,7 @@ static void put_cpu_partial(struct kmem_cache *s, struct page *page, int drain) >> if (oldpage) { >> pobjects = oldpage->pobjects; >> pages = oldpage->pages; >> - if (drain && pobjects > s->cpu_partial) { >> + if (drain && pobjects > slub_cpu_partial(s)) { >> unsigned long flags; >> /* >> * partial array is full. Move the existing > > Maybe its better to not generate code for put_cpu_partial() instead of > using macros there if per cpu partials are disabled? The whole code of put_cpu_partial() is already under #ifdef CONFIG_SLUB_CPU_PARTIAL. I agree that the wrapper shouldn't be used in a function that deals only with the case that the partials do exist. It just obscures the code unnecessarily.