From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA906C43381 for ; Mon, 18 Feb 2019 18:38:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9EA8221773 for ; Mon, 18 Feb 2019 18:38:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726166AbfBRSij (ORCPT ); Mon, 18 Feb 2019 13:38:39 -0500 Received: from gateway22.websitewelcome.com ([192.185.47.144]:12542 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbfBRSii (ORCPT ); Mon, 18 Feb 2019 13:38:38 -0500 X-Greylist: delayed 1499 seconds by postgrey-1.27 at vger.kernel.org; Mon, 18 Feb 2019 13:38:37 EST Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 84D12E0C5 for ; Mon, 18 Feb 2019 11:50:04 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id vn3Mg8O2s2qH7vn3MgfMia; Mon, 18 Feb 2019 11:50:04 -0600 X-Authority-Reason: nr=8 Received: from [189.250.119.20] (port=34672 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gvn3J-004MUr-4b; Mon, 18 Feb 2019 11:50:01 -0600 To: Kalle Valo Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, "David S. Miller" , linux-kbuild@vger.kernel.org, Kees Cook References: <20180524225928.GA19570@embeddedor.com> <20180613114059.DAC95601D2@smtp.codeaurora.org> <87zhqwuggt.fsf_-_@kamboji.qca.qualcomm.com> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Autocrypt: addr=gustavo@embeddedor.com; keydata= mQINBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABtCxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPokCPQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA7kCDQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAYkCJQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Subject: Re: -Wimplicit-fallthrough not working with ccache Message-ID: <18320143-188a-8940-1830-1955e279952a@embeddedor.com> Date: Mon, 18 Feb 2019 11:49:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87zhqwuggt.fsf_-_@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.119.20 X-Source-L: No X-Exim-ID: 1gvn3J-004MUr-4b X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.119.20]:34672 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Kalle, On 2/16/19 5:21 AM, Kalle Valo wrote: > (replying to an old thread but renaming it) > > Kalle Valo writes: > >> "Gustavo A. R. Silva" wrote: >> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >>> >>> Notice that in this particular case, I replaced "pass through" with >>> a proper "fall through" comment, which is what GCC is expecting >>> to find. >>> >>> Signed-off-by: Gustavo A. R. Silva >>> Signed-off-by: Kalle Valo >> >> Patch applied to ath-next branch of ath.git, thanks. >> >> f1d270ae10ff ath10k: htt_tx: mark expected switch fall-throughs > > Gustavo, I enabled W=1 on my ath10k build checks and it took me a while > to figure out why GCC was warning about fall through annotations missing > even I knew you had fixed them. Finally I figured out that the reason > was ccache, which I need because I work with different branches and need > to recompile the kernel quite often. > > If the plan is to enable -Wimplicit-fallthrough by default in the kernel > IMHO this might become an issue, as otherwise people using ccache start > seeing lots of invalid warnings. Apparently CCACHE_COMMENTS=1 will fix > that but my version of ccache doesn't support it, and how would everyone > learn that trick anyway? Or maybe CCACHE_COMMENTS can enabled through > kernel Makefile? > Can you share with me the warning messages you get? I just see the following warnings with linux-next: $ make CC="ccache gcc" W=1 drivers/net/wireless/ath/ath10k/htt_tx.o CC [M] drivers/net/wireless/ath/ath10k/htt_tx.o In file included from drivers/net/wireless/ath/ath10k/htt_tx.c:19: drivers/net/wireless/ath/ath10k/htt.h:1727:1: warning: alignment 1 of ‘struct ath10k_htt_txbuf_32’ is less than 4 [-Wpacked-not-aligned] } __packed; ^ drivers/net/wireless/ath/ath10k/htt.h:1734:1: warning: alignment 1 of ‘struct ath10k_htt_txbuf_64’ is less than 4 [-Wpacked-not-aligned] } __packed; ^ In my Makefile I have: KBUILD_CFLAGS += $(call cc-option,-Wimplicit-fallthrough=3,) Thanks -- Gustavo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from gateway34.websitewelcome.com ([192.185.148.104]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvn3a-00081H-CE for ath10k@lists.infradead.org; Mon, 18 Feb 2019 17:50:19 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 8C6115F858 for ; Mon, 18 Feb 2019 11:50:04 -0600 (CST) References: <20180524225928.GA19570@embeddedor.com> <20180613114059.DAC95601D2@smtp.codeaurora.org> <87zhqwuggt.fsf_-_@kamboji.qca.qualcomm.com> From: "Gustavo A. R. Silva" Subject: Re: -Wimplicit-fallthrough not working with ccache Message-ID: <18320143-188a-8940-1830-1955e279952a@embeddedor.com> Date: Mon, 18 Feb 2019 11:49:59 -0600 MIME-Version: 1.0 In-Reply-To: <87zhqwuggt.fsf_-_@kamboji.qca.qualcomm.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Kees Cook , linux-kbuild@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, "David S. Miller" SGkgS2FsbGUsCgpPbiAyLzE2LzE5IDU6MjEgQU0sIEthbGxlIFZhbG8gd3JvdGU6Cj4gKHJlcGx5 aW5nIHRvIGFuIG9sZCB0aHJlYWQgYnV0IHJlbmFtaW5nIGl0KQo+IAo+IEthbGxlIFZhbG8gPGt2 YWxvQGNvZGVhdXJvcmEub3JnPiB3cml0ZXM6Cj4gCj4+ICJHdXN0YXZvIEEuIFIuIFNpbHZhIiA8 Z3VzdGF2b0BlbWJlZGRlZG9yLmNvbT4gd3JvdGU6Cj4+Cj4+PiBJbiBwcmVwYXJhdGlvbiB0byBl bmFibGluZyAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoLCBtYXJrIHN3aXRjaCBjYXNlcwo+Pj4gd2hl cmUgd2UgYXJlIGV4cGVjdGluZyB0byBmYWxsIHRocm91Z2guCj4+Pgo+Pj4gTm90aWNlIHRoYXQg aW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UsIEkgcmVwbGFjZWQgInBhc3MgdGhyb3VnaCIgd2l0aAo+ Pj4gYSBwcm9wZXIgImZhbGwgdGhyb3VnaCIgY29tbWVudCwgd2hpY2ggaXMgd2hhdCBHQ0MgaXMg ZXhwZWN0aW5nCj4+PiB0byBmaW5kLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4g Ui4gU2lsdmEgPGd1c3Rhdm9AZW1iZWRkZWRvci5jb20+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBLYWxs ZSBWYWxvIDxrdmFsb0Bjb2RlYXVyb3JhLm9yZz4KPj4KPj4gUGF0Y2ggYXBwbGllZCB0byBhdGgt bmV4dCBicmFuY2ggb2YgYXRoLmdpdCwgdGhhbmtzLgo+Pgo+PiBmMWQyNzBhZTEwZmYgYXRoMTBr OiBodHRfdHg6IG1hcmsgZXhwZWN0ZWQgc3dpdGNoIGZhbGwtdGhyb3VnaHMKPiAKPiBHdXN0YXZv LCBJIGVuYWJsZWQgVz0xIG9uIG15IGF0aDEwayBidWlsZCBjaGVja3MgYW5kIGl0IHRvb2sgbWUg YSB3aGlsZQo+IHRvIGZpZ3VyZSBvdXQgd2h5IEdDQyB3YXMgd2FybmluZyBhYm91dCBmYWxsIHRo cm91Z2ggYW5ub3RhdGlvbnMgbWlzc2luZwo+IGV2ZW4gSSBrbmV3IHlvdSBoYWQgZml4ZWQgdGhl bS4gRmluYWxseSBJIGZpZ3VyZWQgb3V0IHRoYXQgdGhlIHJlYXNvbgo+IHdhcyBjY2FjaGUsIHdo aWNoIEkgbmVlZCBiZWNhdXNlIEkgd29yayB3aXRoIGRpZmZlcmVudCBicmFuY2hlcyBhbmQgbmVl ZAo+IHRvIHJlY29tcGlsZSB0aGUga2VybmVsIHF1aXRlIG9mdGVuLgo+IAo+IElmIHRoZSBwbGFu IGlzIHRvIGVuYWJsZSAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoIGJ5IGRlZmF1bHQgaW4gdGhlIGtl cm5lbAo+IElNSE8gdGhpcyBtaWdodCBiZWNvbWUgYW4gaXNzdWUsIGFzIG90aGVyd2lzZSBwZW9w bGUgdXNpbmcgY2NhY2hlIHN0YXJ0Cj4gc2VlaW5nIGxvdHMgb2YgaW52YWxpZCB3YXJuaW5ncy4g QXBwYXJlbnRseSBDQ0FDSEVfQ09NTUVOVFM9MSB3aWxsIGZpeAo+IHRoYXQgYnV0IG15IHZlcnNp b24gb2YgY2NhY2hlIGRvZXNuJ3Qgc3VwcG9ydCBpdCwgYW5kIGhvdyB3b3VsZCBldmVyeW9uZQo+ IGxlYXJuIHRoYXQgdHJpY2sgYW55d2F5PyBPciBtYXliZSBDQ0FDSEVfQ09NTUVOVFMgY2FuIGVu YWJsZWQgdGhyb3VnaAo+IGtlcm5lbCBNYWtlZmlsZT8KPiAKCkNhbiB5b3Ugc2hhcmUgd2l0aCBt ZSB0aGUgd2FybmluZyBtZXNzYWdlcyB5b3UgZ2V0PwoKSSBqdXN0IHNlZSB0aGUgZm9sbG93aW5n IHdhcm5pbmdzIHdpdGggbGludXgtbmV4dDoKCiQgbWFrZSBDQz0iY2NhY2hlIGdjYyIgVz0xIGRy aXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvaHR0X3R4Lm8KICBDQyBbTV0gIGRyaXZlcnMv bmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvaHR0X3R4Lm8KSW4gZmlsZSBpbmNsdWRlZCBmcm9tIGRy aXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvaHR0X3R4LmM6MTk6CmRyaXZlcnMvbmV0L3dp cmVsZXNzL2F0aC9hdGgxMGsvaHR0Lmg6MTcyNzoxOiB3YXJuaW5nOiBhbGlnbm1lbnQgMSBvZiDi gJhzdHJ1Y3QgYXRoMTBrX2h0dF90eGJ1Zl8zMuKAmSBpcyBsZXNzIHRoYW4gNCBbLVdwYWNrZWQt bm90LWFsaWduZWRdCiB9IF9fcGFja2VkOwogXgpkcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRo MTBrL2h0dC5oOjE3MzQ6MTogd2FybmluZzogYWxpZ25tZW50IDEgb2Yg4oCYc3RydWN0IGF0aDEw a19odHRfdHhidWZfNjTigJkgaXMgbGVzcyB0aGFuIDQgWy1XcGFja2VkLW5vdC1hbGlnbmVkXQog fSBfX3BhY2tlZDsKIF4KCkluIG15IE1ha2VmaWxlIEkgaGF2ZToKCktCVUlMRF9DRkxBR1MgICs9 ICQoY2FsbCBjYy1vcHRpb24sLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD0zLCkKCgpUaGFua3MKLS0K R3VzdGF2bwoKCgoKCgoKCgoKCgoKCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBr Cg==