From: Frediano Ziglio <fziglio@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Lukáš Hrázký" <lhrazky@redhat.com>,
spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest
Date: Fri, 9 Nov 2018 05:20:40 -0500 (EST) [thread overview]
Message-ID: <1833668908.41731563.1541758840856.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20181109101056.oyqapawhy5jmeut4@sirius.home.kraxel.org>
> On Thu, Nov 08, 2018 at 11:05:10AM +0100, Lukáš Hrázký wrote:
> > Hello,
> >
> > On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > + * The device_display_id_{start,count} denotes the sequence of device
> > > > display
> > > > + * IDs that map to the zero-based sequence of monitor IDs provided by
> > > > monitors
> > > > + * config on this interface. For example with device_display_id_start
> > > > = 2 and
> > > > + * device_display_id_count = 3 you get the following mapping:
> > > > + * monitor_id -> device_display_id
> > > > + * 0 -> 2
> > > > + * 1 -> 3
> > > > + * 2 -> 4
> > > > + *
> > > > + * Note this example is unsupported in practice. The only supported
> > > > cases are
> > > > + * either a single device display ID (count = 1) or multiple device
> > > > display IDs
> > > > + * in a sequence starting from 0.
> > >
> > > This is confusing. The usage of this api in the qemu counterpart looks
> > > sane though.
> >
> > Not sure what you find confusing in particular... The example? Using an
> > example and then saying it's not supported?
>
> Yes, that for example. Also wondering why device_display_id doesn't
> start at zero.
>
You introduced this ID so you should remember.
It starts from 0, just this is not the first registration, the other displays
were registered to other QXL instances.
This was introduced for virtio-gpu to be able to register the different
outputs to different QXL instances so to have
first output/display:
spice_qxl_set_device_info(instance1, path1, 0, 1);
second:
spice_qxl_set_device_info(instance2, path1, 1, 1);
third:
spice_qxl_set_device_info(instance3, path1, 2, 1);
So as you can see device_display_id start from 0 but does not mean
is always 0 for every call.
> cheers,
> Gerd
>
>
>
Frediano
next prev parent reply other threads:[~2018-11-09 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 10:49 [Qemu-devel] [RFC PATCH spice/qemu v3 0/3] QXL interface to set monitor ID Lukáš Hrázký
2018-11-07 10:49 ` [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest Lukáš Hrázký
2018-11-08 6:49 ` Gerd Hoffmann
2018-11-08 10:05 ` Lukáš Hrázký
2018-11-08 16:34 ` [Qemu-devel] [Spice-devel] " Jonathon Jongsma
2018-11-09 10:10 ` [Qemu-devel] " Gerd Hoffmann
2018-11-09 10:20 ` Frediano Ziglio [this message]
2018-11-09 10:52 ` Gerd Hoffmann
2018-11-07 10:49 ` [Qemu-devel] [RFC PATCH spice v3 2/3] QXL interface: deprecate spice_qxl_set_max_monitors Lukáš Hrázký
2018-11-07 10:49 ` [Qemu-devel] [RFC PATCH qemu v3 3/3] spice: set device address and device display ID in QXL interface Lukáš Hrázký
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1833668908.41731563.1541758840856.JavaMail.zimbra@redhat.com \
--to=fziglio@redhat.com \
--cc=kraxel@redhat.com \
--cc=lhrazky@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.