From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/3] stringfns: remove rte_snprintf Date: Fri, 27 Jun 2014 02:37:09 +0200 Message-ID: <1844098.FugtUsePJs@xps13> References: <20140624090253.140206a7@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEF87D2@IRSMSX103.ger.corp.intel.com> <5590E373-EC37-4544-A983-52156CFA81E2@arbor.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Aaron Campbell , "Richardson, Bruce" Return-path: In-Reply-To: <5590E373-EC37-4544-A983-52156CFA81E2-rd7evPjynkNeoWH0uzbU5w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-06-26 13:20, Aaron Campbell: > On Jun 26, 2014, at 12:09 PM, Richardson, Bruce =20 wrote: > >> I agree we should try to use the "deprecated" attribute when possi= ble. > >> So application porting effort will be smoother. > >>=20 > >> But in this case, there is something different: as Stephen wrote, > >> rte_snprintf is useless. It's useless inside the DPDK so it's even= more > >> useless for user applications. > >> As it's really useless, it has no sense to keep it as deprecated. > >> Please, let's simply remove it. > >=20 > > The reason to keep it as deprecated is so that those customers who = don't > > want to do a huge amount of search-replace immediately can get thin= gs > > working again temporarily using -Wno-deprecated. It provides a simp= le > > temporary fallback cushion, and then we can completely remove the > > function later. So, I'd like to see us remove all our usage of the > > function internally in 1.7, along with marking as deprecated, and t= hen > > completely remove in 1.8, (i.e. in a week's time or so) :-) >=20 > As a DPDK user, I=E2=80=99d vote to kill it now. I doubt it is widel= y used in any > external applications. Such usage would be mostly from copy/pasting = the > sample code, is my guess. I think everybody understood the idea: we'll try to use deprecation mod= el when=20 possible. In this case, it's probably useless but we close the discussion by depr= ecating=20 it. We'll remove it soon, don't worry :) --=20 Thomas