From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function
Date: Tue, 10 Jul 2018 14:49:11 +0300
Message-ID: <18451995.rnOpagHzdN@avalon>
References: <20180702110729.8171-1-mahesh1.kumar@intel.com>
 <20180702110729.8171-9-mahesh1.kumar@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20180702110729.8171-9-mahesh1.kumar@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Mahesh Kumar <mahesh1.kumar@intel.com>
List-Id: dri-devel@lists.freedesktop.org

SGkgTWFoZXNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBNb25kYXksIDIgSnVseSAy
MDE4IDE0OjA3OjI3IEVFU1QgTWFoZXNoIEt1bWFyIHdyb3RlOgo+IFRoaXMgcGF0Y2ggbWFrZSBj
aGFuZ2VzIHRvIGFsbG9jYXRlIGNyYy1lbnRyaWVzIGJ1ZmZlciBiZWZvcmUKPiBlbmFibGluZyBD
UkMgZ2VuZXJhdGlvbi4KPiBJdCBtb3ZlcyBhbGwgdGhlIGZhaWx1cmUgY2hlY2sgZWFybHkgaW4g
dGhlIGZ1bmN0aW9uIGJlZm9yZSBzZXR0aW5nCj4gdGhlIHNvdXJjZSBvciBtZW1vcnkgYWxsb2Nh
dGlvbi4KPiBOb3cgc2V0X2NyY19zb3VyY2UgdGFrZXMgb25seSB0d28gdmFyaWFibGUgaW5wdXRz
LCB2YWx1ZXNfY250IHdlCj4gYWxyZWFkeSBnZXRzIGFzIHBhcnQgb2YgdmVyaWZ5X2NyY19zb3Vy
Y2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVs
LmNvbT4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFJldmlld2VkLWJ5
OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+
IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5o
ICB8ICAzICstCj4gIC4uLi9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG1f
Y3JjLmMgIHwgIDQgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9kZWJ1Z2ZzX2NyYy5jICAgICAg
ICAgICAgICAgICAgfCA1MiArKysrKysrKy0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2Rydi5oICAgICAgICAgICAgICAgICAgIHwgIDMgKy0KPiAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfcGlwZV9jcmMuYyAgICAgICAgICAgICAgfCAgNCArLQo+ICBkcml2ZXJz
L2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYyAgICAgICAgICAgICB8ICA1ICstLQo+ICBk
cml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jICAgICAgICB8ICA2ICst
LQo+ICBpbmNsdWRlL2RybS9kcm1fY3J0Yy5oICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8
ICAzICstCj4gIDggZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNTAgZGVsZXRpb25z
KC0pCgpbc25pcF0KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19j
cmMuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2RybV9kZWJ1Z2ZzX2NyYy5jIGluZGV4IGY0ZDc2NTI4
ZDI0Yy4uNzM5YTgxM2I0YjA5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVi
dWdmc19jcmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMuYwo+IEBA
IC0xMjQsMTEgKzEyNCw5IEBAIHN0YXRpYyBzc2l6ZV90IGNyY19jb250cm9sX3dyaXRlKHN0cnVj
dCBmaWxlICpmaWxlLAo+IGNvbnN0IGNoYXIgX191c2VyICp1YnVmLCBpZiAoc291cmNlW2xlbl0g
PT0gJ1xuJykKPiAgCQlzb3VyY2VbbGVuXSA9ICdcMCc7Cj4gCj4gLQlpZiAoY3J0Yy0+ZnVuY3Mt
PnZlcmlmeV9jcmNfc291cmNlKSB7Cj4gLQkJcmV0ID0gY3J0Yy0+ZnVuY3MtPnZlcmlmeV9jcmNf
c291cmNlKGNydGMsIHNvdXJjZSwgJnZhbHVlc19jbnQpOwo+IC0JCWlmIChyZXQpCj4gLQkJCXJl
dHVybiByZXQ7Cj4gLQl9Cj4gKwlyZXQgPSBjcnRjLT5mdW5jcy0+dmVyaWZ5X2NyY19zb3VyY2Uo
Y3J0Yywgc291cmNlLCAmdmFsdWVzX2NudCk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7
Cj4gCj4gIAlzcGluX2xvY2tfaXJxKCZjcmMtPmxvY2spOwo+IAo+IEBAIC0xOTMsMTIgKzE5MSwx
NSBAQCBzdGF0aWMgaW50IGNydGNfY3JjX29wZW4oc3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0
Cj4gZmlsZSAqZmlsZXApIHJldHVybiByZXQ7Cj4gIAl9Cj4gCj4gLQlpZiAoY3J0Yy0+ZnVuY3Mt
PnZlcmlmeV9jcmNfc291cmNlKSB7Cj4gLQkJcmV0ID0gY3J0Yy0+ZnVuY3MtPnZlcmlmeV9jcmNf
c291cmNlKGNydGMsIGNyYy0+c291cmNlLAo+IC0JCQkJCQkgICAgICZ2YWx1ZXNfY250KTsKPiAt
CQlpZiAocmV0KQo+IC0JCQlyZXR1cm4gcmV0Owo+IC0JfQo+ICsJcmV0ID0gY3J0Yy0+ZnVuY3Mt
PnZlcmlmeV9jcmNfc291cmNlKGNydGMsIGNyYy0+c291cmNlLCAmdmFsdWVzX2NudCk7Cj4gKwlp
ZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJaWYgKFdBUk5fT04odmFsdWVzX2NudCA+
IERSTV9NQVhfQ1JDX05SKSkKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gKwlpZiAoV0FSTl9P
Tih2YWx1ZXNfY250ID09IDApKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+IAo+ICAJc3Bpbl9sb2Nr
X2lycSgmY3JjLT5sb2NrKTsKPiAgCWlmICghY3JjLT5vcGVuZWQpCj4gQEAgLTIxMCwzMCArMjEx
LDIyIEBAIHN0YXRpYyBpbnQgY3J0Y19jcmNfb3BlbihzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1
Y3QKPiBmaWxlICpmaWxlcCkgaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+IAo+IC0JcmV0ID0g
Y3J0Yy0+ZnVuY3MtPnNldF9jcmNfc291cmNlKGNydGMsIGNyYy0+c291cmNlLCAmdmFsdWVzX2Nu
dCk7Cj4gLQlpZiAocmV0KQo+IC0JCWdvdG8gZXJyOwo+IC0KPiAtCWlmIChXQVJOX09OKHZhbHVl
c19jbnQgPiBEUk1fTUFYX0NSQ19OUikpIHsKPiAtCQlyZXQgPSAtRUlOVkFMOwo+IC0JCWdvdG8g
ZXJyX2Rpc2FibGU7Cj4gLQl9Cj4gLQo+IC0JaWYgKFdBUk5fT04odmFsdWVzX2NudCA9PSAwKSkg
ewo+IC0JCXJldCA9IC1FSU5WQUw7Cj4gLQkJZ290byBlcnJfZGlzYWJsZTsKPiAtCX0KPiAtCj4g
IAllbnRyaWVzID0ga2NhbGxvYyhEUk1fQ1JDX0VOVFJJRVNfTlIsIHNpemVvZigqZW50cmllcyks
IEdGUF9LRVJORUwpOwo+ICAJaWYgKCFlbnRyaWVzKSB7Cj4gIAkJcmV0ID0gLUVOT01FTTsKPiAt
CQlnb3RvIGVycl9kaXNhYmxlOwo+ICsJCWdvdG8gZXJyOwo+ICAJfQoKSWYgeW91IG1vdmVkIGFs
bG9jYXRpb24gYmVmb3JlIHRoZSAhY3JjLT5vcGVuZWQgY2hlY2ssIHlvdSBjb3VsZCBncm91cCB0
aGUgdHdvIApjb2RlIGJsb2NrcyBwcm90ZWN0ZWQgYnkgdGhlIGNyYy0+bG9jay4KCj4gIAlzcGlu
X2xvY2tfaXJxKCZjcmMtPmxvY2spOwo+ICAJY3JjLT5lbnRyaWVzID0gZW50cmllczsKPiAgCWNy
Yy0+dmFsdWVzX2NudCA9IHZhbHVlc19jbnQ7Cj4gKwlzcGluX3VubG9ja19pcnEoJmNyYy0+bG9j
ayk7Cj4gCj4gKwlyZXQgPSBjcnRjLT5mdW5jcy0+c2V0X2NyY19zb3VyY2UoY3J0YywgY3JjLT5z
b3VyY2UpOwo+ICsJaWYgKHJldCkKPiArCQlnb3RvIGVycjsKPiArCj4gKwlzcGluX2xvY2tfaXJx
KCZjcmMtPmxvY2spOwo+ICAJLyoKPiAgCSAqIE9ubHkgcmV0dXJuIG9uY2Ugd2UgZ290IGEgZmly
c3QgZnJhbWUsIHNvIHVzZXJzcGFjZSBkb2Vzbid0IGhhdmUgdG8KPiAgCSAqIGd1ZXNzIHdoZW4g
dGhpcyBwYXJ0aWN1bGFyIHBpZWNlIG9mIEhXIHdpbGwgYmUgcmVhZHkgdG8gc3RhcnQKPiBAQCAt
MjUwLDcgKzI0Myw3IEBAIHN0YXRpYyBpbnQgY3J0Y19jcmNfb3BlbihzdHJ1Y3QgaW5vZGUgKmlu
b2RlLCBzdHJ1Y3QKPiBmaWxlICpmaWxlcCkgcmV0dXJuIDA7Cj4gCj4gIGVycl9kaXNhYmxlOgo+
IC0JY3J0Yy0+ZnVuY3MtPnNldF9jcmNfc291cmNlKGNydGMsIE5VTEwsICZ2YWx1ZXNfY250KTsK
PiArCWNydGMtPmZ1bmNzLT5zZXRfY3JjX3NvdXJjZShjcnRjLCBOVUxMKTsKPiAgZXJyOgo+ICAJ
c3Bpbl9sb2NrX2lycSgmY3JjLT5sb2NrKTsKPiAgCWNydGNfY3JjX2NsZWFudXAoY3JjKTsKPiBA
QCAtMjYyLDkgKzI1NSw4IEBAIHN0YXRpYyBpbnQgY3J0Y19jcmNfcmVsZWFzZShzdHJ1Y3QgaW5v
ZGUgKmlub2RlLCBzdHJ1Y3QKPiBmaWxlICpmaWxlcCkgewo+ICAJc3RydWN0IGRybV9jcnRjICpj
cnRjID0gZmlsZXAtPmZfaW5vZGUtPmlfcHJpdmF0ZTsKPiAgCXN0cnVjdCBkcm1fY3J0Y19jcmMg
KmNyYyA9ICZjcnRjLT5jcmM7Cj4gLQlzaXplX3QgdmFsdWVzX2NudDsKPiAKPiAtCWNydGMtPmZ1
bmNzLT5zZXRfY3JjX3NvdXJjZShjcnRjLCBOVUxMLCAmdmFsdWVzX2NudCk7Cj4gKwljcnRjLT5m
dW5jcy0+c2V0X2NyY19zb3VyY2UoY3J0YywgTlVMTCk7Cj4gCj4gIAlzcGluX2xvY2tfaXJxKCZj
cmMtPmxvY2spOwo+ICAJY3J0Y19jcmNfY2xlYW51cChjcmMpOwo+IEBAIC0zNzAsNyArMzYyLDcg
QEAgaW50IGRybV9kZWJ1Z2ZzX2NydGNfY3JjX2FkZChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4g
IHsKPiAgCXN0cnVjdCBkZW50cnkgKmNyY19lbnQsICplbnQ7Cj4gCj4gLQlpZiAoIWNydGMtPmZ1
bmNzLT5zZXRfY3JjX3NvdXJjZSkKPiArCWlmICghY3J0Yy0+ZnVuY3MtPnNldF9jcmNfc291cmNl
IHx8ICFjcnRjLT5mdW5jcy0+dmVyaWZ5X2NyY19zb3VyY2UpCj4gIAkJcmV0dXJuIDA7Cj4gCj4g
IAljcmNfZW50ID0gZGVidWdmc19jcmVhdGVfZGlyKCJjcmMiLCBjcnRjLT5kZWJ1Z2ZzX2VudHJ5
KTsKCltzbmlwXQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp
c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=