From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH V9 0/4] mtd: read partitions compatible prop for "ofpart" type Date: Sun, 11 Mar 2018 23:35:06 +0100 Message-ID: <1849709.LgWgpBxLnY@blindfold> References: <20180130201059.4424-1-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180130201059.4424-1-zajec5@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Mark Rutland , Boris Brezillon , Florian Fainelli , Geert Uytterhoeven , devicetree@vger.kernel.org, Frank Rowand , Linus Walleij , Jonas Gorski , Marek Vasut , John Crispin , Rob Herring , linux-mtd@lists.infradead.org, Cyrille Pitchen , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Brian Norris , David Woodhouse , Peter Rosin List-Id: devicetree@vger.kernel.org UmFmYcWCLAoKQW0gRGllbnN0YWcsIDMwLiBKYW51YXIgMjAxOCwgMjE6MTA6NTUgQ0VUIHNjaHJp ZWIgUmFmYcWCIE1pxYJlY2tpOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNr aS5wbD4KPiAKPiBUaGlzIHBhdGNoc2V0IHByb3ZpZGVzIGEgcHJvcGVyIHN1cHBvcnQgZm9yIGZs YXNoIGRldmljZSBEVCBub2RlIHdpdGgKPiAicGFydGl0aW9ucyIgc3Vibm9kZSB1c2luZyAiY29t cGF0aWJsZSIgcHJvcGVydHkuIEl0J3MgYWxyZWFkeQo+IGRvY3VtZW50ZWQgaW4gdGhlOiBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL3BhcnRpdGlvbi50eHQKPiAKPiBXZSBi ZWxpZXZlZCBhIHByZXZpb3VzIHZlcnNpb24gOCB3YXMgcmVhZHkgdG8gZ28sIGJ1dCBzb29uIGFm dGVyIGxhbmRpbmcKPiBpbiB0aGUgbGludXgtbmV4dCB3ZSBnb3QgYSByZWdyZXNzaW9uIHJlcG9y dCBmcm9tIFBldGVyLgo+IAo+IFRoaXMgdmVyc2lvbiB0YWtlcyBhIHNhZmUgcGF0aCBieToKPiAx KSBSZXNwZWN0aW5nIHBhcnNlcnMgb3JkZXIgYXMgc3BlY2lmaWVkIGluIHRoZSBkZWZhdWx0L2Ry aXZlci1wcm92aWRlZAo+ICAgIGxpc3QuCj4gMikgTG9va2luZyBhdCAiY29tcGF0aWJsZSIgcHJv cGVydHkgb25seSB3aGVuICJvZnBhcnQiIHR5cGUgZ2V0cwo+ICAgIHNwZWNpaWVkLgo+IAo+IEkg ZG91YmxlLWNoZWNrZWQgdGhlIGNvZGUgYW5kIGNhbm5vdCB0aGluayBvZiBhbnkgcmVncmVzc2lv biB0aGlzIGNvdWxkCj4gY2F1c2UuIEkgYWxzbyBob3BlIHRoaXMgZGVzaWduIChyb3VnaGx5IGRp c2N1c3NlZCB3aXRoIEJvcmlzKSBjYW4gYmUKPiBhY2NlcHRhYmxlIGZvciB0aGUgbXRkIHN1YnN5 c3RlbS4KPiAKPiBUaGlzIGlzIG9mIGNvdXJzZSA0LjE3IG1hdGVyaWFsIGF0IGJlc3QuCj4gCj4g QnJpYW4gTm9ycmlzICgxKToKPiAgIG10ZDogcGFydGl0aW9uczogYWRkIG9mX21hdGNoX3RhYmxl IHBhcnNlciBtYXRjaGluZwo+IAo+IFJhZmHFgiBNacWCZWNraSAoMyk6Cj4gICBtdGQ6IHBhcnRp dGlvbnM6IGFkZCBzcGVjaWFsIHRyZWF0aW5nIGZvciB0aGUgIm9mcGFydCIgcGFyc2VyIHR5cGUK PiAgIG10ZDogcmVuYW1lICJvZnBhcnQiIHBhcnNlciB0byAiZml4ZWQtcGFydGl0aW9ucyIgYXMg aXQgZml0cyBpdCBiZXR0ZXIKPiAgIG10ZDogb2ZwYXJ0OiBhZGQgb2ZfbWF0Y2hfdGFibGUgd2l0 aCAiZml4ZWQtcGFydGl0aW9ucyIKPiAKPiAgZHJpdmVycy9tdGQvbXRkcGFydC5jICAgICAgICAg IHwgMTE2Cj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0gZHJpdmVy cy9tdGQvb2ZwYXJ0LmMgICAgICAgICAgIHwgCj4gMTggKysrKystLQo+ICBpbmNsdWRlL2xpbnV4 L210ZC9wYXJ0aXRpb25zLmggfCAgIDEgKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDEyMSBpbnNlcnRp b25zKCspLCAxNCBkZWxldGlvbnMoLSkKCkFzIGRpc2N1c3NlZCBvbiBJUkMsIDEvNCBjb25mdXNl ZCBtZS4gSXQgc2hvdWxkIGJlIHNxdWFzaGVkIGludG8gMy80IHRvIG1ha2UgCnNlbnNlLgpPdGhl ciB0aGFuIHRoYXQgSSB0aGluayB3ZSBjYW4gbWVyZ2UgdGhpcyBwYXRjaCBzZXJpZXMuCk5vdCB0 aGF0IEknbSBhIHN1cGVyIGZhbiBvZiBpdCwgYnV0IEkgY2FuIHNlZSB0aGUgdXNlLWNhc2UgYnV0 IGRvbid0IGhhdmUgYW4gCmlkZWEgaG93IHRvIHNvbHZlIHRoZSBwcm9ibGVtIGluIGEgbGVzcyBo YWNreSB3YXkuIDstXAoKSnVzdCB0byBiZSBzdXJlLCBEVCBndXlzIGFyZSBhbHNvIGhhcHB5IHdp dGggaXQsIHJpZ2h0PwoKVGhhbmtzLAovL3JpY2hhcmQKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFp bGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lilium.sigma-star.at ([109.75.188.150]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ev9XJ-0005Mo-Lb for linux-mtd@lists.infradead.org; Sun, 11 Mar 2018 22:33:51 +0000 From: Richard Weinberger To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Brian Norris , David Woodhouse , Boris Brezillon , Marek Vasut , Cyrille Pitchen , Rob Herring , Mark Rutland , Frank Rowand , Linus Walleij , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, Geert Uytterhoeven , Jonas Gorski , Florian Fainelli , John Crispin , Peter Rosin , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V9 0/4] mtd: read partitions compatible prop for "ofpart" type Date: Sun, 11 Mar 2018 23:35:06 +0100 Message-ID: <1849709.LgWgpBxLnY@blindfold> In-Reply-To: <20180130201059.4424-1-zajec5@gmail.com> References: <20180130201059.4424-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Rafa=C5=82, Am Dienstag, 30. Januar 2018, 21:10:55 CET schrieb Rafa=C5=82 Mi=C5=82ecki: > From: Rafa=C5=82 Mi=C5=82ecki >=20 > This patchset provides a proper support for flash device DT node with > "partitions" subnode using "compatible" property. It's already > documented in the: Documentation/devicetree/bindings/mtd/partition.txt >=20 > We believed a previous version 8 was ready to go, but soon after landing > in the linux-next we got a regression report from Peter. >=20 > This version takes a safe path by: > 1) Respecting parsers order as specified in the default/driver-provided > list. > 2) Looking at "compatible" property only when "ofpart" type gets > speciied. >=20 > I double-checked the code and cannot think of any regression this could > cause. I also hope this design (roughly discussed with Boris) can be > acceptable for the mtd subsystem. >=20 > This is of course 4.17 material at best. >=20 > Brian Norris (1): > mtd: partitions: add of_match_table parser matching >=20 > Rafa=C5=82 Mi=C5=82ecki (3): > mtd: partitions: add special treating for the "ofpart" parser type > mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better > mtd: ofpart: add of_match_table with "fixed-partitions" >=20 > drivers/mtd/mtdpart.c | 116 > +++++++++++++++++++++++++++++++++++++---- drivers/mtd/ofpart.c = |=20 > 18 +++++-- > include/linux/mtd/partitions.h | 1 + > 3 files changed, 121 insertions(+), 14 deletions(-) As discussed on IRC, 1/4 confused me. It should be squashed into 3/4 to mak= e=20 sense. Other than that I think we can merge this patch series. Not that I'm a super fan of it, but I can see the use-case but don't have a= n=20 idea how to solve the problem in a less hacky way. ;-\ Just to be sure, DT guys are also happy with it, right? Thanks, //richard