From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 4/4] devtools: add autotest app to build script Date: Thu, 30 Mar 2017 16:36:11 +0200 Message-ID: <1851186.Q5rVaVkRzi@xps13> References: <20170329140419.27149-1-bruce.richardson@intel.com> <20170329163856.10932-1-bruce.richardson@intel.com> <20170329163856.10932-5-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 72421D07E for ; Thu, 30 Mar 2017 16:36:13 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id w11so62395374wrc.3 for ; Thu, 30 Mar 2017 07:36:13 -0700 (PDT) In-Reply-To: <20170329163856.10932-5-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-29 17:38, Bruce Richardson: > Since the test app is no longer being build by default as part of a build, > we need to update the testbuild script to take account of this. [...] > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -229,6 +229,9 @@ for conf in $configs ; do > echo "================== Build $dir" > make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \ > EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir > + echo "================== Build tests for $dir" > + make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \ > + EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir > ! $short || break > echo "================== Build examples for $dir" > export RTE_SDK=$(pwd) It should be added after the "short break". The test-build target rebuild all. I think it should be standard apps like the examples and not re-link the libs before building. The other way is to merge it with the above command (default build).