All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Kudielka <klaus.kudielka@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] SPI updates for v6.8
Date: Tue, 23 Jan 2024 20:57:58 +0100	[thread overview]
Message-ID: <18520c6ce5361861d31547d112374f22c31f2d97.camel@gmail.com> (raw)
In-Reply-To: <a3b7790b-ce5b-407f-8089-a18c52aa7a1e@sirena.org.uk>

On Mon, 2024-01-22 at 18:38 +0000, Mark Brown wrote:
> On Mon, Jan 22, 2024 at 07:30:09PM +0100, Klaus Kudielka wrote:
> > On Sun, 2024-01-07 at 22:38 +0000, Mark Brown wrote:
> 
> > I just booted 6.8.0-rc1 on Turris Omnia (CONFIG_SPI_ORION=y,
> > device tree: arch/arm/boot/dts/marvell/armada-385-turris-omnia.dts)
> 
> > and got the following error:
> > 
> > [    0.090231] spi_master spi0: No. of CS is more than max. no. of supported CS
> > [    0.097358] spi_master spi0: Failed to create SPI device for /soc/spi@10600/flash@0
> > 
> > End result: the three MTD partitions I used to have on the SPI-NOR are gone.
> 
> Actualy looking at the DT it's not immediately obvious why this is
> triggering - there's only one chip select in use, numbered 0 AFAICT.
> Anyway, if you could test the patch I linked hopefully it does fix the
> issue.

For the records, drivers/spi/spi-orion.c states:

/* Some SoCs using this driver support up to 8 chip selects.
 * It is up to the implementer to only use the chip selects
 * that are available.
 */
#define ORION_NUM_CHIPSELECTS           8

[...]

and then in orion_spi_probe():

        host->num_chipselect = ORION_NUM_CHIPSELECTS;


      parent reply	other threads:[~2024-01-23 19:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-07 22:38 [GIT PULL] SPI updates for v6.8 Mark Brown
2024-01-09 23:41 ` pr-tracker-bot
2024-01-22 18:30 ` Klaus Kudielka
2024-01-22 18:35   ` Mark Brown
2024-01-22 18:38   ` Mark Brown
2024-01-22 18:57     ` Klaus Kudielka
2024-01-22 19:24       ` Mark Brown
2024-01-23 19:57     ` Klaus Kudielka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18520c6ce5361861d31547d112374f22c31f2d97.camel@gmail.com \
    --to=klaus.kudielka@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.