All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jakub Grajciar <jgrajcia@cisco.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
	anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] net/memif: zero-copy slave
Date: Sat, 06 Jul 2019 11:21:28 +0200	[thread overview]
Message-ID: <1852664.CeoRc8jZev@xps> (raw)
In-Reply-To: <2960f303-ac52-de02-6c4f-c5167494a2fa@intel.com>

04/07/2019 11:20, Ferruh Yigit:
> On 7/3/2019 11:44 AM, Jakub Grajciar wrote:
> > Zero-copy slave support for memif PMD.
> > Slave interface exposes DPDK memory to
> > master interface. Only single file segments
> > are supported (EAL option --single-file-segments).
> > 
> > Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
> 
> Applied to dpdk-next-net/master, thanks.

Sorry, we cannot get this patch in 19.08-rc1 because
it is accessing the memory configuration which is now internal:

    if (!mcfg->single_file_segments) {
        MIF_LOG(ERR, "Zero-copy doesn't support multi-file segments.");
        return -ENOTSUP;
    }

We need to find another way of doing this check,
or think about avoiding such limitation.

Sorry for the inconvenience.

PS: While at it, I advise to split your patch.
You are moving some functions in a new file and do some changes in the
same patch, so it is very hard to understand what are the real changes.



      reply	other threads:[~2019-07-06  9:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 10:13 [dpdk-dev] [PATCH] net/memif: zero-copy slave Jakub Grajciar
2019-07-02 10:21 ` [dpdk-dev] [PATCH v2] " Jakub Grajciar
2019-07-03 10:44   ` [dpdk-dev] [PATCH v3] " Jakub Grajciar
2019-07-04  9:20     ` Ferruh Yigit
2019-07-06  9:21       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1852664.CeoRc8jZev@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jgrajcia@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.