All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
	Ori Kam <orika@nvidia.com>, Eli Britstein <elibr@nvidia.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	Matan Azrad <matan@nvidia.com>,
	Ivan Malov <ivan.malov@oktetlabs.ru>,
	Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: announce clarification of implicit filter by port
Date: Sat, 07 Aug 2021 23:10:58 +0200	[thread overview]
Message-ID: <1852697.oEzreMCZ57@thomas> (raw)
In-Reply-To: <CACZ4nhv2zpc9tBsk9y0x7CMuh8GLqgVF2KKQytnsbyvovaGy8Q@mail.gmail.com>

> > Transfer flow rules may be applied to traffic entering switch from
> > many sources. There are flow API pattern items which allow to specify
> > ingress port match criteria explicitly, but it is not documented
> > if ethdev port used to create flow rule adds any implicit match
> > criteria and how it coexists with explicit ones.
> >
> > These aspects should be documented and drivers and applications
> > which use it in a a different way must be fixed.
> nit! "in a different way..."
> otherwise
> 
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 
> > Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Acked-by: Ori Kam <orika@nvidia.com>

+1 for clarification
Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.



  reply	other threads:[~2021-08-07 21:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 10:22 [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes Andrew Rybchenko
2021-08-01 10:22 ` [dpdk-dev] [PATCH 2/2] ethdev: announce clarification of implicit filter by port Andrew Rybchenko
2021-08-02 10:37   ` Ori Kam
2021-08-01 10:57 ` [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes Eli Britstein
2021-08-01 12:03   ` Andrew Rybchenko
2021-08-01 12:23     ` Ori Kam
2021-08-01 12:43       ` Andrew Rybchenko
2021-08-01 12:56         ` Ori Kam
2021-08-01 13:23           ` Andrew Rybchenko
2021-08-01 16:13             ` Ori Kam
2021-08-01 20:09               ` Andrew Rybchenko
2021-08-02  7:28                 ` Ori Kam
2021-08-02 10:11                   ` Andrew Rybchenko
2021-08-02  8:56                 ` Ori Kam
2021-08-02 15:49 ` Ilya Maximets
2021-08-02 19:19   ` Andrew Rybchenko
2021-08-02 19:53 ` [dpdk-dev] [PATCH v2 " Andrew Rybchenko
2021-08-02 19:53   ` [dpdk-dev] [PATCH v2 2/2] ethdev: announce clarification of implicit filter by port Andrew Rybchenko
2021-08-02 19:57 ` [dpdk-dev] [PATCH v3 1/2] ethdev: announce flow API action PORT_ID changes Andrew Rybchenko
2021-08-02 19:57   ` [dpdk-dev] [PATCH v3 2/2] ethdev: announce clarification of implicit filter by port Andrew Rybchenko
2021-08-02 21:17     ` Ajit Khaparde
2021-08-07 21:10       ` Thomas Monjalon [this message]
2021-08-02 21:20   ` [dpdk-dev] [PATCH v3 1/2] ethdev: announce flow API action PORT_ID changes Ajit Khaparde
2021-08-07 21:06     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1852697.oEzreMCZ57@thomas \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=elibr@nvidia.com \
    --cc=ferruh.yigit@intel.com \
    --cc=i.maximets@ovn.org \
    --cc=ivan.malov@oktetlabs.ru \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=viacheslav.galaktionov@oktetlabs.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.