From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf Date: Thu, 26 Apr 2018 18:10:36 +0200 Message-ID: <1854520.Legm0nyyME@xps> References: <20180310012532.15809-1-yskoh@mellanox.com> <20180426011010.28078-1-yskoh@mellanox.com> <1a65f081-4c92-78d5-b00c-08e66fdef5c8@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Yongseok Koh , wenzhuo.lu@intel.com, jingjing.wu@intel.com, olivier.matz@6wind.com, dev@dpdk.org, konstantin.ananyev@intel.com, stephen@networkplumber.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com To: Andrew Rybchenko Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 21D7E8D97 for ; Thu, 26 Apr 2018 18:10:39 +0200 (CEST) In-Reply-To: <1a65f081-4c92-78d5-b00c-08e66fdef5c8@solarflare.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/04/2018 18:05, Andrew Rybchenko: > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > +#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > > We have discussed that it would be good to deprecate RTE_MBUF_INDIRECT() > since it is not !RTE_MBUF_DIREC(). Is it lost here or intentional (may > be I've lost > in the thread)? I think it should be a separate deprecation notice.