All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: liu.ming50@gmail.com, bitbake-devel@lists.openembedded.org
Cc: stefan.agner@toradex.com, luka.pivk@toradex.com
Subject: Re: [PATCH] fetch2/gitsm: fix config file concurrent update race
Date: Fri, 25 Jan 2019 11:18:12 +0000	[thread overview]
Message-ID: <18561a9b63079e5dc2d4b4a8b6b12728475b0402.camel@linuxfoundation.org> (raw)
In-Reply-To: <1548413847-32550-1-git-send-email-liu.ming50@gmail.com>

On Fri, 2019-01-25 at 11:57 +0100, liu.ming50@gmail.com wrote:
> From: Ming Liu <liu.ming50@gmail.com>
> 
> A following issue was observed with gitsm:
> > git -c core.fsyncobjectfiles=0 config submodule... failed with exit code 255, output:
> > error: could not lock config file config: File exists
> 
> Since all git submodules share a config file and Git creates a lock
> file (.git/config.lock) to synchronize access to it, but Git only tries
> exactly once and returns a error if it's already locked. This leads to
> a race condition if there are many 'git config submodule' run in
> different processes.
> 
> It could be fixed by introducing a bitbake file lock to protect config
> file from concurrent update from submodules.
> 
> Reported-by: Stefan Agner <stefan.agner@toradex.com>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>  lib/bb/fetch2/gitsm.py | 19 +++++++++++++++----
>  1 file changed, 15 insertions(+), 4 deletions(-)

This issue should already have been fixed with recent changes to the
gitsm fetcher. Could you confirm which version of the code you were
seeing this problem with?

Cheers,

Richard



  reply	other threads:[~2019-01-25 11:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 10:57 [PATCH] fetch2/gitsm: fix config file concurrent update race liu.ming50
2019-01-25 11:18 ` Richard Purdie [this message]
2019-01-25 11:35   ` Ming Liu
2019-01-25 12:23     ` Richard Purdie
2019-01-25 13:44       ` Ming Liu
2019-01-25 14:10         ` Richard Purdie
2019-01-25 14:23           ` Ming Liu
2019-01-25 16:53         ` Mark Hatle
2019-01-25 16:42     ` Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18561a9b63079e5dc2d4b4a8b6b12728475b0402.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=liu.ming50@gmail.com \
    --cc=luka.pivk@toradex.com \
    --cc=stefan.agner@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.