All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Michal Orzel <Michal.Orzel@arm.com>
Subject: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules
Date: Fri, 20 May 2022 09:59:03 +0000	[thread overview]
Message-ID: <185A2E52-AE50-4914-BCED-3E0831EF3A8E@arm.com> (raw)
In-Reply-To: <69ec386c-6d2b-635a-0d8a-b72afe09f579@xen.org>

Hi Julien,

> On 20 May 2022, at 10:56, Julien Grall <julien@xen.org> wrote:
> 
> Hi Bertrand,
> 
> Since this patch has been committed, I get the following message for on every build (make -C xen):
> 
> which: no cppcheck in ([...])
> /bin/sh: cppcheck: command not found
> 
> I wasn't expecting the build system to check every time. I think...
> 
> On 26/04/2022 13:38, Bertrand Marquis wrote:
>> +cppcheck-version:
>> +ifeq ($(shell which $(CPPCHECK)),)
> 
> ... this is because ifeq is similar to pre-preprocessing. So it always get executed.
> 
> So far, the message is harmlesss (I can continue to build) but I think the check should really only happen when the target cppcheck-version is executed. So can you have a look to rework the rule?

Sure I will push something to fix that.

Thanks for the notice

Cheers
Bertrand

> 
> Cheers,
> 
> -- 
> Julien Grall
> 



      reply	other threads:[~2022-05-20  9:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 12:38 [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules Bertrand Marquis
2022-04-27  0:38 ` Stefano Stabellini
2022-05-09 18:22 ` Julien Grall
2022-05-10 11:49   ` Bertrand Marquis
2022-05-10 11:50     ` Julien Grall
2022-05-10 11:52       ` Bertrand Marquis
2022-05-20  9:56 ` Julien Grall
2022-05-20  9:59   ` Bertrand Marquis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=185A2E52-AE50-4914-BCED-3E0831EF3A8E@arm.com \
    --to=bertrand.marquis@arm.com \
    --cc=Michal.Orzel@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.