From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E89BC388F9 for ; Wed, 11 Nov 2020 06:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C01A220797 for ; Wed, 11 Nov 2020 06:14:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u3C6K+j1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725895AbgKKGOq (ORCPT ); Wed, 11 Nov 2020 01:14:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbgKKGOq (ORCPT ); Wed, 11 Nov 2020 01:14:46 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8971EC0613D1; Tue, 10 Nov 2020 22:14:44 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id e27so1621827lfn.7; Tue, 10 Nov 2020 22:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lEYEjKzJU66Ij93I8jWPRFuo7Pd1or5OxSnq43v1nCk=; b=u3C6K+j11FR9CFXaV+VOXGecYwd6QzEZya9r+zI3shRFCtNk2YKCxN+0npZuwEIP5C y824Nl/hx8yxsqA1zs7NdnQQ4rjDBNU4CDXEzxLFmOIjQEHkbFj0vh08mhIAruNoNkjO JSe6AuXggENBuikW7sMzMCwIVyV9mtMmIloNPUUfztbhK64OEhp8qhVFjdBPfwSDtzv0 CFx1SNiEriNpMPICEFaLSNdvh/j6gevGUy5KZA5Itd0a6X6GNXIcEkEO8JXVXlPkWTEo pjW2AYh/fOcg+V51KLFlt9rZc091RaXAK5VssQMSItVKHd9NLTURjirC8byG1kwfQB4c hgCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lEYEjKzJU66Ij93I8jWPRFuo7Pd1or5OxSnq43v1nCk=; b=aDAWuX5F5ejlDA2d7EN7Ygm2Dk8aEgUVnLPN4kjzIBiDwBwgMrpja6n1iAIJtYyHNj CmLxc/5NkAY3tnp7RKh4nkFFXOU7SyIRzD0JMv8rt75+K18ji00OUV0LABg00hKqxOWB s3hqC+ylzq138cKWnBD/F5P38sn9z9tIrS6hyP+f/1Nh7YNqoWwq15I65ZwIMjGVH5qE gRZM9KkrM44+2pTZhWCj/yUcKGecadCj9Pqi7vtNXuuCrGJ2ArPGbTVYRaC1G5F1c5Tk qOexjEo+WmZKLZ0WhhZHEzDNfyBLG3batB0t4jQ5e88fJRtwOgvSfy+vWFidpgHE+WOZ 1gKA== X-Gm-Message-State: AOAM532FSqu5iPQNuFHE0Rp6EWHqho+3Zm8yFABuoWgd1Z7V8a0FWF1k 3QrpZlhkHT6iMAylFtwq0WA= X-Google-Smtp-Source: ABdhPJzLehGf18xxtBKtRyrfI/6NG1g3yu2AS/fS5MEUZSbxrjK+f66FKyA/QSbiAyVs+WiZ9diPdA== X-Received: by 2002:a19:8854:: with SMTP id k81mr2400616lfd.195.1605075283102; Tue, 10 Nov 2020 22:14:43 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id s5sm121375lfd.58.2020.11.10.22.14.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 22:14:42 -0800 (PST) Subject: Re: [PATCH v8 09/26] memory: tegra30: Support interconnect framework To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20201111011456.7875-1-digetx@gmail.com> <20201111011456.7875-10-digetx@gmail.com> <20201111055313.tefidnmc7f4yb3jk@vireshk-i7> From: Dmitry Osipenko Message-ID: <185e9140-fdce-29ef-68c3-aa7da02b249d@gmail.com> Date: Wed, 11 Nov 2020 09:14:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201111055313.tefidnmc7f4yb3jk@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 11.11.2020 08:53, Viresh Kumar пишет: >> +static int tegra_emc_opp_table_init(struct tegra_emc *emc) >> +{ >> + struct opp_table *reg_opp_table = NULL, *clk_opp_table, *hw_opp_table; >> + u32 hw_version = BIT(tegra_sku_info.soc_speedo_id); >> + const char *rname = "core"; >> + int err; >> + >> + /* >> + * Legacy device-trees don't have OPP table and EMC driver isn't >> + * useful in this case. >> + */ >> + if (!device_property_present(emc->dev, "operating-points-v2")) { > I don't understand why you want to check this ? The below call to > dev_pm_opp_of_add_table() will fail anyway and that should be good for > you. > The dev_pm_opp_of_add_table() will produce a error message which doesn't give a clue about what's wrong, i.e. that device-tree needs to be updated. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06130C4742C for ; Wed, 11 Nov 2020 07:56:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91367205CB for ; Wed, 11 Nov 2020 07:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u3C6K+j1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91367205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA6ED6E03B; Wed, 11 Nov 2020 07:56:20 +0000 (UTC) Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by gabe.freedesktop.org (Postfix) with ESMTPS id E04AC89BBE for ; Wed, 11 Nov 2020 06:14:44 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id s30so1650454lfc.4 for ; Tue, 10 Nov 2020 22:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lEYEjKzJU66Ij93I8jWPRFuo7Pd1or5OxSnq43v1nCk=; b=u3C6K+j11FR9CFXaV+VOXGecYwd6QzEZya9r+zI3shRFCtNk2YKCxN+0npZuwEIP5C y824Nl/hx8yxsqA1zs7NdnQQ4rjDBNU4CDXEzxLFmOIjQEHkbFj0vh08mhIAruNoNkjO JSe6AuXggENBuikW7sMzMCwIVyV9mtMmIloNPUUfztbhK64OEhp8qhVFjdBPfwSDtzv0 CFx1SNiEriNpMPICEFaLSNdvh/j6gevGUy5KZA5Itd0a6X6GNXIcEkEO8JXVXlPkWTEo pjW2AYh/fOcg+V51KLFlt9rZc091RaXAK5VssQMSItVKHd9NLTURjirC8byG1kwfQB4c hgCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lEYEjKzJU66Ij93I8jWPRFuo7Pd1or5OxSnq43v1nCk=; b=nOaKSee9dJNPZwRSrWw7RA4AJTwGf1qwJez82uMs+0HkFq5S+r7clqGM4JB+pNFcFf 7GGaiE56r8Xg6xNW7P4Vmy01GBPxQQyO9/NrzeaRYirY8us9IXOXrB1P0PzldrIHzTOB CLVIOP7+38D61YjsE3klAzmjguKVkzxtIILgM8WsY4Gm/LUtNTCVQF9urSGv+wADxu8Q IZPRG6w9BWckpqaw7anjirLQRnhv8D5pl2ypxtrz4xUS/KH2p2hDtjv++QkbgrAU0zaX PoC5spNYJZAfzlO+fnwGb9MN0mioyM9X7QXxH2DIrwNf/BvH1CooZiE1sSi2v1vxuVc+ 6GAw== X-Gm-Message-State: AOAM531pvdNWv1ZT3EHjxpZUw/KHGWfL3KzE4timNl8pLwkYr9QoUm4W UpCZfM2hi/aRbXoA4UfiXI8i1K+ygFU= X-Google-Smtp-Source: ABdhPJzLehGf18xxtBKtRyrfI/6NG1g3yu2AS/fS5MEUZSbxrjK+f66FKyA/QSbiAyVs+WiZ9diPdA== X-Received: by 2002:a19:8854:: with SMTP id k81mr2400616lfd.195.1605075283102; Tue, 10 Nov 2020 22:14:43 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id s5sm121375lfd.58.2020.11.10.22.14.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 22:14:42 -0800 (PST) Subject: Re: [PATCH v8 09/26] memory: tegra30: Support interconnect framework To: Viresh Kumar References: <20201111011456.7875-1-digetx@gmail.com> <20201111011456.7875-10-digetx@gmail.com> <20201111055313.tefidnmc7f4yb3jk@vireshk-i7> From: Dmitry Osipenko Message-ID: <185e9140-fdce-29ef-68c3-aa7da02b249d@gmail.com> Date: Wed, 11 Nov 2020 09:14:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201111055313.tefidnmc7f4yb3jk@vireshk-i7> Content-Language: en-US X-Mailman-Approved-At: Wed, 11 Nov 2020 07:54:43 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Krzysztof Kozlowski , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MTEuMTEuMjAyMCAwODo1MywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4+ICtzdGF0aWMgaW50 IHRlZ3JhX2VtY19vcHBfdGFibGVfaW5pdChzdHJ1Y3QgdGVncmFfZW1jICplbWMpCj4+ICt7Cj4+ ICsJc3RydWN0IG9wcF90YWJsZSAqcmVnX29wcF90YWJsZSA9IE5VTEwsICpjbGtfb3BwX3RhYmxl LCAqaHdfb3BwX3RhYmxlOwo+PiArCXUzMiBod192ZXJzaW9uID0gQklUKHRlZ3JhX3NrdV9pbmZv LnNvY19zcGVlZG9faWQpOwo+PiArCWNvbnN0IGNoYXIgKnJuYW1lID0gImNvcmUiOwo+PiArCWlu dCBlcnI7Cj4+ICsKPj4gKwkvKgo+PiArCSAqIExlZ2FjeSBkZXZpY2UtdHJlZXMgZG9uJ3QgaGF2 ZSBPUFAgdGFibGUgYW5kIEVNQyBkcml2ZXIgaXNuJ3QKPj4gKwkgKiB1c2VmdWwgaW4gdGhpcyBj YXNlLgo+PiArCSAqLwo+PiArCWlmICghZGV2aWNlX3Byb3BlcnR5X3ByZXNlbnQoZW1jLT5kZXYs ICJvcGVyYXRpbmctcG9pbnRzLXYyIikpIHsKPiBJIGRvbid0IHVuZGVyc3RhbmQgd2h5IHlvdSB3 YW50IHRvIGNoZWNrIHRoaXMgPyBUaGUgYmVsb3cgY2FsbCB0bwo+IGRldl9wbV9vcHBfb2ZfYWRk X3RhYmxlKCkgd2lsbCBmYWlsIGFueXdheSBhbmQgdGhhdCBzaG91bGQgYmUgZ29vZCBmb3IKPiB5 b3UuCj4gCgpUaGUgZGV2X3BtX29wcF9vZl9hZGRfdGFibGUoKSB3aWxsIHByb2R1Y2UgYSBlcnJv ciBtZXNzYWdlIHdoaWNoIGRvZXNuJ3QKZ2l2ZSBhIGNsdWUgYWJvdXQgd2hhdCdzIHdyb25nLCBp LmUuIHRoYXQgZGV2aWNlLXRyZWUgbmVlZHMgdG8gYmUgdXBkYXRlZC4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==