From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v10 19/19] mbuf: remove old packet type bit
	masks
Date: Mon, 13 Jul 2015 18:27:43 +0200
Message-ID: <1862129.zWrQIqxoo8@xps13>
References: <1435912347-19499-1-git-send-email-helin.zhang@intel.com>
 <2161590.Y1eMLetJSj@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A89385B@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Zhang, Helin" <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 53703569C
 for <dev@dpdk.org>; Mon, 13 Jul 2015 18:28:57 +0200 (CEST)
Received: by widjy10 with SMTP id jy10so74688833wid.1
 for <dev@dpdk.org>; Mon, 13 Jul 2015 09:28:57 -0700 (PDT)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A89385B@SHSMSX104.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-13 16:25, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-07-10 00:31, Helin Zhang:
> > > As unified packet types are used instead, those old bit masks and the
> > > relevant macros for packet type indication need to be removed.
> > 
> > It breaks mlx4 and cxgbe drivers.
[...]
> I think I have already reworked with that changes in v9 and v10 recently.
> http://www.dpdk.org/dev/patchwork/patch/6253/

No, your changes were for t4_ethrx_handler().
Since recent cxgbe change, we also need to update process_responses().

> > The cxgbe changes need to be updated after
> > 78fc1a716ae8 ("cxgbe: improve Rx performance") I suggest this update:
> > 
> > --- a/drivers/net/cxgbe/sge.c
> > +++ b/drivers/net/cxgbe/sge.c
> > @@ -1419,7 +1419,11 @@ static int process_responses(struct sge_rspq *q, int
> > budget,
> >                         unmap_rx_buf(&rxq->fl);
> > 
> >                         if (cpl->l2info & htonl(F_RXF_IP)) {
> > +#ifdef RTE_NEXT_ABI
> > +                               mbuf->packet_type = RTE_PTYPE_L3_IPV4;
> > +#else
> >                                 pkt->ol_flags |= PKT_RX_IPV4_HDR;
> > +#endif
> >                                 if (unlikely(!csum_ok))
> >                                         pkt->ol_flags |=
> > PKT_RX_IP_CKSUM_BAD;
> > 
> > @@ -1427,7 +1431,11 @@ static int process_responses(struct sge_rspq *q, int
> > budget,
> >                                      htonl(F_RXF_UDP | F_RXF_TCP))
> > && !csum_ok)
> >                                         pkt->ol_flags |=
> > PKT_RX_L4_CKSUM_BAD;
> >                         } else if (cpl->l2info & htonl(F_RXF_IP6)) {
> > +#ifdef RTE_NEXT_ABI
> > +                               mbuf->packet_type = RTE_PTYPE_L3_IPV6;
> > +#else
> >                                 pkt->ol_flags |= PKT_RX_IPV6_HDR;
> > +#endif
> >                         }
>