From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:48860 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbeIZTGC (ORCPT ); Wed, 26 Sep 2018 15:06:02 -0400 From: Laurent Pinchart To: Thomas Zimmermann Cc: kieran.bingham+renesas@ideasonboard.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put Date: Wed, 26 Sep 2018 15:53:25 +0300 Message-ID: <1865239.8JzXlkvomL@avalon> In-Reply-To: <2721d64e-f3a4-9e0a-3af8-dfec8b1bd90c@suse.de> References: <20180926115525.24500-1-tzimmermann@suse.de> <7e35303c-7bcd-1c6b-6986-40c4413e57aa@ideasonboard.com> <2721d64e-f3a4-9e0a-3af8-dfec8b1bd90c@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Thomas, On Wednesday, 26 September 2018 15:26:38 EEST Thomas Zimmermann wrote: > Hi, > > thanks for reviewing the patch and the one for rcar-du. Please also add > them to your tree. I took both patches in my tree. Thank you. > Am 26.09.18 um 14:14 schrieb Kieran Bingham: > > On 26/09/18 12:55, Thomas Zimmermann wrote: > >> This patch unifies the naming of DRM functions for reference counting > >> of struct drm_device. The resulting code is more aligned with the rest > >> of the Linux kernel interfaces. > >> > >> Signed-off-by: Thomas Zimmermann > >> Reviewed-by: Simon Horman > > > > Reviewed-by: Kieran Bingham > > > >> --- > >> > >> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index > >> 6ececad6f845..8554102a6ead 100644 > >> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> drm_irq_uninstall(ddev); > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> > >> return 0; > >> } > >> > >> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> > >> err_free_drm_dev: > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> return ret; > >> } > >> -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put Date: Wed, 26 Sep 2018 15:53:25 +0300 Message-ID: <1865239.8JzXlkvomL@avalon> References: <20180926115525.24500-1-tzimmermann@suse.de> <7e35303c-7bcd-1c6b-6986-40c4413e57aa@ideasonboard.com> <2721d64e-f3a4-9e0a-3af8-dfec8b1bd90c@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99FCA6E451 for ; Wed, 26 Sep 2018 12:53:11 +0000 (UTC) In-Reply-To: <2721d64e-f3a4-9e0a-3af8-dfec8b1bd90c@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: linux-renesas-soc@vger.kernel.org, kieran.bingham+renesas@ideasonboard.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVGhvbWFzLAoKT24gV2VkbmVzZGF5LCAyNiBTZXB0ZW1iZXIgMjAxOCAxNToyNjozOCBFRVNU IFRob21hcyBaaW1tZXJtYW5uIHdyb3RlOgo+IEhpLAo+IAo+IHRoYW5rcyBmb3IgcmV2aWV3aW5n IHRoZSBwYXRjaCBhbmQgdGhlIG9uZSBmb3IgcmNhci1kdS4gUGxlYXNlIGFsc28gYWRkCj4gdGhl bSB0byB5b3VyIHRyZWUuCgpJIHRvb2sgYm90aCBwYXRjaGVzIGluIG15IHRyZWUuIFRoYW5rIHlv dS4KCj4gQW0gMjYuMDkuMTggdW0gMTQ6MTQgc2NocmllYiBLaWVyYW4gQmluZ2hhbToKPiA+IE9u IDI2LzA5LzE4IDEyOjU1LCBUaG9tYXMgWmltbWVybWFubiB3cm90ZToKPiA+PiBUaGlzIHBhdGNo IHVuaWZpZXMgdGhlIG5hbWluZyBvZiBEUk0gZnVuY3Rpb25zIGZvciByZWZlcmVuY2UgY291bnRp bmcKPiA+PiBvZiBzdHJ1Y3QgZHJtX2RldmljZS4gVGhlIHJlc3VsdGluZyBjb2RlIGlzIG1vcmUg YWxpZ25lZCB3aXRoIHRoZSByZXN0Cj4gPj4gb2YgdGhlIExpbnV4IGtlcm5lbCBpbnRlcmZhY2Vz Lgo+ID4+IAo+ID4+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFu bkBzdXNlLmRlPgo+ID4+IFJldmlld2VkLWJ5OiBTaW1vbiBIb3JtYW4gPGhvcm1zK3JlbmVzYXNA dmVyZ2UubmV0LmF1Pgo+ID4gCj4gPiBSZXZpZXdlZC1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJh bi5iaW5naGFtK3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiA+IAo+ID4+IC0tLQo+ID4+IAo+ ID4+ICBkcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2Rydi5jIHwgNCArKy0tCj4g Pj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPj4g Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fZHJ2 LmMKPiA+PiBiL2RyaXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fZHJ2LmMgaW5kZXgK PiA+PiA2ZWNlY2FkNmY4NDUuLjg1NTQxMDJhNmVhZCAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2Rydi5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3NobW9iaWxlL3NobW9iX2RybV9kcnYuYwo+ID4+IEBAIC0xOTQsNyArMTk0LDcgQEAgc3Rh dGljIGludCBzaG1vYl9kcm1fcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UKPiA+PiAqcGRl dikKPiA+PiAgCWRybV9rbXNfaGVscGVyX3BvbGxfZmluaShkZGV2KTsKPiA+PiAgCWRybV9tb2Rl X2NvbmZpZ19jbGVhbnVwKGRkZXYpOwo+ID4+ICAJZHJtX2lycV91bmluc3RhbGwoZGRldik7Cj4g Pj4gLQlkcm1fZGV2X3VucmVmKGRkZXYpOwo+ID4+ICsJZHJtX2Rldl9wdXQoZGRldik7Cj4gPj4g Cj4gPj4gIAlyZXR1cm4gMDsKPiA+PiAgfQo+ID4+IAo+ID4+IEBAIC0yOTAsNyArMjkwLDcgQEAg c3RhdGljIGludCBzaG1vYl9kcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZQo+ID4+ICpw ZGV2KQo+ID4+ICAJZHJtX2ttc19oZWxwZXJfcG9sbF9maW5pKGRkZXYpOwo+ID4+ICAJZHJtX21v ZGVfY29uZmlnX2NsZWFudXAoZGRldik7Cj4gPj4gIAo+ID4+ICBlcnJfZnJlZV9kcm1fZGV2Ogo+ ID4+IC0JZHJtX2Rldl91bnJlZihkZGV2KTsKPiA+PiArCWRybV9kZXZfcHV0KGRkZXYpOwo+ID4+ ICAJcmV0dXJuIHJldDsKPiA+PiAgfQo+ID4+IAoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNo YXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=