From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758061AbcCVAnM (ORCPT ); Mon, 21 Mar 2016 20:43:12 -0400 Received: from gloria.sntech.de ([95.129.55.99]:48710 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754524AbcCVAnL convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2016 20:43:11 -0400 From: Heiko Stuebner To: Yakir Yang Cc: David Airlie , Mark Yao , Joonyoung Shim , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Emil Velikov Subject: Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Date: Tue, 22 Mar 2016 01:42:50 +0100 Message-ID: <1867694.1mDULrSexE@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <56EFE66A.8020404@rock-chips.com> References: <1458552518-25527-1-git-send-email-ykk@rock-chips.com> <1511371.I0NIYzh3kP@diego> <56EFE66A.8020404@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yakir, Am Montag, 21. März 2016, 20:17:46 schrieb Yakir Yang: > On 03/21/2016 07:29 PM, Heiko Stübner wrote: > > Am Montag, 21. März 2016, 17:28:38 schrieb Yakir Yang: > >> This patch set would add the RGA direct rendering based 2d graphics > >> acceleration module. > > > > very cool to see that. > > ;) > > >> This patch set is based on git repository below: > >> git://people.freedesktop.org/~airlied/linux drm-next > >> commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7 > >> > >> And the RGA driver is based on Exynos G2D driver, it only manages the > >> command lists received from user, so user should make the command list > >> to data and registers needed by operation to use. > >> > >> I have prepared an userspace demo application for testing: > >> https://github.com/yakir-Yang/libdrm-rockchip > >> > >> That is a rockchip libdrm library, and I have write a simple test case > >> "rockchip_rga_test" that would test the below RGA features: > >> - solid > >> - copy > >> - rotation > >> - flip > >> - window clip > >> - dithering > > > > Did you submit your libdrm changes as well? > > > > Userspace-interfaces need to be stable so the other side must also get > > accepted - even before the kernel change if I remember correctly. > > Got it, and I just saw exynos_fimg2d already landed at mainline libdrm. > But I don't find the way to submit patches to libdrm, would you like > share some helps here ;) Looking at the libdrm sources on cgit.freedesktop.org, I did not find any specific manual on submitting patches. But looking at the dri-list archive, dri-devel@lists.freedesktop.org is the right list and looking at the libdrm history it looks like Emil Velikov seems to be doing maintenance-stuff in libdrm. And as a 3rd recipient, please also include the linux-rockchip list. @Emil, please shout if I read that wrong :-) Hope that helps Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Date: Tue, 22 Mar 2016 01:42:50 +0100 Message-ID: <1867694.1mDULrSexE@phil> References: <1458552518-25527-1-git-send-email-ykk@rock-chips.com> <1511371.I0NIYzh3kP@diego> <56EFE66A.8020404@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56EFE66A.8020404@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang Cc: devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , Emil Velikov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgWWFraXIsCgpBbSBNb250YWcsIDIxLiBNw6RyeiAyMDE2LCAyMDoxNzo0NiBzY2hyaWViIFlh a2lyIFlhbmc6Cj4gT24gMDMvMjEvMjAxNiAwNzoyOSBQTSwgSGVpa28gU3TDvGJuZXIgd3JvdGU6 Cj4gPiBBbSBNb250YWcsIDIxLiBNw6RyeiAyMDE2LCAxNzoyODozOCBzY2hyaWViIFlha2lyIFlh bmc6Cj4gPj4gVGhpcyBwYXRjaCBzZXQgd291bGQgYWRkIHRoZSBSR0EgZGlyZWN0IHJlbmRlcmlu ZyBiYXNlZCAyZCBncmFwaGljcwo+ID4+IGFjY2VsZXJhdGlvbiBtb2R1bGUuCj4gPiAKPiA+IHZl cnkgY29vbCB0byBzZWUgdGhhdC4KPiAKPiA7KQo+IAo+ID4+IFRoaXMgcGF0Y2ggc2V0IGlzIGJh c2VkIG9uIGdpdCByZXBvc2l0b3J5IGJlbG93Ogo+ID4+IGdpdDovL3Blb3BsZS5mcmVlZGVza3Rv cC5vcmcvfmFpcmxpZWQvbGludXggZHJtLW5leHQKPiA+PiBjb21taXQgaWQ6IDU2OGQ3Yzc2NGFl MDFmMzcwNjA4NWFjOGYwZDhhOGFjN2U4MjZiZDcKPiA+PiAKPiA+PiBBbmQgdGhlIFJHQSBkcml2 ZXIgaXMgYmFzZWQgb24gRXh5bm9zIEcyRCBkcml2ZXIsIGl0IG9ubHkgbWFuYWdlcyB0aGUKPiA+ PiBjb21tYW5kIGxpc3RzIHJlY2VpdmVkIGZyb20gdXNlciwgc28gdXNlciBzaG91bGQgbWFrZSB0 aGUgY29tbWFuZCBsaXN0Cj4gPj4gdG8gZGF0YSBhbmQgcmVnaXN0ZXJzIG5lZWRlZCBieSBvcGVy YXRpb24gdG8gdXNlLgo+ID4+IAo+ID4+IEkgaGF2ZSBwcmVwYXJlZCBhbiB1c2Vyc3BhY2UgZGVt byBhcHBsaWNhdGlvbiBmb3IgdGVzdGluZzoKPiA+PiAJaHR0cHM6Ly9naXRodWIuY29tL3lha2ly LVlhbmcvbGliZHJtLXJvY2tjaGlwCj4gPj4gCj4gPj4gVGhhdCBpcyBhIHJvY2tjaGlwIGxpYmRy bSBsaWJyYXJ5LCBhbmQgSSBoYXZlIHdyaXRlIGEgc2ltcGxlIHRlc3QgY2FzZQo+ID4+ICJyb2Nr Y2hpcF9yZ2FfdGVzdCIgdGhhdCB3b3VsZCB0ZXN0IHRoZSBiZWxvdyBSR0EgZmVhdHVyZXM6Cj4g Pj4gLSBzb2xpZAo+ID4+IC0gY29weQo+ID4+IC0gcm90YXRpb24KPiA+PiAtIGZsaXAKPiA+PiAt IHdpbmRvdyBjbGlwCj4gPj4gLSBkaXRoZXJpbmcKPiA+IAo+ID4gRGlkIHlvdSBzdWJtaXQgeW91 ciBsaWJkcm0gY2hhbmdlcyBhcyB3ZWxsPwo+ID4gCj4gPiBVc2Vyc3BhY2UtaW50ZXJmYWNlcyBu ZWVkIHRvIGJlIHN0YWJsZSBzbyB0aGUgb3RoZXIgc2lkZSBtdXN0IGFsc28gZ2V0Cj4gPiBhY2Nl cHRlZCAtIGV2ZW4gYmVmb3JlIHRoZSBrZXJuZWwgY2hhbmdlIGlmIEkgcmVtZW1iZXIgY29ycmVj dGx5Lgo+IAo+IEdvdCBpdCwgYW5kIEkganVzdCBzYXcgZXh5bm9zX2ZpbWcyZCBhbHJlYWR5IGxh bmRlZCBhdCBtYWlubGluZSBsaWJkcm0uCj4gQnV0IEkgZG9uJ3QgZmluZCB0aGUgd2F5IHRvIHN1 Ym1pdCBwYXRjaGVzIHRvIGxpYmRybSwgd291bGQgeW91IGxpa2UKPiBzaGFyZSBzb21lIGhlbHBz IGhlcmUgOykKCkxvb2tpbmcgYXQgdGhlIGxpYmRybSBzb3VyY2VzIG9uIGNnaXQuZnJlZWRlc2t0 b3Aub3JnLCBJIGRpZCBub3QgZmluZCBhbnkgCnNwZWNpZmljIG1hbnVhbCBvbiBzdWJtaXR0aW5n IHBhdGNoZXMuCgpCdXQgbG9va2luZyBhdCB0aGUgZHJpLWxpc3QgYXJjaGl2ZSwgZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZyBpcyB0aGUgCnJpZ2h0IGxpc3QgYW5kIGxvb2tpbmcgYXQg dGhlIGxpYmRybSBoaXN0b3J5IGl0IGxvb2tzIGxpa2UgRW1pbCBWZWxpa292IAo8ZW1pbC5sLnZl bGlrb3ZAZ21haWwuY29tPiBzZWVtcyB0byBiZSBkb2luZyBtYWludGVuYW5jZS1zdHVmZiBpbiBs aWJkcm0uCkFuZCBhcyBhIDNyZCByZWNpcGllbnQsIHBsZWFzZSBhbHNvIGluY2x1ZGUgdGhlIGxp bnV4LXJvY2tjaGlwIGxpc3QuCgpARW1pbCwgcGxlYXNlIHNob3V0IGlmIEkgcmVhZCB0aGF0IHdy b25nIDotKQoKCkhvcGUgdGhhdCBoZWxwcwpIZWlrbwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Tue, 22 Mar 2016 01:42:50 +0100 Subject: [RFC PATCH v1 0/4] Add Rockchip RGA support In-Reply-To: <56EFE66A.8020404@rock-chips.com> References: <1458552518-25527-1-git-send-email-ykk@rock-chips.com> <1511371.I0NIYzh3kP@diego> <56EFE66A.8020404@rock-chips.com> Message-ID: <1867694.1mDULrSexE@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Yakir, Am Montag, 21. M?rz 2016, 20:17:46 schrieb Yakir Yang: > On 03/21/2016 07:29 PM, Heiko St?bner wrote: > > Am Montag, 21. M?rz 2016, 17:28:38 schrieb Yakir Yang: > >> This patch set would add the RGA direct rendering based 2d graphics > >> acceleration module. > > > > very cool to see that. > > ;) > > >> This patch set is based on git repository below: > >> git://people.freedesktop.org/~airlied/linux drm-next > >> commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7 > >> > >> And the RGA driver is based on Exynos G2D driver, it only manages the > >> command lists received from user, so user should make the command list > >> to data and registers needed by operation to use. > >> > >> I have prepared an userspace demo application for testing: > >> https://github.com/yakir-Yang/libdrm-rockchip > >> > >> That is a rockchip libdrm library, and I have write a simple test case > >> "rockchip_rga_test" that would test the below RGA features: > >> - solid > >> - copy > >> - rotation > >> - flip > >> - window clip > >> - dithering > > > > Did you submit your libdrm changes as well? > > > > Userspace-interfaces need to be stable so the other side must also get > > accepted - even before the kernel change if I remember correctly. > > Got it, and I just saw exynos_fimg2d already landed at mainline libdrm. > But I don't find the way to submit patches to libdrm, would you like > share some helps here ;) Looking at the libdrm sources on cgit.freedesktop.org, I did not find any specific manual on submitting patches. But looking at the dri-list archive, dri-devel at lists.freedesktop.org is the right list and looking at the libdrm history it looks like Emil Velikov seems to be doing maintenance-stuff in libdrm. And as a 3rd recipient, please also include the linux-rockchip list. @Emil, please shout if I read that wrong :-) Hope that helps Heiko