From: "Chen Qi" <Qi.Chen@windriver.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
Khem Raj <raj.khem@gmail.com>
Cc: Persian Prince <persianpros@yahoo.com>,
OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/8] PEP8 double aggressive E401
Date: Tue, 29 Jun 2021 10:26:53 +0800 [thread overview]
Message-ID: <1869df62-d92a-e50f-f185-63a9e436e4b8@windriver.com> (raw)
In-Reply-To: <CANNYZj9EGpuL43yGADeGXfjhhGB8EnghfzC8Zee4N=gUdBi4Dw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 31779 bytes --]
On 06/29/2021 03:47 AM, Alexander Kanavin wrote:
> I just generally disagree with the idea that changing a = b to a=b, or
> import a,b to import a\nimport b helps readability or reduces confusion.
>
Writing 'a =b' is acceptable, as it's not causing runtime problem.
However, keeping a consistent 'a=b' is better. Isn't it?
Just think about writing 'a= b'? Is it acceptable?
I think patches to make codes have a consistent style are good.
> I'm reading a lot of python code all the time, and never once have
> been confused by inconsistent whitespace.
>
No one confuses. But consistent codes give people better impression.
> Can the linter fix anything else, which has actual benefit?
>
Keeping codes in the same style is the actual benefit.
People might not have time to do the check and send out patches, but if
someone has already done that and sent out patches, why not accept the
patches?
Best Regards,
Chen Qi
> Alex
>
> On Mon, 28 Jun 2021 at 21:41, Khem Raj <raj.khem@gmail.com
> <mailto:raj.khem@gmail.com>> wrote:
>
> On Mon, Jun 28, 2021 at 12:25 PM Persian Prince
> <persianpros@yahoo.com <mailto:persianpros@yahoo.com>> wrote:
> >
> > When we can follow PEP8 we should as it's how developers could
> follow a common coding style and avoid creating different files.
> >
> > In "Safe PEP8" PRs some PEP8 codes carefully added so it won't
> change tabs to spaces but makes the code cleaner in a safe way.
> PEP8 also fixes some small problems (won't do huge changes like
> futurize) which is good and sometime we miss them by mistake.
> >
> > We at https://github.com/OpenVisionE2
> <https://urldefense.com/v3/__https://github.com/OpenVisionE2__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6QWMweTw$>
> , https://github.com/oe-alliance
> <https://urldefense.com/v3/__https://github.com/oe-alliance__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6ROP1INw$>
> and https://github.com/OpenPLi
> <https://urldefense.com/v3/__https://github.com/OpenPLi__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7D6O7-Kg$>
> applied safe PEP8 changes to so many repositories and we're using
> it via PEP8.sh
> <https://urldefense.com/v3/__http://PEP8.sh__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy4ewWfxFw$>
> on GitHub Actions as an online cleaner tool. (PEP8.sh
> <https://urldefense.com/v3/__http://PEP8.sh__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy4ewWfxFw$>:
> https://github.com/OpenVisionE2/enigma2-openvision/blob/develop/CI/PEP8.sh
> <https://urldefense.com/v3/__https://github.com/OpenVisionE2/enigma2-openvision/blob/develop/CI/PEP8.sh__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7J7fBYZQ$>)
> >
> > Also applied before on
> https://github.com/openembedded/meta-openembedded
> <https://urldefense.com/v3/__https://github.com/openembedded/meta-openembedded__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy4qmKWVZQ$>
> which is why that repo is clean and won't need a PR (for now),
> keep in mind that these are common standards so even if we don't
> like them that much still they help for having a good common style
> and less mistakes.
> >
> > If you needed more assistance from me please don't hesitate to
> ask, I'm all in.
>
>
> can you improve the commit msgs in pull request as asked.
>
> >
> > Regards,
> > Persian Prince
> >
> > On Monday, June 28, 2021, 10:56:40 AM GMT+4:30, Alexander
> Kanavin <alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>>
> wrote:
> >
> >
> > Right, but can you please write something more descriptive than
> "PEP8 double aggressive W291 ~ W293 and W391" ?
> >
> > Also I'm not sure fiddling about with whitespace or whether
> imports all need their own line really helps.
> >
> > Alex
> >
> > On Mon, 28 Jun 2021 at 08:16, Khem Raj <raj.khem@gmail.com
> <mailto:raj.khem@gmail.com>> wrote:
> >
> > On Sun, Jun 27, 2021 at 11:13 PM Alexander Kanavin
> > <alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>> wrote:
> > >
> > > Wait, what is this patchset all about?
> > >
> >
> > its fixes for python linter (pylint) found issues.
> >
> > > Alex
> > >
> > > On Mon, 28 Jun 2021 at 07:59, Khem Raj <raj.khem@gmail.com
> <mailto:raj.khem@gmail.com>> wrote:
> > >>
> > >> From: persianpros <persianpros@yahoo.com
> <mailto:persianpros@yahoo.com>>
> > >>
> > >> Signed-off-by: Khem Raj <raj.khem@gmail.com
> <mailto:raj.khem@gmail.com>>
> > >> ---
> > >> meta/lib/oe/package.py | 9 +++++++--
> > >> meta/lib/oe/qa.py | 4 +++-
> > >> meta/lib/oe/utils.py | 6 ++++--
> > >> meta/lib/oeqa/oetest.py | 4 +++-
> > >> meta/lib/oeqa/sdk/case.py | 3 ++-
> > >> meta/lib/oeqa/sdk/cases/buildlzip.py | 5 ++++-
> > >> meta/lib/oeqa/sdk/cases/python.py | 3 ++-
> > >> meta/lib/oeqa/sdk/testsdk.py | 3 ++-
> > >> meta/lib/oeqa/selftest/cases/oelib/path.py | 3 ++-
> > >> meta/lib/oeqa/selftest/cases/package.py | 7 +++++--
> > >> meta/lib/oeqa/selftest/cases/runtime_test.py | 3 ++-
> > >> meta/lib/oeqa/utils/testexport.py | 6 +++++-
> > >> .../texinfo-dummy-native/texinfo-dummy/template.py | 4 +++-
> > >> scripts/combo-layer | 3 ++-
> > >> scripts/contrib/patchreview.py | 11 ++++++++---
> > >> scripts/lnr | 3 ++-
> > >> scripts/oe-pkgdata-browser | 5 ++++-
> > >> .../pybootchartgui/tests/parser_test.py | 7 ++++++-
> > >> scripts/send-error-report | 3 ++-
> > >> scripts/verify-bashisms | 9 +++++++--
> > >> 20 files changed, 75 insertions(+), 26 deletions(-)
> > >>
> > >> diff --git a/meta/lib/oe/package.py
> <https://urldefense.com/v3/__http://package.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6Xt2kV5g$>
> b/meta/lib/oe/package.py
> <https://urldefense.com/v3/__http://package.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6Xt2kV5g$>
> > >> index dd700cbb0c..fc5408d5f8 100644
> > >> --- a/meta/lib/oe/package.py
> <https://urldefense.com/v3/__http://package.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6Xt2kV5g$>
> > >> +++ b/meta/lib/oe/package.py
> <https://urldefense.com/v3/__http://package.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6Xt2kV5g$>
> > >> @@ -107,7 +107,10 @@ def strip_execs(pn, dstdir, strip_cmd,
> libdir, base_libdir, d, qa_already_stripp
> > >> :param qa_already_stripped: Set to True if
> already-stripped' in ${INSANE_SKIP}
> > >> This is for proper logging and messages only.
> > >> """
> > >> - import stat, errno, oe.path, oe.utils
> > >> + import stat
> > >> + import errno
> > >> + import oe.path
> > >> + import oe.utils
> > >>
> > >> elffiles = {}
> > >> inodes = {}
> > >> @@ -187,7 +190,9 @@ def file_translate(file):
> > >> return ft
> > >>
> > >> def filedeprunner(arg):
> > >> - import re, subprocess, shlex
> > >> + import re
> > >> + import subprocess
> > >> + import shlex
> > >>
> > >> (pkg, pkgfiles, rpmdeps, pkgdest) = arg
> > >> provides = {}
> > >> diff --git a/meta/lib/oe/qa.py
> <https://urldefense.com/v3/__http://qa.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6YqI4STw$>
> b/meta/lib/oe/qa.py
> <https://urldefense.com/v3/__http://qa.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6YqI4STw$>
> > >> index e8a854a302..38c2e0cc1c 100644
> > >> --- a/meta/lib/oe/qa.py
> <https://urldefense.com/v3/__http://qa.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6YqI4STw$>
> > >> +++ b/meta/lib/oe/qa.py
> <https://urldefense.com/v3/__http://qa.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6YqI4STw$>
> > >> @@ -2,7 +2,9 @@
> > >> # SPDX-License-Identifier: GPL-2.0-only
> > >> #
> > >>
> > >> -import os, struct, mmap
> > >> +import os
> > >> +import struct
> > >> +import mmap
> > >>
> > >> class NotELFFileError(Exception):
> > >> pass
> > >> diff --git a/meta/lib/oe/utils.py
> <https://urldefense.com/v3/__http://utils.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6STLfBVA$>
> b/meta/lib/oe/utils.py
> <https://urldefense.com/v3/__http://utils.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6STLfBVA$>
> > >> index a84039f585..789bad33f6 100644
> > >> --- a/meta/lib/oe/utils.py
> <https://urldefense.com/v3/__http://utils.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6STLfBVA$>
> > >> +++ b/meta/lib/oe/utils.py
> <https://urldefense.com/v3/__http://utils.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6STLfBVA$>
> > >> @@ -376,7 +376,8 @@ def format_pkg_list(pkg_dict,
> ret_format=None):
> > >> # Helper function to get the host compiler version
> > >> # Do not assume the compiler is gcc
> > >> def get_host_compiler_version(d, taskcontextonly=False):
> > >> - import re, subprocess
> > >> + import re
> > >> + import subprocess
> > >>
> > >> if taskcontextonly and d.getVar('BB_WORKERCONTEXT') != '1':
> > >> return
> > >> @@ -404,7 +405,8 @@ def get_host_compiler_version(d,
> taskcontextonly=False):
> > >>
> > >>
> > >> def host_gcc_version(d, taskcontextonly=False):
> > >> - import re, subprocess
> > >> + import re
> > >> + import subprocess
> > >>
> > >> if taskcontextonly and d.getVar('BB_WORKERCONTEXT') != '1':
> > >> return
> > >> diff --git a/meta/lib/oeqa/oetest.py
> <https://urldefense.com/v3/__http://oetest.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6scn-4-A$>
> b/meta/lib/oeqa/oetest.py
> <https://urldefense.com/v3/__http://oetest.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6scn-4-A$>
> > >> index 9c84466dd0..3136ac2ce5 100644
> > >> --- a/meta/lib/oeqa/oetest.py
> <https://urldefense.com/v3/__http://oetest.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6scn-4-A$>
> > >> +++ b/meta/lib/oeqa/oetest.py
> <https://urldefense.com/v3/__http://oetest.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6scn-4-A$>
> > >> @@ -9,7 +9,9 @@
> > >>
> > >> # It also has some helper functions and it's responsible for
> actually starting the tests
> > >>
> > >> -import os, re, sys
> > >> +import os
> > >> +import re
> > >> +import sys
> > >> import unittest
> > >> import inspect
> > >> import subprocess
> > >> diff --git a/meta/lib/oeqa/sdk/case.py
> <https://urldefense.com/v3/__http://case.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7BrLqZVA$>
> b/meta/lib/oeqa/sdk/case.py
> <https://urldefense.com/v3/__http://case.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7BrLqZVA$>
> > >> index c45882689c..86ac199197 100644
> > >> --- a/meta/lib/oeqa/sdk/case.py
> <https://urldefense.com/v3/__http://case.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7BrLqZVA$>
> > >> +++ b/meta/lib/oeqa/sdk/case.py
> <https://urldefense.com/v3/__http://case.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7BrLqZVA$>
> > >> @@ -35,7 +35,8 @@ class OESDKTestCase(OETestCase):
> > >> OS/architecture, or if not specified the currently
> configured MACHINE's
> > >> OS/architecture.
> > >> """
> > >> - import oe.qa
> <https://urldefense.com/v3/__http://oe.qa__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7-ldEI_g$>,
> oe.elf
> > >> + import oe.qa
> <https://urldefense.com/v3/__http://oe.qa__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7-ldEI_g$>
> > >> + import oe.elf
> > >>
> > >> if not target_os or not target_arch:
> > >> output = self._run("echo
> $OECORE_TARGET_OS:$OECORE_TARGET_ARCH")
> > >> diff --git a/meta/lib/oeqa/sdk/cases/buildlzip.py
> <https://urldefense.com/v3/__http://buildlzip.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5l5mkGMQ$>
> b/meta/lib/oeqa/sdk/cases/buildlzip.py
> <https://urldefense.com/v3/__http://buildlzip.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5l5mkGMQ$>
> > >> index 49ae756bf3..04c4a0ec16 100644
> > >> --- a/meta/lib/oeqa/sdk/cases/buildlzip.py
> <https://urldefense.com/v3/__http://buildlzip.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5l5mkGMQ$>
> > >> +++ b/meta/lib/oeqa/sdk/cases/buildlzip.py
> <https://urldefense.com/v3/__http://buildlzip.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5l5mkGMQ$>
> > >> @@ -2,7 +2,10 @@
> > >> # SPDX-License-Identifier: MIT
> > >> #
> > >>
> > >> -import os, tempfile, subprocess, unittest
> > >> +import os
> > >> +import tempfile
> > >> +import subprocess
> > >> +import unittest
> > >> from oeqa.sdk.case
> <https://urldefense.com/v3/__http://oeqa.sdk.case__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5Gb-vXpQ$>
> import OESDKTestCase
> > >> from oeqa.utils.subprocesstweak import errors_have_output
> > >> errors_have_output()
> > >> diff --git a/meta/lib/oeqa/sdk/cases/python.py
> <https://urldefense.com/v3/__http://python.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy537RZTpg$>
> b/meta/lib/oeqa/sdk/cases/python.py
> <https://urldefense.com/v3/__http://python.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy537RZTpg$>
> > >> index a334abce5f..2848481f33 100644
> > >> --- a/meta/lib/oeqa/sdk/cases/python.py
> <https://urldefense.com/v3/__http://python.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy537RZTpg$>
> > >> +++ b/meta/lib/oeqa/sdk/cases/python.py
> <https://urldefense.com/v3/__http://python.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy537RZTpg$>
> > >> @@ -2,7 +2,8 @@
> > >> # SPDX-License-Identifier: MIT
> > >> #
> > >>
> > >> -import subprocess, unittest
> > >> +import subprocess
> > >> +import unittest
> > >> from oeqa.sdk.case
> <https://urldefense.com/v3/__http://oeqa.sdk.case__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5Gb-vXpQ$>
> import OESDKTestCase
> > >>
> > >> from oeqa.utils.subprocesstweak import errors_have_output
> > >> diff --git a/meta/lib/oeqa/sdk/testsdk.py
> <https://urldefense.com/v3/__http://testsdk.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5SgZYgvA$>
> b/meta/lib/oeqa/sdk/testsdk.py
> <https://urldefense.com/v3/__http://testsdk.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5SgZYgvA$>
> > >> index 35e40187bc..18e03cb8ef 100644
> > >> --- a/meta/lib/oeqa/sdk/testsdk.py
> <https://urldefense.com/v3/__http://testsdk.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5SgZYgvA$>
> > >> +++ b/meta/lib/oeqa/sdk/testsdk.py
> <https://urldefense.com/v3/__http://testsdk.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5SgZYgvA$>
> > >> @@ -95,7 +95,8 @@ class TestSDK(TestSDKBase):
> > >> processes = d.getVar("TESTIMAGE_NUMBER_THREADS") or
> d.getVar("BB_NUMBER_THREADS")
> > >> if processes:
> > >> try:
> > >> - import testtools, subunit
> > >> + import testtools
> > >> + import subunit
> > >> except ImportError:
> > >> bb.warn("Failed to import testtools or
> subunit, the testcases will run serially")
> > >> processes = None
> > >> diff --git a/meta/lib/oeqa/selftest/cases/oelib/path.py
> <https://urldefense.com/v3/__http://path.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5tKYWegg$>
> b/meta/lib/oeqa/selftest/cases/oelib/path.py
> <https://urldefense.com/v3/__http://path.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5tKYWegg$>
> > >> index a1cfa08c09..098734fa5d 100644
> > >> --- a/meta/lib/oeqa/selftest/cases/oelib/path.py
> <https://urldefense.com/v3/__http://path.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5tKYWegg$>
> > >> +++ b/meta/lib/oeqa/selftest/cases/oelib/path.py
> <https://urldefense.com/v3/__http://path.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5tKYWegg$>
> > >> @@ -3,7 +3,8 @@
> > >> #
> > >>
> > >> from unittest.case
> <https://urldefense.com/v3/__http://unittest.case__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5hDRSoKA$>
> import TestCase
> > >> -import oe, oe.path
> > >> +import oe
> > >> +import oe.path
> > >> import tempfile
> > >> import os
> > >> import errno
> > >> diff --git a/meta/lib/oeqa/selftest/cases/package.py
> <https://urldefense.com/v3/__http://package.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6Xt2kV5g$>
> b/meta/lib/oeqa/selftest/cases/package.py
> <https://urldefense.com/v3/__http://package.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6Xt2kV5g$>
> > >> index 7166c3991f..82aa1bde1c 100644
> > >> --- a/meta/lib/oeqa/selftest/cases/package.py
> <https://urldefense.com/v3/__http://package.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6Xt2kV5g$>
> > >> +++ b/meta/lib/oeqa/selftest/cases/package.py
> <https://urldefense.com/v3/__http://package.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6Xt2kV5g$>
> > >> @@ -5,7 +5,8 @@
> > >> from oeqa.selftest.case
> <https://urldefense.com/v3/__http://oeqa.selftest.case__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7DFFrF-g$>
> import OESelftestTestCase
> > >> from oeqa.utils.commands import bitbake, get_bb_vars,
> get_bb_var, runqemu
> > >> import stat
> > >> -import subprocess, os
> > >> +import subprocess
> > >> +import os
> > >> import oe.path
> > >> import re
> > >>
> > >> @@ -150,7 +151,9 @@ class PackageTests(OESelftestTestCase):
> > >> self.fail('GDB %s failed' % binary)
> > >>
> > >> def test_preserve_ownership(self):
> > >> - import os, stat, oe.cachedpath
> > >> + import os
> > >> + import stat
> > >> + import oe.cachedpath
> > >> features = 'IMAGE_INSTALL_append = " selftest-chown"\n'
> > >> self.write_config(features)
> > >> bitbake("core-image-minimal")
> > >> diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py
> <https://urldefense.com/v3/__http://runtime_test.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7K5nXSVA$>
> b/meta/lib/oeqa/selftest/cases/runtime_test.py
> <https://urldefense.com/v3/__http://runtime_test.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7K5nXSVA$>
> > >> index d0c2440722..54a80dfdc0 100644
> > >> --- a/meta/lib/oeqa/selftest/cases/runtime_test.py
> <https://urldefense.com/v3/__http://runtime_test.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7K5nXSVA$>
> > >> +++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
> <https://urldefense.com/v3/__http://runtime_test.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy7K5nXSVA$>
> > >> @@ -211,7 +211,8 @@ class TestImage(OESelftestTestCase):
> > >> Product: oe-core
> > >> Author: Alexander Kanavin <alex.kanavin@gmail.com
> <mailto:alex.kanavin@gmail.com>>
> > >> """
> > >> - import subprocess, os
> > >> + import subprocess
> > >> + import os
> > >> try:
> > >> content = os.listdir("/dev/dri")
> > >> if len([i for i in content if
> i.startswith('render')]) == 0:
> > >> diff --git a/meta/lib/oeqa/utils/testexport.py
> <https://urldefense.com/v3/__http://testexport.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy44sHiuPg$>
> b/meta/lib/oeqa/utils/testexport.py
> <https://urldefense.com/v3/__http://testexport.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy44sHiuPg$>
> > >> index e89d130a9c..383e57a6b2 100644
> > >> --- a/meta/lib/oeqa/utils/testexport.py
> <https://urldefense.com/v3/__http://testexport.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy44sHiuPg$>
> > >> +++ b/meta/lib/oeqa/utils/testexport.py
> <https://urldefense.com/v3/__http://testexport.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy44sHiuPg$>
> > >> @@ -6,7 +6,11 @@
> > >>
> > >> # Provides functions to help with exporting binaries
> obtained from built targets
> > >>
> > >> -import os, re, glob as g, shutil as sh,sys
> > >> +import os
> > >> +import re
> > >> +import glob as g
> > >> +import shutil as sh
> > >> +import sys
> > >> from time import sleep
> > >> from .commands import runCmd
> > >> from difflib import SequenceMatcher as SM
> > >> diff --git
> a/meta/recipes-extended/texinfo-dummy-native/texinfo-dummy/template.py
> <https://urldefense.com/v3/__http://template.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy46Kyz-6A$>
> b/meta/recipes-extended/texinfo-dummy-native/texinfo-dummy/template.py
> <https://urldefense.com/v3/__http://template.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy46Kyz-6A$>
> > >> index 86c7c1811a..75c01b83bf 100644
> > >> ---
> a/meta/recipes-extended/texinfo-dummy-native/texinfo-dummy/template.py
> <https://urldefense.com/v3/__http://template.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy46Kyz-6A$>
> > >> +++
> b/meta/recipes-extended/texinfo-dummy-native/texinfo-dummy/template.py
> <https://urldefense.com/v3/__http://template.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy46Kyz-6A$>
> > >> @@ -28,7 +28,9 @@
> > >> # of the executable from argv[0] and emulate the
> corresponding program, so
> > >> # multiple copies of this script will exist under different
> names.
> > >>
> > >> -import sys, os, argparse
> > >> +import sys
> > >> +import os
> > >> +import argparse
> > >>
> > >>
> > >> this_binary = sys.argv[0].split("/")[-1]
> > >> diff --git a/scripts/combo-layer b/scripts/combo-layer
> > >> index 045de65642..835a6bcd09 100755
> > >> --- a/scripts/combo-layer
> > >> +++ b/scripts/combo-layer
> > >> @@ -11,7 +11,8 @@
> > >> #
> > >>
> > >> import fnmatch
> > >> -import os, sys
> > >> +import os
> > >> +import sys
> > >> import optparse
> > >> import logging
> > >> import subprocess
> > >> diff --git a/scripts/contrib/patchreview.py
> <https://urldefense.com/v3/__http://patchreview.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5Nhshvrg$>
> b/scripts/contrib/patchreview.py
> <https://urldefense.com/v3/__http://patchreview.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5Nhshvrg$>
> > >> index 62c509f51c..744dcfb49e 100755
> > >> --- a/scripts/contrib/patchreview.py
> <https://urldefense.com/v3/__http://patchreview.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5Nhshvrg$>
> > >> +++ b/scripts/contrib/patchreview.py
> <https://urldefense.com/v3/__http://patchreview.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy5Nhshvrg$>
> > >> @@ -40,7 +40,8 @@ def blame_patch(patch):
> > >> "--",
> patch)).decode("utf-8").splitlines()
> > >>
> > >> def patchreview(path, patches):
> > >> - import re, os.path
> > >> + import re
> > >> + import os.path
> > >>
> > >> # General pattern: start of line, optional whitespace,
> tag with optional
> > >> # hyphen or spaces, maybe a colon, some whitespace, then
> the value, all case
> > >> @@ -198,7 +199,9 @@ def histogram(results):
> > >>
> > >>
> > >> if __name__ == "__main__":
> > >> - import argparse, subprocess, os
> > >> + import argparse
> > >> + import subprocess
> > >> + import os
> > >>
> > >> args = argparse.ArgumentParser(description="Patch Review
> Tool")
> > >> args.add_argument("-b", "--blame", action="store_true",
> help="show blame for malformed patches")
> > >> @@ -213,7 +216,9 @@ if __name__ == "__main__":
> > >> analyse(results, want_blame=args.blame,
> verbose=args.verbose)
> > >>
> > >> if args.json:
> > >> - import json, os.path, collections
> > >> + import json
> > >> + import os.path
> > >> + import collections
> > >> if os.path.isfile(args.json):
> > >> data = json.load(open(args.json))
> > >> else:
> > >> diff --git a/scripts/lnr b/scripts/lnr
> > >> index a2ac4fec0f..e223b1e0e6 100755
> > >> --- a/scripts/lnr
> > >> +++ b/scripts/lnr
> > >> @@ -6,7 +6,8 @@
> > >> # Create a *relative* symlink, just like ln --relative does
> but without needing
> > >> # coreutils 8.16.
> > >>
> > >> -import sys, os
> > >> +import sys
> > >> +import os
> > >>
> > >> if len(sys.argv) != 3:
> > >> print("$ lnr TARGET LINK_NAME")
> > >> diff --git a/scripts/oe-pkgdata-browser
> b/scripts/oe-pkgdata-browser
> > >> index 8d223185a4..5834f59845 100755
> > >> --- a/scripts/oe-pkgdata-browser
> > >> +++ b/scripts/oe-pkgdata-browser
> > >> @@ -1,6 +1,9 @@
> > >> #! /usr/bin/env python3
> > >>
> > >> -import os, sys, enum, ast
> > >> +import os
> > >> +import sys
> > >> +import enum
> > >> +import ast
> > >>
> > >> scripts_path = os.path.dirname(os.path.realpath(__file__))
> > >> lib_path = scripts_path + '/lib'
> > >> diff --git
> a/scripts/pybootchartgui/pybootchartgui/tests/parser_test.py
> <https://urldefense.com/v3/__http://parser_test.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6G5tNwpg$>
> b/scripts/pybootchartgui/pybootchartgui/tests/parser_test.py
> <https://urldefense.com/v3/__http://parser_test.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6G5tNwpg$>
> > >> index 00fb3bf797..c005cf341f 100644
> > >> ---
> a/scripts/pybootchartgui/pybootchartgui/tests/parser_test.py
> <https://urldefense.com/v3/__http://parser_test.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6G5tNwpg$>
> > >> +++
> b/scripts/pybootchartgui/pybootchartgui/tests/parser_test.py
> <https://urldefense.com/v3/__http://parser_test.py__;%21%21AjveYdw8EvQ%21PBX2J1bie151wgwFSbZUcI0qMyKeL9qCOvFK7-S2MSM0PswWdDWS-j40Sy6G5tNwpg$>
> > >> @@ -1,4 +1,9 @@
> > >> -import sys, os, re, struct, operator, math
> > >> +import sys
> > >> +import os
> > >> +import re
> > >> +import struct
> > >> +import operator
> > >> +import math
> > >> from collections import defaultdict
> > >> import unittest
> > >>
> > >> diff --git a/scripts/send-error-report
> b/scripts/send-error-report
> > >> index cfbcaa52cb..ffa0a199b1 100755
> > >> --- a/scripts/send-error-report
> > >> +++ b/scripts/send-error-report
> > >> @@ -10,7 +10,8 @@
> > >> # SPDX-License-Identifier: GPL-2.0-only
> > >> #
> > >>
> > >> -import urllib.request, urllib.error
> > >> +import urllib.request
> > >> +import urllib.error
> > >> import sys
> > >> import json
> > >> import os
> > >> diff --git a/scripts/verify-bashisms b/scripts/verify-bashisms
> > >> index 14d8c298e9..a63f6c8115 100755
> > >> --- a/scripts/verify-bashisms
> > >> +++ b/scripts/verify-bashisms
> > >> @@ -3,7 +3,11 @@
> > >> # SPDX-License-Identifier: GPL-2.0-only
> > >> #
> > >>
> > >> -import sys, os, subprocess, re, shutil
> > >> +import sys
> > >> +import os
> > >> +import subprocess
> > >> +import re
> > >> +import shutil
> > >>
> > >> whitelist = (
> > >> # type is supported by dash
> > >> @@ -92,7 +96,8 @@ def get_tinfoil():
> > >> return tinfoil
> > >>
> > >> if __name__=='__main__':
> > >> - import argparse, shutil
> > >> + import argparse
> > >> + import shutil
> > >>
> > >> parser = argparse.ArgumentParser(description='Bashim
> detector for shell fragments in recipes.')
> > >> parser.add_argument("recipes", metavar="RECIPE",
> nargs="*", help="recipes to check (if not specified, all will be
> checked)")
> > >> --
> > >> 2.32.0
> > >>
> > >>
> > >>
> > >>
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 49005 bytes --]
prev parent reply other threads:[~2021-06-29 2:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 5:59 [PATCH 1/8] PEP8 double aggressive E401 Khem Raj
2021-06-28 5:59 ` [PATCH 2/8] PEP8 double aggressive E701, E70 and E502 Khem Raj
2021-06-28 5:59 ` [PATCH 3/8] PEP8 double aggressive E251 and E252 Khem Raj
2021-06-28 5:59 ` [PATCH 4/8] PEP8 double aggressive E20 and E211 Khem Raj
2021-06-28 5:59 ` [PATCH 5/8] PEP8 double aggressive E22, E224, E241, E242 and E27 Khem Raj
2021-06-28 5:59 ` [PATCH 6/8] PEP8 double aggressive E225 ~ E228 and E231 Khem Raj
2021-06-28 5:59 ` [PATCH 7/8] PEP8 double aggressive E301 ~ E306 Khem Raj
2021-06-28 5:59 ` [PATCH 8/8] PEP8 double aggressive W291 ~ W293 and W391 Khem Raj
2021-06-28 6:12 ` [OE-core] [PATCH 1/8] PEP8 double aggressive E401 Alexander Kanavin
2021-06-28 6:16 ` Khem Raj
2021-06-28 6:20 ` Alexander Kanavin
[not found] ` <1709447933.2675529.1624908347132@mail.yahoo.com>
2021-06-28 19:41 ` Khem Raj
2021-06-28 19:47 ` Alexander Kanavin
2021-06-28 21:08 ` Khem Raj
2021-06-28 21:14 ` Richard Purdie
2021-06-29 2:26 ` Chen Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1869df62-d92a-e50f-f185-63a9e436e4b8@windriver.com \
--to=qi.chen@windriver.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=persianpros@yahoo.com \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.