From: Jeff Layton <jlayton@kernel.org>
To: "Yan, Zheng" <zyan@redhat.com>, ceph-devel@vger.kernel.org
Cc: Ilya Dryomov <idryomov@gmail.com>,
Patrick Donnelly <pdonnell@redhat.com>
Subject: Re: [PATCH v3 0/6] ceph: don't request caps for idle open files
Date: Mon, 02 Mar 2020 14:53:50 -0500 [thread overview]
Message-ID: <186bfc2278dbdd4eac21f6ce03108c53e3f574b3.camel@kernel.org> (raw)
In-Reply-To: <20200228115550.6904-1-zyan@redhat.com>
On Fri, 2020-02-28 at 19:55 +0800, Yan, Zheng wrote:
> This series make cephfs client not request caps for open files that
> idle for a long time. For the case that one active client and multiple
> standby clients open the same file, this increase the possibility that
> mds issues exclusive caps to the active client.
>
> Yan, Zheng (4):
> ceph: always renew caps if mds_wanted is insufficient
> ceph: consider inode's last read/write when calculating wanted caps
> ceph: simplify calling of ceph_get_fmode()
> ceph: remove delay check logic from ceph_check_caps()
>
> fs/ceph/caps.c | 324 +++++++++++++++--------------------
> fs/ceph/file.c | 39 ++---
> fs/ceph/inode.c | 19 +-
> fs/ceph/ioctl.c | 2 +
> fs/ceph/mds_client.c | 5 -
> fs/ceph/super.h | 35 ++--
> include/linux/ceph/ceph_fs.h | 1 +
> 7 files changed, 188 insertions(+), 237 deletions(-)
>
> changes since v2
> - make __ceph_caps_file_wanted more readable
> - add patch 5 and 6, which fix hung write during testing patch 1~4
>
This patch series causes some serious slowdown in the async dirops
patches that I've not yet fully tracked down, and I suspect that they
may also be the culprit in these bugs:
https://tracker.ceph.com/issues/44381
https://tracker.ceph.com/issues/44382
I'm going to drop this series from the testing branch for now, until we
can track down the issue.
Thanks,
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2020-03-02 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 11:55 [PATCH v3 0/6] ceph: don't request caps for idle open files Yan, Zheng
2020-02-28 11:55 ` [PATCH v3 1/6] ceph: always renew caps if mds_wanted is insufficient Yan, Zheng
2020-02-28 11:55 ` [PATCH v3 2/6] ceph: consider inode's last read/write when calculating wanted caps Yan, Zheng
2020-02-28 11:55 ` [PATCH v3 3/6] ceph: simplify calling of ceph_get_fmode() Yan, Zheng
2020-02-28 11:55 ` [PATCH v3 4/6] ceph: remove delay check logic from ceph_check_caps() Yan, Zheng
2020-02-28 11:55 ` [PATCH v3 5/6] ceph: update i_requested_max_size only when sending cap msg to auth mds Yan, Zheng
2020-02-28 11:55 ` [PATCH v3 6/6] ceph: check all mds' caps after page writeback Yan, Zheng
2020-02-28 13:01 ` [PATCH v3 0/6] ceph: don't request caps for idle open files Jeff Layton
2020-03-02 19:53 ` Jeff Layton [this message]
2020-03-03 16:23 ` Yan, Zheng
2020-03-03 20:17 ` Jeff Layton
2020-03-04 13:41 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=186bfc2278dbdd4eac21f6ce03108c53e3f574b3.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=pdonnell@redhat.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.