From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3E6AC07E9B for ; Tue, 20 Jul 2021 20:39:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D36761004 for ; Tue, 20 Jul 2021 20:39:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D36761004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5wWx-0007oR-GC for qemu-devel@archiver.kernel.org; Tue, 20 Jul 2021 16:39:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5wVY-0006py-R0 for qemu-devel@nongnu.org; Tue, 20 Jul 2021 16:38:28 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:35608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5wVV-0002ae-IA for qemu-devel@nongnu.org; Tue, 20 Jul 2021 16:38:28 -0400 Received: by mail-pj1-x102a.google.com with SMTP id gp5-20020a17090adf05b0290175c085e7a5so2716507pjb.0 for ; Tue, 20 Jul 2021 13:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qQDH1TwbwFpDAan4WCon3mK25gvuL+uwEXizo+Xn4Cw=; b=MXX4tao1GmdSkBt+gRyyxoq0nL37AG8mmJix+etmHFMr/zEhrjMDqmunhXEZtgVH07 R+TBE8JXmKn4HRTKjxsyqTeeR2p1ojXXIeJqBFbS84oe/zTuY35P2a7MAXEp+XMGfTi0 SuMP25nNRwGPNGuDGyrsx2FUWdI+F+bAUB8dKSsr9yB6YayCRr3QGGiKMriA14eeZp65 IgCcmNoXMRNt73wDM+HpYBEWV/mjsGcrgfx1mWYt5JcCu6ZROy5bfLhPwFrgPF+9Nfy1 bb8W12ag+RsNd1pqIBCWFDDHJMg7lyMT2Sy+8vxVj3CVw6nbcnnpR7WXxSGVGWkWc0Dl Cjgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qQDH1TwbwFpDAan4WCon3mK25gvuL+uwEXizo+Xn4Cw=; b=NuYesmMwvRR/i+dy5t7gi2SOdTjlHDEg/ds+S2+d7yK7l9FJy9Tn9V09huPZLqASpQ Yv7CWqZGFt3nKG/RBH5UnnQkLDoGPgFoZ5xW6fJSEwuih6k5f8VohL0PwGyRoTDqA/O2 07XqHNeucSIn2mR/u7amTekGf3HxM8U0Gt7vXwQLw7YX0c6XFMQBBtXmOBauWZCht/Jn 60CsbWtXHWaNrkq3T90At8kgrEMw5/oqtzG2TzpaLum+Sj71CBZqQWlHWHLWhbSyBuzs gt9tvhxT3CLryZKW2TzKcpTrbSTYSfOmnIQdj/xbgM55sn+43PhQQJTZVVFsdD/oVrhW iI8g== X-Gm-Message-State: AOAM533QHOsdYy89O4OEgjjjfRwl2TSsokIfCIEuZJJIDBecwQTuE7EH 5jnRXv3CaUNAIQWNXlML8nhrpw== X-Google-Smtp-Source: ABdhPJxNQh7P5VbkTgz8xsFvzxrCBsDf78SQZ6htDbkjEwm238cYykPM5SYkxLcEV8Ey9SVmR+xhjA== X-Received: by 2002:a17:90a:6782:: with SMTP id o2mr202295pjj.165.1626813503370; Tue, 20 Jul 2021 13:38:23 -0700 (PDT) Received: from [192.168.3.43] (204-210-126-223.res.spectrum.com. [204.210.126.223]) by smtp.gmail.com with ESMTPSA id j6sm27252264pgq.0.2021.07.20.13.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jul 2021 13:38:22 -0700 (PDT) Subject: Re: [PATCH v3 01/10] qemu/atomic: Use macros for CONFIG_ATOMIC64 To: Peter Maydell References: <20210717192419.2066778-1-richard.henderson@linaro.org> <20210717192419.2066778-2-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <186fdeab-65b6-926c-70fc-d60cfc71ec3c@linaro.org> Date: Tue, 20 Jul 2021 10:38:19 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , QEMU Developers , Cole Robinson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/19/21 2:01 AM, Peter Maydell wrote: >> -static inline void qatomic_set_u64(uint64_t *ptr, uint64_t val) >> -{ >> - qatomic_set__nocheck(ptr, val); >> -} ... >> +#define qatomic_set_u64 qatomic_set__nocheck > > Previously if you tried to do qatomic_set_i64() etc on something > that wasn't an int64_t*, the compiler would complain. Now it will > silently store a different-sized value, I think. Is there a way > to retain the typechecking in the macro versions? I can add a trivial _Generic wrapper. r~