All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: linux-leds@vger.kernel.org,
	"David Rivshin (Allworx)" <drivshin.allworx@gmail.com>,
	devicetree@vger.kernel.org
Cc: Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with IS31FL32XX driver
Date: Fri, 4 Mar 2016 22:14:27 +0100 (CET)	[thread overview]
Message-ID: <1872003451.86198.4bb16da4-d4d8-48af-950a-7442cddf2b4d.open-xchange@email.1und1.de> (raw)
In-Reply-To: <1456974095-1867-5-git-send-email-drivshin.allworx@gmail.com>

Hi David,

> "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> hat am 3. März 2016 um
> 04:01 geschrieben:
>
>
> From: David Rivshin <drivshin@allworx.com>
>
> Si-En Technology was acquired by ISSI in 2011, and it appears that
> the IS31FL3218/IS31FL3216 are just rebranded SN3218/SN3216 devices.
> As the IS31FL32XX driver already handles the *3218 devices, there
> is no longer a need for the dedicated SN3218 driver.
>
> Add the "sn,sn3218" and "sn,sn3216" compatible strings into the
> IS31FL32XX driver and binding documentation, and remove the
> leds-sn3218 driver.
>
> Datasheets:
> IS31FL3218: http://www.issi.com/WW/pdf/31FL3218.pdf
> SN3218: http://www.si-en.com/uploadpdf/s2011517171720.pdf
>
> IS31FL3216: http://www.issi.com/WW/pdf/31FL3216.pdf
> SN3216; http://www.si-en.com/uploadpdf/SN3216201152410148.pdf
>
> Signed-off-by: David Rivshin <drivshin@allworx.com>

i tested this patch successfully with a Raspberry Pi and a PiGlow (SN3218).

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

  parent reply	other threads:[~2016-03-04 21:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  3:01 [PATCH 0/4] leds: Add driver for the ISSI IS31FL32xx family of LED controllers David Rivshin (Allworx)
2016-03-03  3:01 ` David Rivshin (Allworx)
2016-03-03  3:01 ` [PATCH 1/4] DT: Add vendor prefix for Integrated Silicon Solutions Inc David Rivshin (Allworx)
2016-03-05  4:28   ` Rob Herring
2016-03-03  3:01 ` [PATCH 2/4] DT: leds: Add binding for the ISSI IS31FL32xx family of LED controllers David Rivshin (Allworx)
2016-03-05  4:28   ` Rob Herring
2016-03-03  3:01 ` [PATCH 3/4] leds: Add driver " David Rivshin (Allworx)
2016-03-03  3:21   ` kbuild test robot
2016-03-03 14:51   ` Jacek Anaszewski
2016-03-04  0:45     ` David Rivshin (Allworx)
     [not found]       ` <20160303194531.316d7918.drivshin.allworx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-04  7:54         ` Jacek Anaszewski
2016-03-04  7:54           ` Jacek Anaszewski
     [not found]           ` <56D93F1A.6030305-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-03-04 15:05             ` David Rivshin (Allworx)
2016-03-04 15:05               ` David Rivshin (Allworx)
2016-03-04 16:01               ` Jacek Anaszewski
2016-03-04 19:02                 ` David Rivshin (Allworx)
2016-03-04 21:39                   ` Jacek Anaszewski
2016-03-05  5:29                     ` David Rivshin (Allworx)
2016-03-05 11:37                       ` Jacek Anaszewski
2016-03-03 18:13   ` Stefan Wahren
2016-03-04 14:27     ` David Rivshin (Allworx)
2016-03-04 15:38       ` Jacek Anaszewski
2016-03-05  6:12         ` David Rivshin (Allworx)
2016-03-05 11:39           ` Jacek Anaszewski
2016-03-03  3:01 ` [PATCH 4/4] leds: Replace dedicated SN3218 driver with IS31FL32XX driver David Rivshin (Allworx)
2016-03-03 14:51   ` Jacek Anaszewski
2016-03-05  5:34     ` David Rivshin (Allworx)
2016-03-05 11:37       ` Jacek Anaszewski
2016-03-04 21:14   ` Stefan Wahren [this message]
2016-03-05  5:00     ` David Rivshin (Allworx)
2016-03-05  4:28   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1872003451.86198.4bb16da4-d4d8-48af-950a-7442cddf2b4d.open-xchange@email.1und1.de \
    --to=stefan.wahren@i2se.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drivshin.allworx@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=j.anaszewski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.