From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 1/2] tools: Add support for handling
	built-in kernel modules
Date: Tue, 26 Jan 2016 16:23:31 +0100
Message-ID: <1872674.ygjbT6ghrC@xps13>
References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
 <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: krytarowski@caviumnetworks.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id A204E9239
 for <dev@dpdk.org>; Tue, 26 Jan 2016 16:24:39 +0100 (CET)
Received: by mail-wm0-f45.google.com with SMTP id l65so108680636wmf.1
 for <dev@dpdk.org>; Tue, 26 Jan 2016 07:24:39 -0800 (PST)
In-Reply-To: <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-01-20 10:48, krytarowski@caviumnetworks.com:
> --- a/tools/dpdk_nic_bind.py
> +++ b/tools/dpdk_nic_bind.py
> -    for line in loaded_mods:
> +    try:
> +        # Get list of syfs modules, some of them might be builtin and merge with mods

Please could you explain this comment?
Is it remaining from previous versions of the patch?

[...]
> +        # special case for vfio_pci (module is named vfio-pci,
> +        # but its .ko is named vfio_pci)

Isn't it common to have dash replaced by underscore for kernel modules?