From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/2] version: switch to year/month version numbers Date: Wed, 10 Feb 2016 16:11:40 +0100 Message-ID: <1877379.9acYIlBRDX@xps13> References: <1450704384-9986-2-git-send-email-bruce.richardson@intel.com> <1455114792-1603-1-git-send-email-john.mcnamara@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: John McNamara Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 529A056A9 for ; Wed, 10 Feb 2016 16:13:06 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id p63so33167981wmp.1 for ; Wed, 10 Feb 2016 07:13:06 -0800 (PST) In-Reply-To: <1455114792-1603-1-git-send-email-john.mcnamara@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-10 14:33, John McNamara: > /** > * Major version number i.e. the x in x.y.z > */ > -#define RTE_VER_MAJOR 2 > +#define RTE_VER_MAJOR 16 > > /** > * Minor version number i.e. the y in x.y.z > */ > -#define RTE_VER_MINOR 3 > +#define RTE_VER_MINOR 4 > I liked the idea of Bruce of renaming these constants to *_YEAR and *_MONTH. I also think RTE_VER_PATCH_LEVEL should be RTE_VER_MINOR. And maybe that RTE_VER_PATCH_RELEASE should be RTE_VER_RELEASE. It shouldn't hurt applications as they must use RTE_VERSION and rte_version(). Opinions?