From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbdCBKtZ (ORCPT ); Thu, 2 Mar 2017 05:49:25 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:56843 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbdCBKtV (ORCPT ); Thu, 2 Mar 2017 05:49:21 -0500 From: Laurent Pinchart To: Roger Quadros Cc: balbi@kernel.org, petr.cvek@tul.cz, b-liu@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "# v4 . 9+" Subject: Re: [PATCH] Revert "usb: gadget: uvc: Add missing call for additional setup data" Date: Thu, 02 Mar 2017 12:49:34 +0200 Message-ID: <1884403.I0k68d3r5L@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.6-gentoo-r1; KDE/4.14.28; x86_64; ; ) In-Reply-To: <1488444298-10394-1-git-send-email-rogerq@ti.com> References: <1488444298-10394-1-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, Thank you for the patch. On Thursday 02 Mar 2017 10:44:58 Roger Quadros wrote: > This reverts commit 4fbac5206afd01b717d4bdc58793d471f3391b4b. > > This commit breaks g_webcam when used with uvc-gadget [1]. > > The user space application (e.g. uvc-gadget) is responsible for > sending response to UVC class specific requests on control endpoint > in uvc_send_response() in uvc_v4l2.c. > > The bad commit was causing a duplicate response to be sent with > incorrect response data thus causing UVC probe to fail at the host > and broken control transfer endpoint at the gadget. > > [1] - git://git.ideasonboard.org/uvc-gadget.git > > Cc: # v4.9+ > Signed-off-by: Roger Quadros Acked-by: Laurent Pinchart > --- > drivers/usb/gadget/function/f_uvc.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_uvc.c > b/drivers/usb/gadget/function/f_uvc.c index 27ed51b..29b41b5 100644 > --- a/drivers/usb/gadget/function/f_uvc.c > +++ b/drivers/usb/gadget/function/f_uvc.c > @@ -258,13 +258,6 @@ uvc_function_setup(struct usb_function *f, const struct > usb_ctrlrequest *ctrl) memcpy(&uvc_event->req, ctrl, > sizeof(uvc_event->req)); > v4l2_event_queue(&uvc->vdev, &v4l2_event); > > - /* Pass additional setup data to userspace */ > - if (uvc->event_setup_out && uvc->event_length) { > - uvc->control_req->length = uvc->event_length; > - return usb_ep_queue(uvc->func.config->cdev->gadget->ep0, > - uvc->control_req, GFP_ATOMIC); > - } > - > return 0; > } -- Regards, Laurent Pinchart