All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers
Date: Mon, 28 Jun 2021 14:31:29 -0700	[thread overview]
Message-ID: <188995a5-2612-2d4a-9956-3eb3467a5ff1@linaro.org> (raw)
In-Reply-To: <876235ff-c85c-9b6c-d1a7-a3fe3f602cc1@amsat.org>

On 6/28/21 9:33 AM, Philippe Mathieu-Daudé wrote:
>> I don't mind the ordering, just that there's a reason.
> 
> Is that OK if I reword as:
> 
> ---
> We want to extract the microMIPS ISA and Code Compaction ASE to
> new compilation units.
> 
> We will first extract this code as included source files (.c.inc),
> then make them new compilation units afterward.
> 
> The following methods are going to be used externally:
> 
>    micromips_translate.c.inc:1778:   gen_ldxs(ctx, rs, rt, rd);
>    micromips_translate.c.inc:1806:   gen_align(ctx, 32, rd, rs, ...
>    micromips_translate.c.inc:2859:   gen_addiupc(ctx, reg, offset, ...
>    mips16e_translate.c.inc:444:      gen_addiupc(ctx, ry, offset, ...
> 
> To avoid too much code churn, it is simpler to declare these
> prototypes in "translate.h" now.
> ---

Sure.


r~


  reply	other threads:[~2021-06-28 21:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 17:49 [PATCH 0/4] target/mips: Extract microMIPS ISA and Code Compaction ASE apart Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 1/4] target/mips: Add declarations for generic TCG helpers Philippe Mathieu-Daudé
2021-06-18 20:15   ` Richard Henderson
2021-06-19  9:26     ` Philippe Mathieu-Daudé
2021-06-19 12:41       ` Richard Henderson
2021-06-28 16:33         ` Philippe Mathieu-Daudé
2021-06-28 21:31           ` Richard Henderson [this message]
2021-06-17 17:49 ` [PATCH 2/4] target/mips: Extract Code Compaction ASE translation routines Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 3/4] target/mips: Extract the microMIPS ISA " Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 4/4] target/mips: Add declarations for generic DSP TCG helpers Philippe Mathieu-Daudé
2021-06-17 18:25   ` Philippe Mathieu-Daudé
2021-06-18 20:17   ` Richard Henderson
2021-06-29  4:35 ` [PATCH 0/4] target/mips: Extract microMIPS ISA and Code Compaction ASE apart Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=188995a5-2612-2d4a-9956-3eb3467a5ff1@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.