From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@suse.de>, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [RFC PATCH] mm, page_alloc: drop should_suppress_show_mem
Date: Fri, 7 Sep 2018 14:16:16 +0200 [thread overview]
Message-ID: <188ef8c6-262c-cead-6f78-ebda0978cce6@suse.cz> (raw)
In-Reply-To: <20180907114334.7088-1-mhocko@kernel.org>
On 09/07/2018 01:43 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> should_suppress_show_mem has been introduced to reduce the overhead of
> show_mem on large NUMA systems. Things have changed since then though.
> Namely c78e93630d15 ("mm: do not walk all of system memory during
> show_mem") has reduced the overhead considerably.
>
> Moreover warn_alloc_show_mem clears SHOW_MEM_FILTER_NODES when called
> from the IRQ context already so we are not printing per node stats.
>
> Remove should_suppress_show_mem because we are losing potentially
> interesting information about allocation failures. We have seen a bug
> report where system gets unresponsive under memory pressure and there
> is only
> kernel: [2032243.696888] qlge 0000:8b:00.1 ql1: Could not get a page chunk, i=8, clean_idx =200 .
> kernel: [2032243.710725] swapper/7: page allocation failure: order:1, mode:0x1084120(GFP_ATOMIC|__GFP_COLD|__GFP_COMP)
>
> without an additional information for debugging. It would be great to
> see the state of the page allocator at the moment.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
The dependency on build-time constant instead of real system size is
also unfortunate. Maybe the time was depending on *possible* nodes in
the past, but I don't think it's the case today.
Thanks.
prev parent reply other threads:[~2018-09-07 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 11:43 [RFC PATCH] mm, page_alloc: drop should_suppress_show_mem Michal Hocko
2018-09-07 11:43 ` Michal Hocko
2018-09-07 12:16 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188ef8c6-262c-cead-6f78-ebda0978cce6@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.