From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB565C433EF for ; Tue, 26 Apr 2022 11:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349589AbiDZLqT (ORCPT ); Tue, 26 Apr 2022 07:46:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346351AbiDZLqR (ORCPT ); Tue, 26 Apr 2022 07:46:17 -0400 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 749303BA57 for ; Tue, 26 Apr 2022 04:43:08 -0700 (PDT) Received: from epcas3p1.samsung.com (unknown [182.195.41.19]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20220426114303epoutp03e082a67b9f4f5d4382d59d6dd9a555dd~pb4tvrtPK2777227772epoutp03B for ; Tue, 26 Apr 2022 11:43:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20220426114303epoutp03e082a67b9f4f5d4382d59d6dd9a555dd~pb4tvrtPK2777227772epoutp03B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1650973383; bh=YE9iUr9/jWW+X/EahStx2IppwtG/JSA/KIYvvhie8vI=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=a4HfZnXByYJq5Y7TqW8ucRa9jsxs4tRbmUuJqaVzRXpGZadHb8UVzBQ3xUMKkemqb yl03YtJq9M0QvPC/18QT2Ls+SdSezXGznZOyPk2mfo/hQYy/Ust/kBBcpobzgdseqw 4af5eBxEQXhK2DAM7ySk+VACRMOGcgzNpXVB3u+0= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas3p1.samsung.com (KnoxPortal) with ESMTP id 20220426114302epcas3p132d41aac8d00da7937b2f717bbb21188~pb4tBgDT31614516145epcas3p1Z; Tue, 26 Apr 2022 11:43:02 +0000 (GMT) Received: from epcpadp4 (unknown [182.195.40.18]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4Kng460ycCz4x9Q3; Tue, 26 Apr 2022 11:43:02 +0000 (GMT) Mime-Version: 1.0 Subject: RE: [PATCH v3 6/6] scsi: ufshpb: Cleanup ufshpb_suspend/resume Reply-To: keosung.park@samsung.com Sender: Keoseong Park From: Keoseong Park To: Bean Huo , ALIM AKHTAR , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "stanley.chu@mediatek.com" , "beanhuo@micron.com" , "bvanassche@acm.org" , "tomas.winkler@intel.com" , Daejun Park , Keoseong Park , "peter.wang@mediatek.com" , "powen.kao@mediatek.com" , cpgsproxy3 CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <20220424220713.1253049-7-huobean@gmail.com> X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <1891546521.01650973382114.JavaMail.epsvc@epcpadp4> Date: Mon, 25 Apr 2022 11:25:19 +0900 X-CMS-MailID: 20220425022519epcms2p1fe1a24e91f1bd69dfe04f8fabb18bbf8 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL X-CPGSPASS: Y X-CPGSPASS: Y X-Hop-Count: 3 X-CMS-RootMailID: 20220424220758epcas2p398348a86cb11bced52451da2de09629d References: <20220424220713.1253049-7-huobean@gmail.com> <20220424220713.1253049-1-huobean@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >From: Bean Huo > >ufshpb_resume() is only called when the HPB state is HPB_SUSPEND, so >the check statement for "ufshpb_get_state(hpb) != HPB_PRESENT" is useless. > >Signed-off-by: Bean Huo Reviewed-by: Keoseong Park Best Regards, Keoseong Park >--- > drivers/scsi/ufs/ufshpb.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > >diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c >index 7868412054bf..10f40e390dc5 100644 >--- a/drivers/scsi/ufs/ufshpb.c >+++ b/drivers/scsi/ufs/ufshpb.c >@@ -2349,11 +2349,9 @@ void ufshpb_suspend(struct ufs_hba *hba) > > shost_for_each_device(sdev, hba->host) { > hpb = ufshpb_get_hpb_data(sdev); >- if (!hpb) >+ if (!hpb || ufshpb_get_state(hpb) != HPB_PRESENT) > continue; > >- if (ufshpb_get_state(hpb) != HPB_PRESENT) >- continue; > ufshpb_set_state(hpb, HPB_SUSPEND); > ufshpb_cancel_jobs(hpb); > } >@@ -2366,20 +2364,15 @@ void ufshpb_resume(struct ufs_hba *hba) > > shost_for_each_device(sdev, hba->host) { > hpb = ufshpb_get_hpb_data(sdev); >- if (!hpb) >+ if (!hpb || ufshpb_get_state(hpb) != HPB_SUSPEND) > continue; > >- if ((ufshpb_get_state(hpb) != HPB_PRESENT) && >- (ufshpb_get_state(hpb) != HPB_SUSPEND)) >- continue; > ufshpb_set_state(hpb, HPB_PRESENT); > ufshpb_kick_map_work(hpb); > if (hpb->is_hcm) { >- unsigned int poll = >- hpb->params.timeout_polling_interval_ms; >+ unsigned int poll = hpb->params.timeout_polling_interval_ms; > >- schedule_delayed_work(&hpb->ufshpb_read_to_work, >- msecs_to_jiffies(poll)); >+ schedule_delayed_work(&hpb->ufshpb_read_to_work, msecs_to_jiffies(poll)); > } > } > } >-- >2.34.1 > >