From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757849AbZDTVY1 (ORCPT ); Mon, 20 Apr 2009 17:24:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757749AbZDTVXs (ORCPT ); Mon, 20 Apr 2009 17:23:48 -0400 Received: from bilbo.ozlabs.org ([203.10.76.25]:56867 "EHLO bilbo.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757737AbZDTVXq (ORCPT ); Mon, 20 Apr 2009 17:23:46 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18924.59347.375292.102385@cargo.ozlabs.ibm.com> Date: Tue, 21 Apr 2009 07:23:31 +1000 From: Paul Mackerras To: Eric Dumazet Cc: Stephen Hemminger , paulmck@linux.vnet.ibm.com, Evgeniy Polyakov , David Miller , kaber@trash.net, torvalds@linux-foundation.org, jeff.chua.linux@gmail.com, mingo@elte.hu, laijs@cn.fujitsu.com, jengelh@medozas.de, r000n@r000n.net, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, benh@kernel.crashing.org, mathieu.desnoyers@polymtl.ca Subject: Re: [PATCH] netfilter: use per-cpu recursive lock (v10) In-Reply-To: <49ECBE0A.7010303@cosmosbay.com> References: <20090415170111.6e1ca264@nehalam> <49E72E83.50702@trash.net> <20090416.153354.170676392.davem@davemloft.net> <20090416234955.GL6924@linux.vnet.ibm.com> <20090417012812.GA25534@linux.vnet.ibm.com> <20090418094001.GA2369@ioremap.net> <20090418141455.GA7082@linux.vnet.ibm.com> <20090420103414.1b4c490f@nehalam> <49ECBE0A.7010303@cosmosbay.com> X-Mailer: VM 8.0.9 under Emacs 22.2.1 (i486-pc-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Dumazet writes: > OK, but we still have a problem on machines with >= 250 cpus, > because calling 250 times spin_lock() is going to overflow preempt_count, > as each spin_lock() increases preempt_count by one. Huh? Each cpu has its own separate preempt_count. Paul.