From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] cpufreq: cpufreq-cpu0: NULL is a valid regulator Date: Tue, 13 Aug 2013 15:09:40 +0200 Message-ID: <1893015.38vNDktfpT@vostro.rjw.lan> References: <1376071592-18930-1-git-send-email-broonie@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Viresh Kumar Cc: Mark Brown , cpufreq@vger.kernel.org, linaro-kernel@lists.linaro.org, Mark Brown On Monday, August 12, 2013 10:49:46 AM Viresh Kumar wrote: > On 9 August 2013 23:36, Mark Brown wrote: > > From: Mark Brown > > > > Since NULL could in theory be a valid regulator we ought to check for > > IS_ERR() rather than for NULL. In practice this is unlikely to be an > > issue but it's better for neatness. > > > > Signed-off-by: Mark Brown > > --- > > drivers/cpufreq/cpufreq-cpu0.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > Makes sense. > > Acked-by: Viresh Kumar Queued up for 3.12. Thanks, Rafael