From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device Date: Mon, 9 Jul 2012 22:40:14 -0700 (PDT) Message-ID: <189ede36e2bce393f6957b14dccf37d1.squirrel@www.codeaurora.org> References: <009701cd5d64$c7dc2aa0$57947fe0$%jun@samsung.com> <00c401cd5dbb$6d605630$48210290$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:44253 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752958Ab2GJFkO (ORCPT ); Tue, 10 Jul 2012 01:40:14 -0400 In-Reply-To: <00c401cd5dbb$6d605630$48210290$%jun@samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Seungwon Jeon Cc: merez@codeaurora.org, linux-mmc@vger.kernel.org, 'Chris Ball' , 'Subhash Jadavani' , "'S, Venkatraman'" , 'Saugata Das' , 'Namjae Jeon' On Mon, July 9, 2012 3:13 am, Seungwon Jeon wrote: > Monday, July 09, 2012, Maya wrote: >> On Sun, July 8, 2012 4:52 pm, Seungwon Jeon wrote: >> > Sunday, July 08, 2012, Maya wrote: >> >> One minor comment below: >> >> >> >> > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct >> mmc_queue >> >> *mq, struct request *rqc) >> >> > (card->ext_csd.data_sector_size == 4096)) { >> >> You can use mmc_large_sec here (instead of >> >> card->ext_csd.data_sector_size >> >> == 4096) >> > Yes, but this line is kept due to another issue related with 4KB >> sector. >> > >> > Thanks, >> > Seungwon Jeon >> Hi, >> >> I'm not sure I understand your reply. mmc_large_sec does exactly what >> the >> if here does. >> My suggestion is to replace the code with the new function you added. >> I agree it's an old code but this way the code will be consistent and >> mmc_large_sec will be used in every place we would like to check if the >> sector size is 4K. > I just remained. The code you pointed can be replaced. > Regardless this review, I'll rework. > eMMC 4.51 spec was updated in June and there is some changes. > Spec mentions packed header is 8 blocks in 4KB native device. > I'll apply this change. No need to apply the change. You are probably right and since it is not related to your change it can be done later on. > > Thanks, > Seungwon Jeon > >> >> Thanks, >> Maya >> >> -- >> Sent by consultant of Qualcomm Innovation Center, Inc. >> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Sent by consultant of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum