From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED492C3DA7D for ; Thu, 5 Jan 2023 14:20:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BAB2A855B2; Thu, 5 Jan 2023 15:20:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1672928425; bh=4RI6v/K3YmK0dOws3nShPl1fcHdlXPLyw9FAKPXK3dQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rxRU299uf93UvpA9ga98z/TFObW7DDn+FkX84tE4ybnuneAqDBhwDoo+a5px13g6h w0e/WzUR58iS1e2H9xquRofRFqFD7ozj+mBCEAQSIst/rKZRY6embsgSKu1/iOMowz x5YHTijUknWCVYw6A3dO4drMyhqbaTRJMcYPcBqGx9p7A7l7ktOo6sMOLXeHVwL3h1 cSeL6lGsbkTT3JSlbkLJKPxZArFy0L1xpmeWsRldVJLw8OyKEG14nhvCM6edK5RT54 CqqSZ+WrFNkbSQ56aFiRqYwVHAT8s5lxypsb3QhJOf+p+mwGLLRL/GpkAqycX9akAw jFg8uta1P/l8A== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6DED2855AF; Thu, 5 Jan 2023 15:20:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1672928423; bh=4RI6v/K3YmK0dOws3nShPl1fcHdlXPLyw9FAKPXK3dQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MGMfmK6Xeh22TeuLzMbFLUkKnuHPvy12wHlClHq7A5ApvvklDdASCkyrqCqm38G7t sqvG04mX61QZ9BVY+FhqMzhFOuxheL3XpAn4oBA2HfxUhLfGIt6XaAHmpj2Deqnwqz M/XnvhJ0dfL4j7K/tIdrMxmkue4Dp6lUINvkUM20PQkov7XlVGsorPvbNdxEih3SuX 4XurC63pAiHJtoP2+MtoP26Y5ha1qZts8FzjMd773Hc846XPaQOmeOlJ1foIcFJzzy baD917sue0Im6wE2DKJgn4ft+UCTvoeOFU3cqtXGnbKfbwcjPblgy+1KGK/wMfJHHy yDM8eG/Wc8JeQ== Message-ID: <189f8680-6702-7033-085d-5e4ddf45df58@denx.de> Date: Thu, 5 Jan 2023 15:20:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] cmd: mmc: Expand bkops handling Content-Language: en-US To: Simon Glass Cc: u-boot@lists.denx.de, Jaehoon Chung , Peng Fan References: <20221222051041.1276885-1-marex@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 12/22/22 18:47, Simon Glass wrote: [...] >> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c >> index 210703ea46b..afbc497b12c 100644 >> --- a/drivers/mmc/mmc.c >> +++ b/drivers/mmc/mmc.c >> @@ -3127,9 +3127,10 @@ int mmc_init_device(int num) >> #endif >> >> #ifdef CONFIG_CMD_BKOPS_ENABLE > > We shouldn't really need this #ifdef, since if it is not called it > won't be included in the binary. You would get "function defined but not used" maybe-unused warning. >> -int mmc_set_bkops_enable(struct mmc *mmc) >> +int mmc_set_bkops_enable(struct mmc *mmc, bool autobkops, bool enable) >> { >> int err; >> + u32 bit = autobkops ? BIT(1) : BIT(0); >> ALLOC_CACHE_ALIGN_BUFFER(u8, ext_csd, MMC_MAX_BLOCK_LEN); >> >> err = mmc_send_ext_csd(mmc, ext_csd); [...]