From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D25BAC43460 for ; Wed, 5 May 2021 07:11:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A313F613BA for ; Wed, 5 May 2021 07:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231388AbhEEHMg (ORCPT ); Wed, 5 May 2021 03:12:36 -0400 Received: from foss.arm.com ([217.140.110.172]:39364 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbhEEHMg (ORCPT ); Wed, 5 May 2021 03:12:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E94FD6E; Wed, 5 May 2021 00:11:39 -0700 (PDT) Received: from [10.163.78.57] (unknown [10.163.78.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EFB53F718; Wed, 5 May 2021 00:11:30 -0700 (PDT) Subject: Re: [PATCH V2] mm: Define default value for FIRST_USER_ADDRESS To: Stafford Horne Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Richard Henderson , Vineet Gupta , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , "James E.J. Bottomley" , Michael Ellerman , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Yoshinori Sato , "David S. Miller" , Jeff Dike , Thomas Gleixner , Chris Zankel , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <1618550254-14511-1-git-send-email-anshuman.khandual@arm.com> <20210505062731.GS3288043@lianli.shorne-pla.net> From: Anshuman Khandual Message-ID: <189feda7-5d1b-d3d3-3ae9-343987a433f0@arm.com> Date: Wed, 5 May 2021 12:42:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210505062731.GS3288043@lianli.shorne-pla.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/5/21 11:57 AM, Stafford Horne wrote: > On Fri, Apr 16, 2021 at 10:47:34AM +0530, Anshuman Khandual wrote: >> Currently most platforms define FIRST_USER_ADDRESS as 0UL duplication the >> same code all over. Instead just define a generic default value (i.e 0UL) >> for FIRST_USER_ADDRESS and let the platforms override when required. This >> makes it much cleaner with reduced code. >> >> The default FIRST_USER_ADDRESS here would be skipped in >> when the given platform overrides its value via . >> >> Cc: Richard Henderson >> Cc: Vineet Gupta >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Guo Ren >> Cc: Brian Cain >> Cc: Geert Uytterhoeven >> Cc: Michal Simek >> Cc: Thomas Bogendoerfer >> Cc: Ley Foon Tan >> Cc: Jonas Bonn >> Cc: Stefan Kristiansson >> Cc: Stafford Horne >> Cc: "James E.J. Bottomley" >> Cc: Michael Ellerman >> Cc: Christophe Leroy >> Cc: Paul Walmsley >> Cc: Palmer Dabbelt >> Cc: Heiko Carstens >> Cc: Yoshinori Sato >> Cc: "David S. Miller" >> Cc: Jeff Dike >> Cc: Thomas Gleixner >> Cc: Chris Zankel >> Cc: Andrew Morton >> Cc: linux-arch@vger.kernel.org >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> This applies on v5.12-rc7 and has been boot tested on arm64 platform. >> But has been cross compiled on multiple other platforms. >> >> Changes in V2: >> >> - Dropped ARCH_HAS_FIRST_USER_ADDRESS construct >> >> Changes in V1: >> >> https://patchwork.kernel.org/project/linux-mm/patch/1618368899-20311-1-git-send-email-anshuman.khandual@arm.com/ >> >> arch/alpha/include/asm/pgtable.h | 1 - >> arch/arc/include/asm/pgtable.h | 6 ------ >> arch/arm64/include/asm/pgtable.h | 2 -- >> arch/csky/include/asm/pgtable.h | 1 - >> arch/hexagon/include/asm/pgtable.h | 3 --- >> arch/ia64/include/asm/pgtable.h | 1 - >> arch/m68k/include/asm/pgtable_mm.h | 1 - >> arch/microblaze/include/asm/pgtable.h | 2 -- >> arch/mips/include/asm/pgtable-32.h | 1 - >> arch/mips/include/asm/pgtable-64.h | 1 - >> arch/nios2/include/asm/pgtable.h | 2 -- >> arch/openrisc/include/asm/pgtable.h | 1 - > > Acked-by: Stafford Horne > >> arch/parisc/include/asm/pgtable.h | 2 -- >> arch/powerpc/include/asm/book3s/pgtable.h | 1 - >> arch/powerpc/include/asm/nohash/32/pgtable.h | 1 - >> arch/powerpc/include/asm/nohash/64/pgtable.h | 2 -- >> arch/riscv/include/asm/pgtable.h | 2 -- >> arch/s390/include/asm/pgtable.h | 2 -- >> arch/sh/include/asm/pgtable.h | 2 -- >> arch/sparc/include/asm/pgtable_32.h | 1 - >> arch/sparc/include/asm/pgtable_64.h | 3 --- >> arch/um/include/asm/pgtable-2level.h | 1 - >> arch/um/include/asm/pgtable-3level.h | 1 - >> arch/x86/include/asm/pgtable_types.h | 2 -- >> arch/xtensa/include/asm/pgtable.h | 1 - >> include/linux/pgtable.h | 9 +++++++++ >> 26 files changed, 9 insertions(+), 43 deletions(-) > > This all looks fine to me, will this be merged via the arm tree? I guess you > have a means for that. I am hoping that this should go via the MM tree instead.