All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Keith Busch <kbusch@kernel.org>
Cc: axboe@fb.com, Chao Leng <lengchao@huawei.com>,
	linux-nvme@lists.infradead.org, hch@lst.de
Subject: Re: [PATCH] nvme-core: reduce io pause time when fail over
Date: Thu, 23 Jul 2020 12:12:42 -0700	[thread overview]
Message-ID: <18b10b97-d26b-91c8-1abe-6d36714a3429@grimberg.me> (raw)
In-Reply-To: <20200723164212.GA2366615@dhcp-10-100-145-180.wdl.wdc.com>


>> +       /* all namespaces share hctxs, so sync just once */
>> +       blk_mq_quiesce_queue_sync(ns->queue);
> 
> They don't share hctx's. An hctx is a property of a specific
> request_queue, and each namespace has their own.

ugh, right...

But I still think that we should wait for all the srcus together...

Perhaps we should do call_srcu on all and wait for all in one pass.
But I don't want the driver to do this without a proper blk-mq
interface..


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply	other threads:[~2020-07-23 19:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  9:36 [PATCH] nvme-core: reduce io pause time when fail over Chao Leng
2020-07-22 16:00 ` Keith Busch
2020-07-22 16:13   ` Sagi Grimberg
2020-07-23  8:06     ` Chao Leng
2020-07-23 16:30       ` Sagi Grimberg
2020-07-23 16:42         ` Keith Busch
2020-07-23 19:12           ` Sagi Grimberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18b10b97-d26b-91c8-1abe-6d36714a3429@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=lengchao@huawei.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.