From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:53982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2dOq-0002Yl-M9 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 09:56:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2dOp-0007UE-WF for qemu-devel@nongnu.org; Sat, 09 Mar 2019 09:56:32 -0500 References: <20190308013222.12524-1-philmd@redhat.com> <20190308013222.12524-3-philmd@redhat.com> From: Laurent Vivier Message-ID: <18d16b8e-01b3-2bc1-be98-67329e4437cc@vivier.eu> Date: Sat, 9 Mar 2019 15:54:38 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [Qemu-trivial] [Qemu-ppc] [PATCH v2 02/18] hw/i386: Remove unused include List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Laszlo Ersek , Gerd Hoffmann , "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: QEMU Trivial , Igor Mammedov , Eduardo Habkost , Paolo Bonzini On 08/03/2019 12:32, Thomas Huth wrote: > On 08/03/2019 02.32, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> v2: Drop files that do use fw_cfg (Michael): >> - hw/i386/acpi-build.c >> - hw/i386/pc.c >> --- >> hw/acpi/piix4.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c >> index 8fd25a5926..7b98121070 100644 >> --- a/hw/acpi/piix4.c >> +++ b/hw/acpi/piix4.c >> @@ -28,7 +28,6 @@ >> #include "sysemu/sysemu.h" >> #include "qapi/error.h" >> #include "qemu/range.h" >> -#include "hw/nvram/fw_cfg.h" >> #include "exec/address-spaces.h" >> #include "hw/acpi/piix4.h" >> #include "hw/acpi/pcihp.h" >> > > Reviewed-by: Thomas Huth > Applied to my trivial-patches branch. Thanks, Laurent