From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753865AbcHQGXc (ORCPT ); Wed, 17 Aug 2016 02:23:32 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:42106 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbcHQGXb (ORCPT ); Wed, 17 Aug 2016 02:23:31 -0400 Subject: Re: [PATCH v3 4/5] net: ethernet: ti: davinci_cpdma: move cpdma channel struct macroses to internals To: Ivan Khoronzhuk , , , References: <1471303549-4134-1-git-send-email-ivan.khoronzhuk@linaro.org> <1471303549-4134-5-git-send-email-ivan.khoronzhuk@linaro.org> CC: , , From: Mugunthan V N Message-ID: <18d62dfd-8e70-bc81-5b94-29612cdab82d@ti.com> Date: Wed, 17 Aug 2016 11:53:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471303549-4134-5-git-send-email-ivan.khoronzhuk@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 August 2016 04:55 AM, Ivan Khoronzhuk wrote: > Keep the driver internals in C file. Currently it's not required for > drivers to know rx or tx a channel is, except create function. > So correct "channel create" function, and use all channel struct > macroses only for internal use. > > Signed-off-by: Ivan Khoronzhuk Reviewed-by: Mugunthan V N Regards Mugunthan V N From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH v3 4/5] net: ethernet: ti: davinci_cpdma: move cpdma channel struct macroses to internals Date: Wed, 17 Aug 2016 11:53:24 +0530 Message-ID: <18d62dfd-8e70-bc81-5b94-29612cdab82d@ti.com> References: <1471303549-4134-1-git-send-email-ivan.khoronzhuk@linaro.org> <1471303549-4134-5-git-send-email-ivan.khoronzhuk@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1471303549-4134-5-git-send-email-ivan.khoronzhuk@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Ivan Khoronzhuk , davem@davemloft.net, netdev@vger.kernel.org, grygorii.strashko@ti.com Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, nsekhar@ti.com List-Id: linux-omap@vger.kernel.org On Tuesday 16 August 2016 04:55 AM, Ivan Khoronzhuk wrote: > Keep the driver internals in C file. Currently it's not required for > drivers to know rx or tx a channel is, except create function. > So correct "channel create" function, and use all channel struct > macroses only for internal use. > > Signed-off-by: Ivan Khoronzhuk Reviewed-by: Mugunthan V N Regards Mugunthan V N