From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F9BC433F5 for ; Mon, 4 Apr 2022 15:57:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357139AbiDDP7j (ORCPT ); Mon, 4 Apr 2022 11:59:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbiDDP7i (ORCPT ); Mon, 4 Apr 2022 11:59:38 -0400 Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C2C33EF34; Mon, 4 Apr 2022 08:57:41 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 09EA9419BC; Mon, 4 Apr 2022 15:57:35 +0000 (UTC) Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver To: Christoph Hellwig , Sven Peter Cc: Keith Busch , Jens Axboe , Sagi Grimberg , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> <20220324061620.GA12330@lst.de> From: Hector Martin Message-ID: <18f3a7e6-16d1-2037-90e7-1c0b1b2fbb1c@marcan.st> Date: Tue, 5 Apr 2022 00:57:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20220324061620.GA12330@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: es-ES Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/2022 15.16, Christoph Hellwig wrote: >> + >> +//#define DEBUG > > This should not leak into the driverṡ > >> +#include > > As far as I can tell this driver does not support metadata or PI, > so why is this include needed? > >> +/* NVM Express NVM Command Set Specification, Revision 1.0a, Figure 18 */ >> +#define NVME_OPCODE_DATA_XFER_HOST_TO_CTRL BIT(0) >> +#define NVME_OPCODE_DATA_XFER_CTRL_TO_HOST BIT(1) > > Please just use the nvme_is_write helper where you are using these. > >> +static int apple_nvme_sart_dma_setup(void *cookie, struct apple_rtkit_shmem *bfr, > > Please avoid > 80 character lines. The kernel hard limit is 100-character lines, not 80-character lines. Maintainers for existing drivers are certainly free to stick to 80 chars if they like it that way, but I don't see why we should still be enforcing that for new code. See bdc48fa11e46. And also: https://lkml.iu.edu/hypermail/linux/kernel/2005.3/08168.html Quoth Torvalds, addressing you personally: "If you or Christoph have 80 character lines, you'll get possibly ugly wrapped output. Tough. That's _your_ choice. Your hardware limitations shouldn't be a pain for the rest of us." -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68211C433F5 for ; Mon, 4 Apr 2022 15:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=CxFKJK3Uw8rxM9yhgXAODzWFPZ+CiXOT4ZHc+NKxI1k=; b=CfJvsFlx+GBhzoGkhpzYhZAglj /RJM3JbzE1iMrf9IDMFyMAN+RHD64sRujHfhgHLmuNPZpyM23HvniQ2PjteA+lbL4SEvXwnQihXDU el6M7d1IKtV47tBWmt+OUlOiqaG9XTAQ4NKQLcaJPdPXsBu68ZBdEdgLSUQubZWT9v5XatOXLk/WY sQm0Zcikv3ol5TQgMkPmufJCB+38Ck8qUTZ0DEY4s/BDPIKmolDBj/jn5WnEcZp8NX8g0DoNY8KbP OeMgrg8fqkQSQxRIyH2uteJHuyfkNQvkOKq8aa+/LH4euhl2wEtXwMJMnWK2ZXDPMSvyJrLSP2AJR ikgqNbvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbP5Y-00Fe65-NY; Mon, 04 Apr 2022 15:57:57 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbP5P-00Fe1C-TJ; Mon, 04 Apr 2022 15:57:50 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 09EA9419BC; Mon, 4 Apr 2022 15:57:35 +0000 (UTC) Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver To: Christoph Hellwig , Sven Peter Cc: Keith Busch , Jens Axboe , Sagi Grimberg , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> <20220324061620.GA12330@lst.de> From: Hector Martin Message-ID: <18f3a7e6-16d1-2037-90e7-1c0b1b2fbb1c@marcan.st> Date: Tue, 5 Apr 2022 00:57:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20220324061620.GA12330@lst.de> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_085748_122006_E1C69660 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjQvMDMvMjAyMiAxNS4xNiwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4+ICsKPj4gKy8v I2RlZmluZSBERUJVRwo+IAo+IFRoaXMgc2hvdWxkIG5vdCBsZWFrIGludG8gdGhlIGRyaXZlcuG5 oQo+IAo+PiArI2luY2x1ZGUgPGxpbnV4L2Jsay1pbnRlZ3JpdHkuaD4KPiAKPiBBcyBmYXIgYXMg SSBjYW4gdGVsbCB0aGlzIGRyaXZlciBkb2VzIG5vdCBzdXBwb3J0IG1ldGFkYXRhIG9yIFBJLAo+ IHNvIHdoeSBpcyB0aGlzIGluY2x1ZGUgbmVlZGVkPwo+IAo+PiArLyogTlZNIEV4cHJlc3MgTlZN IENvbW1hbmQgU2V0IFNwZWNpZmljYXRpb24sIFJldmlzaW9uIDEuMGEsIEZpZ3VyZSAxOCAqLwo+ PiArI2RlZmluZSBOVk1FX09QQ09ERV9EQVRBX1hGRVJfSE9TVF9UT19DVFJMIEJJVCgwKQo+PiAr I2RlZmluZSBOVk1FX09QQ09ERV9EQVRBX1hGRVJfQ1RSTF9UT19IT1NUIEJJVCgxKQo+IAo+IFBs ZWFzZSBqdXN0IHVzZSB0aGUgbnZtZV9pc193cml0ZSBoZWxwZXIgd2hlcmUgeW91IGFyZSB1c2lu ZyB0aGVzZS4KPiAKPj4gK3N0YXRpYyBpbnQgYXBwbGVfbnZtZV9zYXJ0X2RtYV9zZXR1cCh2b2lk ICpjb29raWUsIHN0cnVjdCBhcHBsZV9ydGtpdF9zaG1lbSAqYmZyLAo+IAo+IFBsZWFzZSBhdm9p ZCA+IDgwIGNoYXJhY3RlciBsaW5lcy4KClRoZSBrZXJuZWwgaGFyZCBsaW1pdCBpcyAxMDAtY2hh cmFjdGVyIGxpbmVzLCBub3QgODAtY2hhcmFjdGVyIGxpbmVzLgpNYWludGFpbmVycyBmb3IgZXhp c3RpbmcgZHJpdmVycyBhcmUgY2VydGFpbmx5IGZyZWUgdG8gc3RpY2sgdG8gODAgY2hhcnMKaWYg dGhleSBsaWtlIGl0IHRoYXQgd2F5LCBidXQgSSBkb24ndCBzZWUgd2h5IHdlIHNob3VsZCBzdGls bCBiZQplbmZvcmNpbmcgdGhhdCBmb3IgbmV3IGNvZGUuIFNlZSBiZGM0OGZhMTFlNDYuCgpBbmQg YWxzbzoKaHR0cHM6Ly9sa21sLml1LmVkdS9oeXBlcm1haWwvbGludXgva2VybmVsLzIwMDUuMy8w ODE2OC5odG1sCgpRdW90aCBUb3J2YWxkcywgYWRkcmVzc2luZyB5b3UgcGVyc29uYWxseToKCiJJ ZiB5b3Ugb3IgQ2hyaXN0b3BoIGhhdmUgODAgY2hhcmFjdGVyIGxpbmVzLCB5b3UnbGwgZ2V0IHBv c3NpYmx5IHVnbHkKd3JhcHBlZCBvdXRwdXQuIFRvdWdoLiBUaGF0J3MgX3lvdXJfIGNob2ljZS4g WW91ciBoYXJkd2FyZSBsaW1pdGF0aW9ucwpzaG91bGRuJ3QgYmUgYSBwYWluIGZvciB0aGUgcmVz dCBvZiB1cy4iCgotLSAKSGVjdG9yIE1hcnRpbiAobWFyY2FuQG1hcmNhbi5zdCkKUHVibGljIEtl eTogaHR0cHM6Ly9tcmNuLnN0L3B1YgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=