From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D882C433F5 for ; Fri, 31 Dec 2021 07:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242712AbhLaHFg (ORCPT ); Fri, 31 Dec 2021 02:05:36 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:17314 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbhLaHFg (ORCPT ); Fri, 31 Dec 2021 02:05:36 -0500 Received: from kwepemi100009.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JQGNM1jB0z9s1L; Fri, 31 Dec 2021 15:04:35 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by kwepemi100009.china.huawei.com (7.221.188.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 31 Dec 2021 15:05:32 +0800 Received: from [10.67.102.118] (10.67.102.118) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 31 Dec 2021 15:05:32 +0800 Subject: Re: [PATCH v2 2/6] crypto: arm64/sm3-ce - make dependent on sm3 library To: Tianjia Zhang , Herbert Xu , "David S. Miller" , Vitaly Chikunov , Eric Biggers , "Eric Biggers" , Gilad Ben-Yossef , "Ard Biesheuvel" , Jussi Kivilinna , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , , , , References: <20211222045022.27069-1-tianjia.zhang@linux.alibaba.com> <20211222045022.27069-3-tianjia.zhang@linux.alibaba.com> From: liulongfang Message-ID: <18fdaf2c-827e-8d17-1eb7-cb1c12d15808@huawei.com> Date: Fri, 31 Dec 2021 15:05:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20211222045022.27069-3-tianjia.zhang@linux.alibaba.com> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.118] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2021/12/22 12:50, Tianjia Zhang Wrote: > SM3 generic library is stand-alone implementation, sm3-ce can depend > on the SM3 library instead of sm3-generic. > > Signed-off-by: Tianjia Zhang > --- > arch/arm64/crypto/Kconfig | 2 +- > arch/arm64/crypto/sm3-ce-glue.c | 20 ++++++++++++++------ > 2 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig > index addfa413650b..2a965aa0188d 100644 > --- a/arch/arm64/crypto/Kconfig > +++ b/arch/arm64/crypto/Kconfig > @@ -45,7 +45,7 @@ config CRYPTO_SM3_ARM64_CE > tristate "SM3 digest algorithm (ARMv8.2 Crypto Extensions)" > depends on KERNEL_MODE_NEON > select CRYPTO_HASH > - select CRYPTO_SM3 > + select CRYPTO_LIB_SM3 > > config CRYPTO_SM4_ARM64_CE > tristate "SM4 symmetric cipher (ARMv8.2 Crypto Extensions)" > diff --git a/arch/arm64/crypto/sm3-ce-glue.c b/arch/arm64/crypto/sm3-ce-glue.c > index d71faca322f2..3198f31c9446 100644 > --- a/arch/arm64/crypto/sm3-ce-glue.c > +++ b/arch/arm64/crypto/sm3-ce-glue.c > @@ -27,7 +27,7 @@ static int sm3_ce_update(struct shash_desc *desc, const u8 *data, > unsigned int len) > { > if (!crypto_simd_usable()) > - return crypto_sm3_update(desc, data, len); > + return sm3_update(shash_desc_ctx(desc), data, len); > > kernel_neon_begin(); > sm3_base_do_update(desc, data, len, sm3_ce_transform); > @@ -39,7 +39,7 @@ static int sm3_ce_update(struct shash_desc *desc, const u8 *data, > static int sm3_ce_final(struct shash_desc *desc, u8 *out) > { > if (!crypto_simd_usable()) > - return crypto_sm3_finup(desc, NULL, 0, out); > + return sm3_final(shash_desc_ctx(desc), out); > > kernel_neon_begin(); > sm3_base_do_finalize(desc, sm3_ce_transform); > @@ -51,14 +51,22 @@ static int sm3_ce_final(struct shash_desc *desc, u8 *out) > static int sm3_ce_finup(struct shash_desc *desc, const u8 *data, > unsigned int len, u8 *out) > { > - if (!crypto_simd_usable()) > - return crypto_sm3_finup(desc, data, len, out); > + if (!crypto_simd_usable()) { > + struct sm3_state *sctx = shash_desc_ctx(desc); > + > + if (len) > + sm3_update(sctx, data, len); > + sm3_final(sctx, out); > + return 0; > + } > > kernel_neon_begin(); > - sm3_base_do_update(desc, data, len, sm3_ce_transform); > + if (len) > + sm3_base_do_update(desc, data, len, sm3_ce_transform); > + sm3_base_do_finalize(desc, sm3_ce_transform); > kernel_neon_end(); > > - return sm3_ce_final(desc, out); > + return sm3_base_finish(desc, out); > } > > static struct shash_alg sm3_alg = { >You have modified the implementation of SM3 algorithm, so what benefits will be gained after such modification? What flaws are solved or can performance be improved? Thanks. Longfang. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2C4CC433EF for ; Fri, 31 Dec 2021 07:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=NjlukoKbe+NRQk/q1ONufom1BCxQ4NkoRvD4BflG8Ws=; b=P25Y9AiUZLH2Z8J5xREOVDRSu3 medl7XLEgQcz1gxmFyGgX1Yvv3R0nZWEHPzY237qf52RDUATkbCEgD+jdxtc0KVYOMNKLJiJ1jX/3 z8eg5GyRJyLm8Y0IzvusAMqQHNR5QOmezQMMt95qidckrCasXAie7tDXX9/ICGw1y7iUgl327TRmh 6wmd4zKNdXpn0i7T3RlqaGC7WMCEUvBB7noemUHrBPdKt8X2zDF3naVm1ActUAYWfcKWkPyVk5Lbk AEo58okwHt0aYU+w9kd9LJLlIwz/WZVJTiA/sb3eU8maaMtjhI5YL5NkiMET+CJQ1VCboApRONl/w Si55HHSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3Byz-005ld7-M3; Fri, 31 Dec 2021 07:05:45 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3Byv-005lcC-Ul for linux-arm-kernel@lists.infradead.org; Fri, 31 Dec 2021 07:05:44 +0000 Received: from kwepemi100009.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JQGNM1jB0z9s1L; Fri, 31 Dec 2021 15:04:35 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by kwepemi100009.china.huawei.com (7.221.188.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 31 Dec 2021 15:05:32 +0800 Received: from [10.67.102.118] (10.67.102.118) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 31 Dec 2021 15:05:32 +0800 Subject: Re: [PATCH v2 2/6] crypto: arm64/sm3-ce - make dependent on sm3 library To: Tianjia Zhang , Herbert Xu , "David S. Miller" , Vitaly Chikunov , Eric Biggers , "Eric Biggers" , Gilad Ben-Yossef , "Ard Biesheuvel" , Jussi Kivilinna , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , , , , References: <20211222045022.27069-1-tianjia.zhang@linux.alibaba.com> <20211222045022.27069-3-tianjia.zhang@linux.alibaba.com> From: liulongfang Message-ID: <18fdaf2c-827e-8d17-1eb7-cb1c12d15808@huawei.com> Date: Fri, 31 Dec 2021 15:05:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20211222045022.27069-3-tianjia.zhang@linux.alibaba.com> X-Originating-IP: [10.67.102.118] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_230542_381853_604D2247 X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/12/22 12:50, Tianjia Zhang Wrote: > SM3 generic library is stand-alone implementation, sm3-ce can depend > on the SM3 library instead of sm3-generic. > > Signed-off-by: Tianjia Zhang > --- > arch/arm64/crypto/Kconfig | 2 +- > arch/arm64/crypto/sm3-ce-glue.c | 20 ++++++++++++++------ > 2 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig > index addfa413650b..2a965aa0188d 100644 > --- a/arch/arm64/crypto/Kconfig > +++ b/arch/arm64/crypto/Kconfig > @@ -45,7 +45,7 @@ config CRYPTO_SM3_ARM64_CE > tristate "SM3 digest algorithm (ARMv8.2 Crypto Extensions)" > depends on KERNEL_MODE_NEON > select CRYPTO_HASH > - select CRYPTO_SM3 > + select CRYPTO_LIB_SM3 > > config CRYPTO_SM4_ARM64_CE > tristate "SM4 symmetric cipher (ARMv8.2 Crypto Extensions)" > diff --git a/arch/arm64/crypto/sm3-ce-glue.c b/arch/arm64/crypto/sm3-ce-glue.c > index d71faca322f2..3198f31c9446 100644 > --- a/arch/arm64/crypto/sm3-ce-glue.c > +++ b/arch/arm64/crypto/sm3-ce-glue.c > @@ -27,7 +27,7 @@ static int sm3_ce_update(struct shash_desc *desc, const u8 *data, > unsigned int len) > { > if (!crypto_simd_usable()) > - return crypto_sm3_update(desc, data, len); > + return sm3_update(shash_desc_ctx(desc), data, len); > > kernel_neon_begin(); > sm3_base_do_update(desc, data, len, sm3_ce_transform); > @@ -39,7 +39,7 @@ static int sm3_ce_update(struct shash_desc *desc, const u8 *data, > static int sm3_ce_final(struct shash_desc *desc, u8 *out) > { > if (!crypto_simd_usable()) > - return crypto_sm3_finup(desc, NULL, 0, out); > + return sm3_final(shash_desc_ctx(desc), out); > > kernel_neon_begin(); > sm3_base_do_finalize(desc, sm3_ce_transform); > @@ -51,14 +51,22 @@ static int sm3_ce_final(struct shash_desc *desc, u8 *out) > static int sm3_ce_finup(struct shash_desc *desc, const u8 *data, > unsigned int len, u8 *out) > { > - if (!crypto_simd_usable()) > - return crypto_sm3_finup(desc, data, len, out); > + if (!crypto_simd_usable()) { > + struct sm3_state *sctx = shash_desc_ctx(desc); > + > + if (len) > + sm3_update(sctx, data, len); > + sm3_final(sctx, out); > + return 0; > + } > > kernel_neon_begin(); > - sm3_base_do_update(desc, data, len, sm3_ce_transform); > + if (len) > + sm3_base_do_update(desc, data, len, sm3_ce_transform); > + sm3_base_do_finalize(desc, sm3_ce_transform); > kernel_neon_end(); > > - return sm3_ce_final(desc, out); > + return sm3_base_finish(desc, out); > } > > static struct shash_alg sm3_alg = { >You have modified the implementation of SM3 algorithm, so what benefits will be gained after such modification? What flaws are solved or can performance be improved? Thanks. Longfang. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel