From: Rao Shoaib <rao.shoaib@oracle.com>
To: David Miller <davem@davemloft.net>, codesoldier1@gmail.com
Cc: hkchu@google.com, ycheng@google.com, kuznet@ms2.inr.ac.ru,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482
Date: Wed, 9 Aug 2017 17:47:57 -0700 [thread overview]
Message-ID: <19024bb3-c06b-d004-5527-e4c54af66003@oracle.com> (raw)
In-Reply-To: <20170809.173032.660035274684914457.davem@davemloft.net>
On 08/09/2017 05:30 PM, David Miller wrote:
> From: Joe Smith <codesoldier1@gmail.com>
> Date: Wed, 9 Aug 2017 17:20:32 -0700
>
>> Making Linux conform to standards and behavior that is logical seems
>> like a good enough reason.
> That's an awesome attitude to have when we're implementing something
> new and don't have the facility already.
>
> But when we have something already the only important consideration is
> not breaking existing apps which rely on that behavior.
>
> That is much, much, more important than standards compliance.
>
> If users are confused, just fix the documentation.
David,
If it was just confusion than sure fixing the documentation is fine.
What if the logic is incorrect, does not conform to the standard that is
says it is implementing and easy to fix with little or no risk of breakage.
The proposed patch changes a feature that no one uses. It also imposes
the relation ship between keepalive and timeout values that is required
by the RFC and make sense.
You are the final authority, if you say we should just fix the
documentation than that is fine.
Shoaib
next prev parent reply other threads:[~2017-08-10 0:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 18:16 [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482 Rao Shoaib
2017-08-08 9:59 ` Eric Dumazet
2017-08-08 17:25 ` Yuchung Cheng
2017-08-09 23:52 ` Jerry Chu
2017-08-10 0:20 ` Joe Smith
2017-08-10 0:30 ` David Miller
2017-08-10 0:47 ` Rao Shoaib [this message]
2017-08-10 0:52 ` David Miller
2017-08-10 3:32 ` Jerry Chu
2017-08-10 4:59 ` Jerry Chu
2017-08-10 21:05 ` Rao Shoaib
2017-08-11 2:32 ` Jerry Chu
2017-08-10 0:31 ` Rao Shoaib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19024bb3-c06b-d004-5527-e4c54af66003@oracle.com \
--to=rao.shoaib@oracle.com \
--cc=codesoldier1@gmail.com \
--cc=davem@davemloft.net \
--cc=hkchu@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.