All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John Stoffel" <john@stoffel.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, lenb@kernel.org, mingo@elte.hu,
	akpm@linux-foundation.org, peterz@infradead.org,
	yanmin_zhang@linux.intel.com, torvalds@linux-foundation.org,
	jens.axboe@oracle.com
Subject: Re: PATCH] cpuidle: A new variant of the menu governor to boost IO performance
Date: Fri, 11 Sep 2009 15:16:49 -0400	[thread overview]
Message-ID: <19114.41505.479086.782442@stoffel.org> (raw)
In-Reply-To: <20090911174019.1ed02737@infradead.org>

>>>>> "Arjan" == Arjan van de Ven <arjan@infradead.org> writes:

Arjan> From: Arjan van de Ven <arjan@linux.intel.com>
Arjan> Subject: [PATCH] cpuidle: A new variant of the menu governor

Arjan> This patch adds a new idle governor which balances power savings,
Arjan> energy efficiency and performance impact.

Arjan> The reason for a reworked governor is that there have been
Arjan> serious performance issues reported with the existing code
Arjan> on Nehalem server systems.

Arjan> To show this I'm sure Andrew wants to see benchmark results:
Arjan> (benchmark is "fio", "no cstates" is using "idle=poll")

Arjan> 		no cstates	current linux	new algorithm
Arjan> 1 disk		107 Mb/s	85 Mb/s		105 Mb/s
Arjan> 2 disks		215 Mb/s	123 Mb/s	209 Mb/s
Arjan> 12 disks	590 Mb/s	320 Mb/s	585 Mb/s

Don't you need another row or three where you show a) how much time
each test took, and b) how much (or average) power used for the
duration of the test?  

I'm just curious if the new algorithm (or even the current one!) saves
any appreciable power over the 'no cstates' case.  It's not clear what
the savings are.  

Also, latency in terms of switching to higher power and then back down
would be nice to see.

Cheers,
John

  parent reply	other threads:[~2009-09-11 19:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 15:40 PATCH] cpuidle: A new variant of the menu governor to boost IO performance Arjan van de Ven
2009-09-11 16:37 ` Jens Axboe
2009-09-11 19:16 ` John Stoffel [this message]
2009-09-11 19:51   ` Arjan van de Ven
2009-09-14  3:30   ` Zhang, Yanmin
2009-09-11 22:03 ` Matthew Garrett
2009-09-12  3:26   ` Arjan van de Ven
2009-09-12 11:39     ` Matthew Garrett
2009-09-12 14:04       ` Arjan van de Ven
2009-09-13 23:30 ` Andrew Morton
2009-09-14  2:45   ` Arjan van de Ven
2009-09-14  7:43 ` Andrew Morton
2009-09-14  8:04   ` Tejun Heo
2009-09-14  8:15     ` Peter Zijlstra
2009-09-14  9:09       ` Tejun Heo
2009-09-14 20:31   ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19114.41505.479086.782442@stoffel.org \
    --to=john@stoffel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=jens.axboe@oracle.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.