[PATCH] Re: Gitk --all error when there are more than 797 refs in a repository

From: Paul Mackerras <paulus@samba.org>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: "Murphy, John" <john.murphy@bankofamerica.com>, git@vger.kernel.org
Subject: [PATCH] Re: Gitk --all error when there are more than 797 refs in a repository
Date: Sat, 19 Sep 2009 10:07:22 +1000	[thread overview]
Message-ID: <19124.8378.975976.347711@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <878wgcbb52.fsf@users.sourceforge.net>

Pat Thoyts writes:

> Tcl strings can eat all your memory. However, there is a limit to the
> size of the command line argument passed to CreateProcess.  MSDN says
> of the lpCommandLine parameter:
>   "The maximum length of this string is 32K characters."
> A solution for this case will be to use a pipe to read the responses
> instead of having it all returned to the caller.
> The following patch might be sufficient:

I knew about the 32k command-line limit under windows, but I don't see
how that applies in this case unless it is $revs that is too long (and
if that is the case then I don't see how your patch helps).  Is there
also a 32k limit on the size of data returned by a command executed
with [exec]?

Paul.