From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B2BC38A2A for ; Sun, 10 May 2020 22:29:29 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id B341A20801 for ; Sun, 10 May 2020 22:29:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="qcUYB2JR"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="pWV+Yhr7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B341A20801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 968DD1C435; Mon, 11 May 2020 00:29:27 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 7E3901C230 for ; Mon, 11 May 2020 00:29:26 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 300495803AA; Sun, 10 May 2020 18:29:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 10 May 2020 18:29:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ky4niehx7uDxFoOQKL8du6CI7l2mBzvLNccH3A6n8Ww=; b=qcUYB2JRqJ7J0ZeK DEUXSnviplioXl0SVZsPpnLrjs2XGSIT5jOWE44bQ93Lb3M7OhDEd8k/T5k397uY YcT0AtGawtnrzscd/r3r4mgdikVCAOqOcg/3aH5mtue33G4HLSO9qny1V0krg0ca FkKLynQtVYUjjQzKgyMb4cP45TP5J377DHwiM7MwuKNLDrXJwD81l/42/xnQ6Rf6 6Bs0my0kHw1mlXOlDI1vhQdJZF0c5zIYuXFV7n131+E3vW3ZKxiAn1gSahNMLHat 3VEKecmHiAd6ssmt1BIF0MEg99JGf4N88nUsPDziYA9dF3GdWuVfPirjNZHJfjH9 ShOfTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ky4niehx7uDxFoOQKL8du6CI7l2mBzvLNccH3A6n8 Ww=; b=pWV+Yhr7ROkn4YhlTs1xmaj1mR4Wt8ysuw/tgSq4BKNHs/KSN6NrUG2sD SPnO42GRpPSTzbI/BSIfwrw0t8kJeGfT3recXYfh1QNU3MPKdhk/zzpVjK3rbGUm 3ElZIklV/gyH1a5HOb7kE9iCcNxb7ihQXqlczzzUQlQczn+cQO0KJwCufoSlg7K7 ycRNzF+JEMiEzhEq7+WCO1aZK3WJ5rZV7iGjGq7/MmSgAi7m14wPjipUvINvBM7Z PGTPVYZ19uP5rRSUK8QlFA78fcwjmZBmUAAdb82rZaDmOZjf6Ptp0ukFkwufm67Y ZdshQUBjCm//2imT1RoDXVyew3xpA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkeelgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C64543280059; Sun, 10 May 2020 18:29:20 -0400 (EDT) From: Thomas Monjalon To: Ciara Power , Bruce Richardson Cc: dev@dpdk.org, kevin.laatz@intel.com, reshma.pattan@intel.com, jerinjacobk@gmail.com, david.marchand@redhat.com, keith.wiles@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, bluca@debian.org Date: Mon, 11 May 2020 00:29:17 +0200 Message-ID: <19147519.Yz81rIOvuz@thomas> In-Reply-To: <20200430160137.59135-16-ciara.power@intel.com> References: <20200319171907.60891-1-ciara.power@intel.com> <20200430160137.59135-1-ciara.power@intel.com> <20200430160137.59135-16-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 15/18] lib: add telemetry as eal dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/04/2020 18:01, Ciara Power: > This patch moves telemetry further down the build, and adds it as a > dependency for EAL. Telemetry V2 is now configured to build by default, > and the legacy support is built when the telemetry config flag is set. > > Telemetry now has EAL flags, shown below: > "--telemetry" = Enables telemetry (this is default if no flags given) What is the need for enabling something already enabled? > "--no-telemetry" = Disables telemetry [...] > + case OPT_TELEMETRY_NUM: > + break; > + case OPT_NO_TELEMETRY_NUM: > + conf->no_telemetry = 1; > + break; I feel one option would be enough.