All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	yocto@lists.yoctoproject.org
Cc: docs@lists.yoctoproject.org
Subject: Re: [yocto] [docs] [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth
Date: Wed, 24 Nov 2021 19:45:51 +0100	[thread overview]
Message-ID: <1914a66b-2f8a-da6b-d892-53fbe6b45562@bootlin.com> (raw)
In-Reply-To: <98664c40610ee3163638a373f105f29c9c70a912.camel@linuxfoundation.org>

Hi Richard,

Thanks for the review!

On 11/24/21 7:10 PM, Richard Purdie wrote:
> On Wed, 2021-11-24 at 18:16 +0100, Michael Opdenacker wrote:
>> Together with the corresponding Bitbake version, which are no
>> longer supported.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> ---
>>  scripts/run-docs-build | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/run-docs-build b/scripts/run-docs-build
>> index 3db4a97..5e1d649 100755
>> --- a/scripts/run-docs-build
>> +++ b/scripts/run-docs-build
>> @@ -35,7 +35,7 @@ mkdir $outputdir/bitbake/next
>>  cp -r ./_build/final/* $outputdir/bitbake/next
>>  
>>  # stable branches
>> -for branch in 1.46 1.48 1.50 1.52; do
>> +for branch in 1.46 1.50 1.52; do
>>      git checkout $branch
>>      make clean
>>      make publish
>> @@ -68,7 +68,7 @@ mkdir $outputdir/next
>>  cp -r ./_build/final/* $outputdir/next
>>  
>>  # stable branches
>> -for branch in dunfell gatesgarth hardknott honister; do
>> +for branch in dunfell hardknott honister; do
>>      cd $ypdocs
>>      git checkout $branch
>>      make clean
> I'm a bit torn on this. They are no longer officially supported releases now but
> it may make sense to rebuild all the sphinx docs in this script rather than some
> subset?


I understand. Your decision to make.
I just proposed this change for consistency with the current implementation.

Any other opinions?

Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2021-11-24 18:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 17:16 [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth Michael Opdenacker
2021-11-24 18:10 ` [docs] " Richard Purdie
2021-11-24 18:45   ` Michael Opdenacker [this message]
2021-11-24 18:47   ` Quentin Schulz
2021-11-24 18:50     ` Michael Opdenacker
2021-11-25  8:42       ` Nicolas Dechesne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1914a66b-2f8a-da6b-d892-53fbe6b45562@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=yocto@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.