From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2226C43141 for ; Thu, 14 Nov 2019 13:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5CC720725 for ; Thu, 14 Nov 2019 13:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbfKNN0F (ORCPT ); Thu, 14 Nov 2019 08:26:05 -0500 Received: from gloria.sntech.de ([185.11.138.130]:34418 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbfKNN0E (ORCPT ); Thu, 14 Nov 2019 08:26:04 -0500 Received: from wf0530.dip.tu-dresden.de ([141.76.182.18] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVF8H-0002V4-Fs; Thu, 14 Nov 2019 14:25:57 +0100 From: Heiko Stuebner To: Markus Reichl Cc: Rob Herring , Mark Rutland , Jagan Teki , 'Ulf Hansson' , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, "linux-mmc@vger.kernel.org" Subject: Re: [PATCH v2] arm64: dts: rockchip: Add SDR104 mode to SD-card I/F on rk3399-roc-pc Date: Thu, 14 Nov 2019 14:25:56 +0100 Message-ID: <1918981.kTmXGv9Lqf@phil> In-Reply-To: <25466090-3b24-2695-10fb-88c59be3f149@fivetechno.de> References: <25466090-3b24-2695-10fb-88c59be3f149@fivetechno.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Markus, Am Dienstag, 12. November 2019, 09:45:36 CET schrieb Markus Reichl: > Add SDR104 capability and regulators to SD card node. > While at it, fix a typo in lcd pinctrl and remove two > undocumented bindings from pmic. A commit message like this always is a good indicator that this wants to be multiple patches ;-) [Keywords: "While at it", "And", ...] > Signed-off-by: Markus Reichl > --- > v2: Remove always-on from vcc3v0_sd > --- > .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 30 +++++++++++++++---- > 1 file changed, 24 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > index d1eb55c855b3..a31099f7620b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > @@ -135,6 +135,19 @@ > vin-supply = <&vcc_1v8>; > }; > > + vcc3v0_sd: vcc3v0-sd { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&vcc3v0_sd_en>; > + regulator-name = "vcc3v0_sd"; > + regulator-boot-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + vin-supply = <&vcc3v3_sys>; > + }; > + > vcc3v3_sys: vcc3v3-sys { > compatible = "regulator-fixed"; > regulator-name = "vcc3v3_sys"; > @@ -293,8 +306,6 @@ > vcc10-supply = <&vcc3v3_sys>; > vcc11-supply = <&vcc3v3_sys>; > vcc12-supply = <&vcc3v3_sys>; > - vcc13-supply = <&vcc3v3_sys>; > - vcc14-supply = <&vcc3v3_sys>; Separate patch with nice description perhaps? (remove undocumented inputs) > vddio-supply = <&vcc_3v0>; > > regulators { > @@ -576,7 +587,7 @@ > > lcd-panel { > lcd_panel_reset: lcd-panel-reset { > - rockchip,pins = <4 RK_PD6 RK_FUNC_GPIO &pcfg_pull_up>; > + rockchip,pins = <4 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>; Separate patch please, "use correct pin for lcd-reset pinctrl" or so. > }; > }; > > @@ -602,6 +613,10 @@ > vsel2_gpio: vsel2-gpio { > rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>; > }; > + > + pmic_int_l: pmic-int-l { > + rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > }; > > sdio-pwrseq { > @@ -610,9 +625,9 @@ > }; > }; > > - pmic { > - pmic_int_l: pmic-int-l { > - rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>; separate patch please talking about regrouping the two separate pmic pin-groups. > + sdmmc { > + vcc3v0_sd_en: vcc3v0-sd-en { > + rockchip,pins = <4 RK_PD6 RK_FUNC_GPIO &pcfg_pull_none>; > }; > }; > > @@ -667,6 +682,9 @@ > cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>; > disable-wp; > max-frequency = <150000000>; > + sd-uhs-sdr104; > + vmmc-supply = <&vcc3v0_sd>; > + vqmmc-supply = <&vcc_sdio>; Alphabetical sorting of new properties please (status staying at the bottom though) > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; > status = "okay"; > Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69FBC43215 for ; Thu, 14 Nov 2019 13:26:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC32920729 for ; Thu, 14 Nov 2019 13:26:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AbPTGRTH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC32920729 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cCfmsvJ3h1KHts9M/as7dYtJUby+gLZZzS8c8GBbOPI=; b=AbPTGRTHb7V9pY sgMGhYVcrP9CDVyusDz2RtRuk6y0WiVnGNan0oN7x7Oa6Gt+MzYPs5434oIeV68ja/9EDxjxM63m8 aU9GQ98nV0WeswrNAOFlQlzJh8eF0JRbCH4t7oatV2CANTZ8O5CkLNNlByqe2QcrHN/7WvPiPZBrZ 8e1Jk0FaePT0fBIZLmrreo5BMka4ghNH+k+iMRTnRWkBMignTZCZonzimhknPCjieLTOcCdeoL4PQ JgZhhQQpKbqH4CWwFEyM4KcbCJwKd5kHJq96QNWg9vpyUQHfwHiNYp8cGfxPXR/WbaxX1GGD1lSHd 1fAfz9Xi2/KUJPW2JNWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVF8R-00014w-0u; Thu, 14 Nov 2019 13:26:07 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVF8M-000119-G9; Thu, 14 Nov 2019 13:26:05 +0000 Received: from wf0530.dip.tu-dresden.de ([141.76.182.18] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVF8H-0002V4-Fs; Thu, 14 Nov 2019 14:25:57 +0100 From: Heiko Stuebner To: Markus Reichl Subject: Re: [PATCH v2] arm64: dts: rockchip: Add SDR104 mode to SD-card I/F on rk3399-roc-pc Date: Thu, 14 Nov 2019 14:25:56 +0100 Message-ID: <1918981.kTmXGv9Lqf@phil> In-Reply-To: <25466090-3b24-2695-10fb-88c59be3f149@fivetechno.de> References: <25466090-3b24-2695-10fb-88c59be3f149@fivetechno.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_052602_699073_94DCC47E X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, 'Ulf Hansson' , "linux-mmc@vger.kernel.org" , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Markus, Am Dienstag, 12. November 2019, 09:45:36 CET schrieb Markus Reichl: > Add SDR104 capability and regulators to SD card node. > While at it, fix a typo in lcd pinctrl and remove two > undocumented bindings from pmic. A commit message like this always is a good indicator that this wants to be multiple patches ;-) [Keywords: "While at it", "And", ...] > Signed-off-by: Markus Reichl > --- > v2: Remove always-on from vcc3v0_sd > --- > .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 30 +++++++++++++++---- > 1 file changed, 24 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > index d1eb55c855b3..a31099f7620b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > @@ -135,6 +135,19 @@ > vin-supply = <&vcc_1v8>; > }; > > + vcc3v0_sd: vcc3v0-sd { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&vcc3v0_sd_en>; > + regulator-name = "vcc3v0_sd"; > + regulator-boot-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + vin-supply = <&vcc3v3_sys>; > + }; > + > vcc3v3_sys: vcc3v3-sys { > compatible = "regulator-fixed"; > regulator-name = "vcc3v3_sys"; > @@ -293,8 +306,6 @@ > vcc10-supply = <&vcc3v3_sys>; > vcc11-supply = <&vcc3v3_sys>; > vcc12-supply = <&vcc3v3_sys>; > - vcc13-supply = <&vcc3v3_sys>; > - vcc14-supply = <&vcc3v3_sys>; Separate patch with nice description perhaps? (remove undocumented inputs) > vddio-supply = <&vcc_3v0>; > > regulators { > @@ -576,7 +587,7 @@ > > lcd-panel { > lcd_panel_reset: lcd-panel-reset { > - rockchip,pins = <4 RK_PD6 RK_FUNC_GPIO &pcfg_pull_up>; > + rockchip,pins = <4 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>; Separate patch please, "use correct pin for lcd-reset pinctrl" or so. > }; > }; > > @@ -602,6 +613,10 @@ > vsel2_gpio: vsel2-gpio { > rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>; > }; > + > + pmic_int_l: pmic-int-l { > + rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > }; > > sdio-pwrseq { > @@ -610,9 +625,9 @@ > }; > }; > > - pmic { > - pmic_int_l: pmic-int-l { > - rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>; separate patch please talking about regrouping the two separate pmic pin-groups. > + sdmmc { > + vcc3v0_sd_en: vcc3v0-sd-en { > + rockchip,pins = <4 RK_PD6 RK_FUNC_GPIO &pcfg_pull_none>; > }; > }; > > @@ -667,6 +682,9 @@ > cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>; > disable-wp; > max-frequency = <150000000>; > + sd-uhs-sdr104; > + vmmc-supply = <&vcc3v0_sd>; > + vqmmc-supply = <&vcc_sdio>; Alphabetical sorting of new properties please (status staying at the bottom though) > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; > status = "okay"; > Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel