From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Wu Date: Mon, 1 Apr 2019 18:20:32 +0800 Subject: [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT In-Reply-To: <20190227190543.3325-1-xypron.glpk@gmx.de> References: <20190227190543.3325-1-xypron.glpk@gmx.de> Message-ID: <191d20ec-2aa3-c572-ee14-5f5d44a26fa5@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Philipp, This config does not look like it will be used in SPL and can be deleted. Reviewed-by: David Wu 在 2019/2/28 上午3:05, Heinrich Schuchardt 写道: > The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit > is exceeded. > > CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's > disable it. > > Suggested-by: David Wu > Signed-off-by: Heinrich Schuchardt > --- > This solves only one of the problems with the boards in v2019.04. > The next problem is that reading the environment from MMC fails. > > The patch > [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB > https://lists.denx.de/pipermail/u-boot/2019-February/358883.html > makes the problem visibe. > --- > configs/tinker-rk3288_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig > index 68adf7635bf..03a7f81d63d 100644 > --- a/configs/tinker-rk3288_defconfig > +++ b/configs/tinker-rk3288_defconfig > @@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" > CONFIG_DISPLAY_BOARDINFO_LATE=y > CONFIG_SPL_STACK_R=y > CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 > -CONFIG_SPL_I2C_SUPPORT=y > CONFIG_CMD_GPIO=y > CONFIG_CMD_GPT=y > CONFIG_CMD_I2C=y >