All of lore.kernel.org
 help / color / mirror / Atom feed
From: juergh@gmail.com (Juerg Haefliger)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] vt1211 questions
Date: Tue, 13 Dec 2005 20:44:37 +0000	[thread overview]
Message-ID: <191fb4ca0512131244y460b368do91d586d73f21c258@mail.gmail.com> (raw)

Folks,

I'm currently modifying the vt1211 driver to add PWM fan control and
for (yet another) attempt to submit it to the 2.6.x kernel tree. While
going over the code (Lars Ekman's port of Mark D. Studebaker's
original driver) I noticed 2 things:

1) The mapping of the temperature reading to the actual sysfs node
name is convoluted. I.e. Reading1 maps to temp3 and Reading3 maps to
temp1. Comments in the code mention that this is to minimize changes
from the via686a driver. Since I'm currently cleaning up and extending
the code there's probably not much commonality between the two
anymore. So should I change that convoluted mapping to Reading1->temp1
and Reading3->temp3? It's much less confusing... :-)

2) 'Sensors' doesn't read temp1 because there's another note in the
code saying that temp1 (Reading3) is not implemented in vt1211. That's
not true, in fact Reading3 is the vt1211 internal thermal diode. So
'sensors' (and the libs) needs to be patched as well..

With that I'm proposing the following changes to the vt1211 driver
(both 2.4.x and 2.6.x) and the 'sensors' application (and all involved
parties/libraries as well of course):

Old:
Reading1 -> temp3 (read by 'sensors')
Reading3 -> temp1 (ignored by 'sensors')

New:
Reading1 -> temp1 (read by 'sensors')
Reading3 -> temp3 (read by 'sensors')

And of course sensors.conf has to be patched as well.

Thanks
...juerg


             reply	other threads:[~2005-12-13 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13 20:44 Juerg Haefliger [this message]
2006-01-27 20:57 ` [lm-sensors] vt1211 questions Rudolf Marek
2006-01-29 21:32 ` Juerg Haefliger
2006-01-29 21:44 ` Rudolf Marek
2006-01-29 21:56 ` Jean Delvare
2006-01-30  2:28 ` Juerg Haefliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=191fb4ca0512131244y460b368do91d586d73f21c258@mail.gmail.com \
    --to=juergh@gmail.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.