From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 1/3] lib/librte_ether: remove requirement
	of aligned RETA size
Date: Thu, 30 Mar 2017 02:37:44 +0200
Message-ID: <1920337.9E3jvcbJyk@xps13>
References: <20170316224056.19685-1-yskoh@mellanox.com>
 <cover.1490050764.git.yskoh@mellanox.com>
 <7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com
To: Yongseok Koh <yskoh@mellanox.com>, ferruh.yigit@intel.com,
 helin.zhang@intel.com, konstantin.ananyev@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 3BB1AFC07
 for <dev@dpdk.org>; Thu, 30 Mar 2017 02:37:46 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id l43so38745929wre.1
 for <dev@dpdk.org>; Wed, 29 Mar 2017 17:37:46 -0700 (PDT)
In-Reply-To: <7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-03-20 16:04, Yongseok Koh:
> In rte_eth_check_reta_mask(), it is required to align the size of the RETA
> table to RTE_RETA_GROUP_SIZE but as the size can be less than the limit,
> this should be removed. The change is also applied to a command of testpmd.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
[...]
> -	if (reta_size != RTE_ALIGN(reta_size, RTE_RETA_GROUP_SIZE)) {
> -		RTE_PMD_DEBUG_TRACE("Invalid reta size, should be %u aligned\n",
> -							RTE_RETA_GROUP_SIZE);
> -		return -EINVAL;
> -	}
> -
> -	num = reta_size / RTE_RETA_GROUP_SIZE;
> +	num = (reta_size + RTE_RETA_GROUP_SIZE - 1) / RTE_RETA_GROUP_SIZE;

There is no comment for this constraint neither in the code nor in the
commit: http://dpdk.org/commit/66c594904
So, I guess it can be removed.
If a check is needed, it could be added in the relevant drivers.

Helin, Konstantin, please check for Intel drivers.

Ferruh, please take care of this series.