From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 00/28] Twenty eight patches big Exynos cleanup Date: Sat, 15 Jun 2013 14:19:11 +0200 Message-ID: <1920357.fcgfDKgpf5@flatron> References: <1371238384-1504-1-git-send-email-t.figa@samsung.com> <172701ce6970$5afdf710$10f9e530$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-bk0-f52.google.com ([209.85.214.52]:40393 "EHLO mail-bk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753701Ab3FOMTM (ORCPT ); Sat, 15 Jun 2013 08:19:12 -0400 Received: by mail-bk0-f52.google.com with SMTP id d7so610083bkh.25 for ; Sat, 15 Jun 2013 05:19:10 -0700 (PDT) In-Reply-To: <172701ce6970$5afdf710$10f9e530$%kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: 'Tomasz Figa' , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 'Arnd Bergmann' , 'Olof Johansson' , 'Marek Szyprowski' , 'Sylwester Nawrocki' , 'Thomas Abraham' On Saturday 15 of June 2013 11:30:52 Kukjin Kim wrote: > Tomasz Figa wrote: > > Hi All, > > > > As I promised, I am doing some spring (or rather summer) cleaning > > of Exynos- and Samsung- related code. > > > > This first part consists mostly of removing dead code remaining after > > removal of ATAGS support for Exynos, but several patches cleans up > > other things found by the way. > > > > See particular patches for more detailed description. > > > > On Exynos4210-based Trats board: > > Tested-by: Tomasz Figa > > > > Build tested every patch with s3c6400_defconfig, s5pv210_defconfig > > and exynos_defconfig. > > > > Tomasz Figa (28): > > ARM: EXYNOS: Remove unused board files > > ARM: EXYNOS: Make ARCH_EXYNOS select USE_OF > > ARM: SAMSUNG: Introduce SAMSUNG_ATAGS Kconfig entry > > ARM: EXYNOS: common: Remove legacy PMU initialization code > > ARM: EXYNOS: common: Remove legacy EINT initialization code > > ARM: EXYNOS: common: Remove legacy UART initialization code > > ARM: EXYNOS: Remove legacy dev- and setup- files > > ARM: EXYNOS: common: Remove legacy interrupt initialization code > > ARM: EXYNOS: common: Remove legacy timer initialization code > > ARM: EXYNOS: common: Remove platform device initialization > > ARM: EXYNOS: common: Remove legacy mapping of chip ID block > > ARM: EXYNOS: firmware: Remove check for device tree presence > > ARM: EXYNOS: pm_domains: Remove legacy power domain registration > > code > > ARM: SAMSUNG: Introduce GPIO_SAMSUNG Kconfig entry > > ARM: EXYNOS: Provide compatibility stubs for PM code in pm-core.h > > > > header > > > > ARM: SAMSUNG: Compile s5p-irq-pm only with ATAGS support > > ARM: EXYNOS: Decouple ARCH_EXYNOS from PLAT_S5P > > ARM: SAMSUNG: pm: Include most of mach/ headers conditionally > > ARM: EXYNOS: Do not select legacy Kconfig symbols any more > > ARM: EXYNOS: Remove setup-i2c0.c > > ARM: EXYNOS: Remove mach/gpio.h > > ARM: EXYNOS: Remove mach/regs-gpio.h header > > ARM: SAMSUNG: Make legacy MFC support code depend on SAMSUNG_ATAGS > > ARM: EXYNOS: Select SPARSE_IRQ for Exynos > > ARM: EXYNOS: Remove mach/irqs.h header > > ARM: EXYNOS: Remove unused base addresses from mach/map.h header > > ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412 > > ARM: EXYNOS: Remove mach/regs-usb-phy.h header > > > > arch/arm/Kconfig | 15 +- > > arch/arm/Makefile | 1 + > > arch/arm/mach-exynos/Kconfig | 14 +- > > arch/arm/mach-exynos/Makefile | 6 - > > arch/arm/mach-exynos/common.c | 472 +------- > > arch/arm/mach-exynos/dev-audio.c | 254 ---- > > arch/arm/mach-exynos/dev-uart.c | 55 - > > arch/arm/mach-exynos/firmware.c | 22 +- > > arch/arm/mach-exynos/include/mach/gpio.h | 289 ----- > > arch/arm/mach-exynos/include/mach/irqs.h | 476 -------- > > arch/arm/mach-exynos/include/mach/map.h | 214 ---- > > arch/arm/mach-exynos/include/mach/pm-core.h | 5 + > > arch/arm/mach-exynos/include/mach/regs-gpio.h | 40 - > > arch/arm/mach-exynos/include/mach/regs-usb-phy.h | 74 -- > > arch/arm/mach-exynos/mach-armlex4210.c | 207 ---- > > arch/arm/mach-exynos/mach-nuri.c | 1388 > > --------------------- > > > - > > > > arch/arm/mach-exynos/mach-origen.c | 823 ------------- > > arch/arm/mach-exynos/mach-smdk4x12.c | 396 ------ > > arch/arm/mach-exynos/mach-smdkv310.c | 444 ------- > > arch/arm/mach-exynos/mach-universal_c210.c | 1159 > > ------------------ > > > arch/arm/mach-exynos/pm.c | 1 - > > arch/arm/mach-exynos/pm_domains.c | 94 +- > > arch/arm/mach-exynos/setup-fimc.c | 44 - > > arch/arm/mach-exynos/setup-fimd0.c | 43 - > > arch/arm/mach-exynos/setup-i2c0.c | 29 - > > arch/arm/mach-exynos/setup-i2c1.c | 23 - > > arch/arm/mach-exynos/setup-i2c2.c | 23 - > > arch/arm/mach-exynos/setup-i2c3.c | 23 - > > arch/arm/mach-exynos/setup-i2c4.c | 23 - > > arch/arm/mach-exynos/setup-i2c5.c | 23 - > > arch/arm/mach-exynos/setup-i2c6.c | 23 - > > arch/arm/mach-exynos/setup-i2c7.c | 23 - > > arch/arm/mach-exynos/setup-keypad.c | 36 - > > arch/arm/mach-exynos/setup-sdhci-gpio.c | 152 --- > > arch/arm/mach-exynos/setup-spi.c | 45 - > > arch/arm/mach-exynos/setup-usb-phy.c | 223 ---- > > arch/arm/plat-samsung/Kconfig | 40 +- > > arch/arm/plat-samsung/Makefile | 11 +- > > arch/arm/plat-samsung/include/plat/cpu.h | 6 +- > > arch/arm/plat-samsung/include/plat/pm.h | 5 + > > arch/arm/plat-samsung/init.c | 8 +- > > arch/arm/plat-samsung/pm-gpio.c | 5 +- > > arch/arm/plat-samsung/pm.c | 8 +- > > arch/arm/plat-samsung/s5p-dev-mfc.c | 11 +- > > drivers/cpufreq/Kconfig.arm | 2 +- > > drivers/gpio/Kconfig | 7 + > > drivers/gpio/Makefile | 2 +- > > drivers/media/platform/exynos4-is/Kconfig | 2 +- > > drivers/thermal/exynos_thermal.c | 2 +- > > drivers/tty/serial/samsung.c | 3 +- > > 50 files changed, 115 insertions(+), 7179 deletions(-) > > delete mode 100644 arch/arm/mach-exynos/dev-audio.c > > delete mode 100644 arch/arm/mach-exynos/dev-uart.c > > delete mode 100644 arch/arm/mach-exynos/include/mach/gpio.h > > delete mode 100644 arch/arm/mach-exynos/include/mach/irqs.h > > delete mode 100644 arch/arm/mach-exynos/include/mach/regs-gpio.h > > delete mode 100644 arch/arm/mach-exynos/include/mach/regs-usb-phy.h > > delete mode 100644 arch/arm/mach-exynos/mach-armlex4210.c > > delete mode 100644 arch/arm/mach-exynos/mach-nuri.c > > delete mode 100644 arch/arm/mach-exynos/mach-origen.c > > delete mode 100644 arch/arm/mach-exynos/mach-smdk4x12.c > > delete mode 100644 arch/arm/mach-exynos/mach-smdkv310.c > > delete mode 100644 arch/arm/mach-exynos/mach-universal_c210.c > > delete mode 100644 arch/arm/mach-exynos/setup-fimc.c > > delete mode 100644 arch/arm/mach-exynos/setup-fimd0.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c0.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c1.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c2.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c3.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c4.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c5.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c6.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c7.c > > delete mode 100644 arch/arm/mach-exynos/setup-keypad.c > > delete mode 100644 arch/arm/mach-exynos/setup-sdhci-gpio.c > > delete mode 100644 arch/arm/mach-exynos/setup-spi.c > > delete mode 100644 arch/arm/mach-exynos/setup-usb-phy.c > > > > -- > > 1.8.2.1 > > Basically, looks good. I'm looking at this series then let me take. > > BTW, just note, happens build error with s5pc100_defconfig.... Hmm, I think I might know what the problem is. pm-gpio.c should be compiled only with CONFIG_PM selected, but I made it compile on GPIO_SAMSUNG. Let me check this and send an updated version of patch 14/28, which introduced this modification. Best regards, Tomasz > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_1bit_save': arch/arm/plat-samsung/pm-gpio.c:33:6: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:34:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_1bit_resume': arch/arm/plat-samsung/pm-gpio.c:42:22: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:43:22: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: At top level: > arch/arm/plat-samsung/pm-gpio.c:63:24: error: expected identifier or '(' > before 'void' > arch/arm/plat-samsung/pm-gpio.c:63:24: error: expected ')' before > numeric constant > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_2bit_save': arch/arm/plat-samsung/pm-gpio.c:70:6: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:71:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:72:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_2bit_resume': arch/arm/plat-samsung/pm-gpio.c:129:22: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:130:22: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:136:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: At top level: > arch/arm/plat-samsung/pm-gpio.c:190:24: error: expected identifier or > '(' before 'void' > arch/arm/plat-samsung/pm-gpio.c:190:24: error: expected ')' before > numeric constant > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_4bit_save': arch/arm/plat-samsung/pm-gpio.c:199:6: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:200:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:201:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:204:7: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: In function 'samsung_gpio_pm_4bit_con': > arch/arm/plat-samsung/pm-gpio.c:250:22: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_4bit_resume': arch/arm/plat-samsung/pm-gpio.c:266:22: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:281:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:282:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:284:20: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:286:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:287:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: At top level: > arch/arm/plat-samsung/pm-gpio.c:302:24: error: expected identifier or > '(' before 'void' > arch/arm/plat-samsung/pm-gpio.c:302:24: error: expected ')' before > numeric constant > arch/arm/plat-samsung/pm-gpio.c: In function 'samsung_pm_save_gpios': > arch/arm/plat-samsung/pm-gpio.c:342:3: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:342:3: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:342:3: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:342:3: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: At top level: > arch/arm/plat-samsung/pm-gpio.c:31:13: warning: > 'samsung_gpio_pm_1bit_save' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:37:13: warning: > 'samsung_gpio_pm_1bit_resume' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:68:13: warning: > 'samsung_gpio_pm_2bit_save' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:124:13: warning: > 'samsung_gpio_pm_2bit_resume' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:197:13: warning: > 'samsung_gpio_pm_4bit_save' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:261:13: warning: > 'samsung_gpio_pm_4bit_resume' defined but not used [-Wunused-function] > make[2]: *** [arch/arm/plat-samsung/pm-gpio.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > > - Kukjin > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-samsung-soc" in the body of a message to > majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Sat, 15 Jun 2013 14:19:11 +0200 Subject: [PATCH 00/28] Twenty eight patches big Exynos cleanup In-Reply-To: <172701ce6970$5afdf710$10f9e530$%kim@samsung.com> References: <1371238384-1504-1-git-send-email-t.figa@samsung.com> <172701ce6970$5afdf710$10f9e530$%kim@samsung.com> Message-ID: <1920357.fcgfDKgpf5@flatron> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 15 of June 2013 11:30:52 Kukjin Kim wrote: > Tomasz Figa wrote: > > Hi All, > > > > As I promised, I am doing some spring (or rather summer) cleaning > > of Exynos- and Samsung- related code. > > > > This first part consists mostly of removing dead code remaining after > > removal of ATAGS support for Exynos, but several patches cleans up > > other things found by the way. > > > > See particular patches for more detailed description. > > > > On Exynos4210-based Trats board: > > Tested-by: Tomasz Figa > > > > Build tested every patch with s3c6400_defconfig, s5pv210_defconfig > > and exynos_defconfig. > > > > Tomasz Figa (28): > > ARM: EXYNOS: Remove unused board files > > ARM: EXYNOS: Make ARCH_EXYNOS select USE_OF > > ARM: SAMSUNG: Introduce SAMSUNG_ATAGS Kconfig entry > > ARM: EXYNOS: common: Remove legacy PMU initialization code > > ARM: EXYNOS: common: Remove legacy EINT initialization code > > ARM: EXYNOS: common: Remove legacy UART initialization code > > ARM: EXYNOS: Remove legacy dev- and setup- files > > ARM: EXYNOS: common: Remove legacy interrupt initialization code > > ARM: EXYNOS: common: Remove legacy timer initialization code > > ARM: EXYNOS: common: Remove platform device initialization > > ARM: EXYNOS: common: Remove legacy mapping of chip ID block > > ARM: EXYNOS: firmware: Remove check for device tree presence > > ARM: EXYNOS: pm_domains: Remove legacy power domain registration > > code > > ARM: SAMSUNG: Introduce GPIO_SAMSUNG Kconfig entry > > ARM: EXYNOS: Provide compatibility stubs for PM code in pm-core.h > > > > header > > > > ARM: SAMSUNG: Compile s5p-irq-pm only with ATAGS support > > ARM: EXYNOS: Decouple ARCH_EXYNOS from PLAT_S5P > > ARM: SAMSUNG: pm: Include most of mach/ headers conditionally > > ARM: EXYNOS: Do not select legacy Kconfig symbols any more > > ARM: EXYNOS: Remove setup-i2c0.c > > ARM: EXYNOS: Remove mach/gpio.h > > ARM: EXYNOS: Remove mach/regs-gpio.h header > > ARM: SAMSUNG: Make legacy MFC support code depend on SAMSUNG_ATAGS > > ARM: EXYNOS: Select SPARSE_IRQ for Exynos > > ARM: EXYNOS: Remove mach/irqs.h header > > ARM: EXYNOS: Remove unused base addresses from mach/map.h header > > ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412 > > ARM: EXYNOS: Remove mach/regs-usb-phy.h header > > > > arch/arm/Kconfig | 15 +- > > arch/arm/Makefile | 1 + > > arch/arm/mach-exynos/Kconfig | 14 +- > > arch/arm/mach-exynos/Makefile | 6 - > > arch/arm/mach-exynos/common.c | 472 +------- > > arch/arm/mach-exynos/dev-audio.c | 254 ---- > > arch/arm/mach-exynos/dev-uart.c | 55 - > > arch/arm/mach-exynos/firmware.c | 22 +- > > arch/arm/mach-exynos/include/mach/gpio.h | 289 ----- > > arch/arm/mach-exynos/include/mach/irqs.h | 476 -------- > > arch/arm/mach-exynos/include/mach/map.h | 214 ---- > > arch/arm/mach-exynos/include/mach/pm-core.h | 5 + > > arch/arm/mach-exynos/include/mach/regs-gpio.h | 40 - > > arch/arm/mach-exynos/include/mach/regs-usb-phy.h | 74 -- > > arch/arm/mach-exynos/mach-armlex4210.c | 207 ---- > > arch/arm/mach-exynos/mach-nuri.c | 1388 > > --------------------- > > > - > > > > arch/arm/mach-exynos/mach-origen.c | 823 ------------- > > arch/arm/mach-exynos/mach-smdk4x12.c | 396 ------ > > arch/arm/mach-exynos/mach-smdkv310.c | 444 ------- > > arch/arm/mach-exynos/mach-universal_c210.c | 1159 > > ------------------ > > > arch/arm/mach-exynos/pm.c | 1 - > > arch/arm/mach-exynos/pm_domains.c | 94 +- > > arch/arm/mach-exynos/setup-fimc.c | 44 - > > arch/arm/mach-exynos/setup-fimd0.c | 43 - > > arch/arm/mach-exynos/setup-i2c0.c | 29 - > > arch/arm/mach-exynos/setup-i2c1.c | 23 - > > arch/arm/mach-exynos/setup-i2c2.c | 23 - > > arch/arm/mach-exynos/setup-i2c3.c | 23 - > > arch/arm/mach-exynos/setup-i2c4.c | 23 - > > arch/arm/mach-exynos/setup-i2c5.c | 23 - > > arch/arm/mach-exynos/setup-i2c6.c | 23 - > > arch/arm/mach-exynos/setup-i2c7.c | 23 - > > arch/arm/mach-exynos/setup-keypad.c | 36 - > > arch/arm/mach-exynos/setup-sdhci-gpio.c | 152 --- > > arch/arm/mach-exynos/setup-spi.c | 45 - > > arch/arm/mach-exynos/setup-usb-phy.c | 223 ---- > > arch/arm/plat-samsung/Kconfig | 40 +- > > arch/arm/plat-samsung/Makefile | 11 +- > > arch/arm/plat-samsung/include/plat/cpu.h | 6 +- > > arch/arm/plat-samsung/include/plat/pm.h | 5 + > > arch/arm/plat-samsung/init.c | 8 +- > > arch/arm/plat-samsung/pm-gpio.c | 5 +- > > arch/arm/plat-samsung/pm.c | 8 +- > > arch/arm/plat-samsung/s5p-dev-mfc.c | 11 +- > > drivers/cpufreq/Kconfig.arm | 2 +- > > drivers/gpio/Kconfig | 7 + > > drivers/gpio/Makefile | 2 +- > > drivers/media/platform/exynos4-is/Kconfig | 2 +- > > drivers/thermal/exynos_thermal.c | 2 +- > > drivers/tty/serial/samsung.c | 3 +- > > 50 files changed, 115 insertions(+), 7179 deletions(-) > > delete mode 100644 arch/arm/mach-exynos/dev-audio.c > > delete mode 100644 arch/arm/mach-exynos/dev-uart.c > > delete mode 100644 arch/arm/mach-exynos/include/mach/gpio.h > > delete mode 100644 arch/arm/mach-exynos/include/mach/irqs.h > > delete mode 100644 arch/arm/mach-exynos/include/mach/regs-gpio.h > > delete mode 100644 arch/arm/mach-exynos/include/mach/regs-usb-phy.h > > delete mode 100644 arch/arm/mach-exynos/mach-armlex4210.c > > delete mode 100644 arch/arm/mach-exynos/mach-nuri.c > > delete mode 100644 arch/arm/mach-exynos/mach-origen.c > > delete mode 100644 arch/arm/mach-exynos/mach-smdk4x12.c > > delete mode 100644 arch/arm/mach-exynos/mach-smdkv310.c > > delete mode 100644 arch/arm/mach-exynos/mach-universal_c210.c > > delete mode 100644 arch/arm/mach-exynos/setup-fimc.c > > delete mode 100644 arch/arm/mach-exynos/setup-fimd0.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c0.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c1.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c2.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c3.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c4.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c5.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c6.c > > delete mode 100644 arch/arm/mach-exynos/setup-i2c7.c > > delete mode 100644 arch/arm/mach-exynos/setup-keypad.c > > delete mode 100644 arch/arm/mach-exynos/setup-sdhci-gpio.c > > delete mode 100644 arch/arm/mach-exynos/setup-spi.c > > delete mode 100644 arch/arm/mach-exynos/setup-usb-phy.c > > > > -- > > 1.8.2.1 > > Basically, looks good. I'm looking at this series then let me take. > > BTW, just note, happens build error with s5pc100_defconfig.... Hmm, I think I might know what the problem is. pm-gpio.c should be compiled only with CONFIG_PM selected, but I made it compile on GPIO_SAMSUNG. Let me check this and send an updated version of patch 14/28, which introduced this modification. Best regards, Tomasz > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_1bit_save': arch/arm/plat-samsung/pm-gpio.c:33:6: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:34:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_1bit_resume': arch/arm/plat-samsung/pm-gpio.c:42:22: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:43:22: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: At top level: > arch/arm/plat-samsung/pm-gpio.c:63:24: error: expected identifier or '(' > before 'void' > arch/arm/plat-samsung/pm-gpio.c:63:24: error: expected ')' before > numeric constant > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_2bit_save': arch/arm/plat-samsung/pm-gpio.c:70:6: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:71:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:72:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_2bit_resume': arch/arm/plat-samsung/pm-gpio.c:129:22: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:130:22: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:136:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: At top level: > arch/arm/plat-samsung/pm-gpio.c:190:24: error: expected identifier or > '(' before 'void' > arch/arm/plat-samsung/pm-gpio.c:190:24: error: expected ')' before > numeric constant > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_4bit_save': arch/arm/plat-samsung/pm-gpio.c:199:6: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:200:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:201:6: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:204:7: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: In function 'samsung_gpio_pm_4bit_con': > arch/arm/plat-samsung/pm-gpio.c:250:22: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: In function > 'samsung_gpio_pm_4bit_resume': arch/arm/plat-samsung/pm-gpio.c:266:22: > error: 'struct samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:281:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:282:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:284:20: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:286:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:287:19: error: 'struct > samsung_gpio_chip' has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: At top level: > arch/arm/plat-samsung/pm-gpio.c:302:24: error: expected identifier or > '(' before 'void' > arch/arm/plat-samsung/pm-gpio.c:302:24: error: expected ')' before > numeric constant > arch/arm/plat-samsung/pm-gpio.c: In function 'samsung_pm_save_gpios': > arch/arm/plat-samsung/pm-gpio.c:342:3: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:342:3: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:342:3: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c:342:3: error: 'struct samsung_gpio_chip' > has no member named 'pm_save' > arch/arm/plat-samsung/pm-gpio.c: At top level: > arch/arm/plat-samsung/pm-gpio.c:31:13: warning: > 'samsung_gpio_pm_1bit_save' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:37:13: warning: > 'samsung_gpio_pm_1bit_resume' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:68:13: warning: > 'samsung_gpio_pm_2bit_save' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:124:13: warning: > 'samsung_gpio_pm_2bit_resume' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:197:13: warning: > 'samsung_gpio_pm_4bit_save' defined but not used [-Wunused-function] > arch/arm/plat-samsung/pm-gpio.c:261:13: warning: > 'samsung_gpio_pm_4bit_resume' defined but not used [-Wunused-function] > make[2]: *** [arch/arm/plat-samsung/pm-gpio.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > > - Kukjin > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-samsung-soc" in the body of a message to > majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html