From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E62C433F5 for ; Tue, 29 Mar 2022 15:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238874AbiC2PjF (ORCPT ); Tue, 29 Mar 2022 11:39:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238867AbiC2PjC (ORCPT ); Tue, 29 Mar 2022 11:39:02 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9776424F28A for ; Tue, 29 Mar 2022 08:37:18 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id e22so21397510ioe.11 for ; Tue, 29 Mar 2022 08:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gLd51ggOlUdHIwZ00EZlLb4mWuNUvjnU3+SzIZdxmOk=; b=K57WW/FddBde/rRXMUA9BaYE3N0lAuDneUX1KCIBFxf4CXh4Z4eKQOUqC788YMGaXX MQF7yOu4tf8KM9LcmtcceBE2QTiyQQM/8vESJFK5zLjXOr7BViiSBXqZ/+143NMwIIdc orlNUiAl/hdFW4dDa9vE//ejvyaewYcHdewJE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gLd51ggOlUdHIwZ00EZlLb4mWuNUvjnU3+SzIZdxmOk=; b=rj3xObjTKkxKc4pvpCcm+5R8kqrVZVmqKjEMzypHTAcOYe5w5immADMXEHxz+z5jiH 3V0NiadAu7T6YO3o+Rv3Af7N8UDSeDQMKfWmlCpy6F6B+fTaB0GAcGd4ULETFmo+XExv lY7upP1QtZyJFI8Q0bSOKdF9ti0tDGz6lA6RYLo1abvm943PVGG0xbNi/D3afE3ahCDU C5IP2m8Hs99sKOsUodX2t4rXev3f4wFdUwF9191MH3mGtRwxi28x8LzGPgZrNRf+oojl dtOyR1DqASajKmMD15EOYZm/k2DNtA3Efpgc6rSga4fB0WXK/X8iUfARieo7L+kvlOMe CG8Q== X-Gm-Message-State: AOAM5308dm7XVKAbIzZxyGqyynTOPUrcTf2voQK8OwhCii0VfmyVUpJf w4+kFejLL3fEyVqhwaDgvn57IQ== X-Google-Smtp-Source: ABdhPJwCzXCHjBRdz35SXshxWvTj2yFFE0frjiP5HGkRVMCtMtFRNLjnUjRXfQCtSR1PiZiMusPBYg== X-Received: by 2002:a6b:400b:0:b0:64c:77aa:40a6 with SMTP id k11-20020a6b400b000000b0064c77aa40a6mr5480515ioa.101.1648568237910; Tue, 29 Mar 2022 08:37:17 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id f20-20020a6be814000000b00649d9a4db2asm9706513ioh.27.2022.03.29.08.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Mar 2022 08:37:17 -0700 (PDT) Subject: Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU To: Shaopeng Tan , Fenghua Yu , Reinette Chatre , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220323080928.1586408-1-tan.shaopeng@jp.fujitsu.com> From: Shuah Khan Message-ID: <1920a6b6-bc1b-31db-4c1b-efccc189daa5@linuxfoundation.org> Date: Tue, 29 Mar 2022 09:37:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220323080928.1586408-1-tan.shaopeng@jp.fujitsu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/22 2:09 AM, Shaopeng Tan wrote: > Hello, > > The aim of this series is to print a message to let users know a possible > cause of failure, if the result of MBM&CMT tests is failed on Intel CPU. > In order to detect Intel vendor, I extended AMD vendor detect function. > > Difference from v4: > - Fixed the typos. > - Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL". > - Reorder the declarations based on line length from longest to shortest. > https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com/ [PATCH v4] > > This patch series is based on v5.17. > > Shaopeng Tan (2): > selftests/resctrl: Extend CPU vendor detection > selftests/resctrl: Print a message if the result of MBM&CMT tests is > failed on Intel CPU > > tools/testing/selftests/resctrl/cat_test.c | 2 +- > tools/testing/selftests/resctrl/resctrl.h | 5 ++- > .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------ > tools/testing/selftests/resctrl/resctrlfs.c | 2 +- > 4 files changed, 37 insertions(+), 17 deletions(-) > I can queue this up for Linux 5.18-rc2. Thanks for fixing the error path with clear messages for failures. thanks, -- Shuah