From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] ethdev: add flow API rule copy function Date: Wed, 28 Jun 2017 00:00:02 +0200 Message-ID: <1925976.ZpGJHZ6fsM@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, adrien.mazarguil@6wind.com To: Gaetan Rivet Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B8A382BE1 for ; Wed, 28 Jun 2017 00:00:05 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/05/2017 17:21, Gaetan Rivet: > +/** > + * Flow elements description tables. > + */ > +struct rte_flow_desc_data { > + const char *name; > + size_t size; > +}; > + > +extern const struct rte_flow_desc_data rte_flow_desc_item[]; > +extern size_t rte_flow_nb_item; > + > +extern const struct rte_flow_desc_data rte_flow_desc_action[]; > +extern size_t rte_flow_nb_action; Those externs are weirds. At least, it needs to be declared in the .map: --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -153,6 +153,10 @@ DPDK_17.08 { global: rte_flow_copy; + rte_flow_desc_action; + rte_flow_desc_item; rte_flow_isolate; + rte_flow_nb_action; + rte_flow_nb_item; } DPDK_17.05;