From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbeAZOfq (ORCPT ); Fri, 26 Jan 2018 09:35:46 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:32858 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbeAZOfo (ORCPT ); Fri, 26 Jan 2018 09:35:44 -0500 Subject: Re: [PATCH v1 0/2] Kconfig changes to enable Graphics Support for S390 To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , linux-s390 , Linux Fbdev development list , Martin Schwidefsky , Christian Borntraeger , Stefan Kristiansson , Tomi Valkeinen References: From: Farhan Ali Date: Fri, 26 Jan 2018 09:35:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18012614-0052-0000-0000-000002AA0565 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008431; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000248; SDB=6.00980657; UDB=6.00497147; IPR=6.00759958; BA=6.00005796; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019225; XFM=3.00000015; UTC=2018-01-26 14:35:40 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012614-0053-0000-0000-0000535ECE0F Message-Id: <19306e74-7c9b-5644-6f08-bbaef226afd8@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-26_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801260192 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2018 08:41 AM, Geert Uytterhoeven wrote: > Hi Farhan, > > On Thu, Jan 25, 2018 at 4:47 PM, Farhan Ali wrote: >> This series of patches are in preparation for enabling an additional >> tty and console for a S390 KVM guest using a virtio-gpu device[1]. >> One of the steps to do this would be to enable CONFIG_VT for S390, >> and this would also require the dummy console (CONFIG_DUMMY_CONSOLE). >> >> Patch 1 enables the "Graphics support" menu which is >> needed to enable dummy console, since the VT layer needs it. >> >> Patch 2 fixes a Kconfig dependency issue for opencores >> framebuffer devices. This issue was exposed by the previous >> patch. >> >> Thanks >> Farhan >> >> >> [1] https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg04184.html >> >> Farhan Ali (2): >> Kconfig : Remove HAS_IOMEM dependency for Graphics support >> fbdev: Kconfig: Add HAS_IOMEM dependency for FB_OPENCORES >> >> drivers/video/Kconfig | 1 - >> drivers/video/fbdev/Kconfig | 2 +- >> 2 files changed, 1 insertion(+), 2 deletions(-) > > Shouldn't the order of your two patches be inverted, to avoid patch 1 > introducing > build breakage fixed by patch 2? > > Gr{oetje,eeting}s, > > Geert > Hi Geert, I wasn't sure what would be the best ordering since we would never hit the issue if patch 1 didn't exist. But if the preference is to invert the ordering of patches, then I will change the ordering. Thank you for reviewing. Thanks Farhan > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Farhan Ali Date: Fri, 26 Jan 2018 14:35:36 +0000 Subject: Re: [PATCH v1 0/2] Kconfig changes to enable Graphics Support for S390 Message-Id: <19306e74-7c9b-5644-6f08-bbaef226afd8@linux.vnet.ibm.com> References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Archive: List-Post: To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , linux-s390 , Linux Fbdev development list , Martin Schwidefsky , Christian Borntraeger , Stefan Kristiansson , Tomi Valkeinen List-ID: On 01/26/2018 08:41 AM, Geert Uytterhoeven wrote: > Hi Farhan, > > On Thu, Jan 25, 2018 at 4:47 PM, Farhan Ali wrote: >> This series of patches are in preparation for enabling an additional >> tty and console for a S390 KVM guest using a virtio-gpu device[1]. >> One of the steps to do this would be to enable CONFIG_VT for S390, >> and this would also require the dummy console (CONFIG_DUMMY_CONSOLE). >> >> Patch 1 enables the "Graphics support" menu which is >> needed to enable dummy console, since the VT layer needs it. >> >> Patch 2 fixes a Kconfig dependency issue for opencores >> framebuffer devices. This issue was exposed by the previous >> patch. >> >> Thanks >> Farhan >> >> >> [1] https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg04184.html >> >> Farhan Ali (2): >> Kconfig : Remove HAS_IOMEM dependency for Graphics support >> fbdev: Kconfig: Add HAS_IOMEM dependency for FB_OPENCORES >> >> drivers/video/Kconfig | 1 - >> drivers/video/fbdev/Kconfig | 2 +- >> 2 files changed, 1 insertion(+), 2 deletions(-) > > Shouldn't the order of your two patches be inverted, to avoid patch 1 > introducing > build breakage fixed by patch 2? > > Gr{oetje,eeting}s, > > Geert > Hi Geert, I wasn't sure what would be the best ordering since we would never hit the issue if patch 1 didn't exist. But if the preference is to invert the ordering of patches, then I will change the ordering. Thank you for reviewing. Thanks Farhan > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >